Skip to content

feat(reports): leftover-map person coordinates on leftover-map graphic leftover-map post markers independently of leftover-map comparison graphic leftover-map post markers (v2.95.0) - #880

Draft
seonghobae wants to merge 1 commit into
feat/leftover-map-compare-plot-post-coordinates-v2940from
feat/leftover-map-plot-post-coordinates-v2950
Draft

feat(reports): leftover-map person coordinates on leftover-map graphic leftover-map post markers independently of leftover-map comparison graphic leftover-map post markers (v2.95.0)#880
seonghobae wants to merge 1 commit into
feat/leftover-map-compare-plot-post-coordinates-v2940from
feat/leftover-map-plot-post-coordinates-v2950

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • leftoverMapPlotLayout.test.ts leftoverMapPlotPostBadge names ξ (+0.50, +0.10) / ξ (−0.70, −0.40), rank-0 ξ (0.00, 0.00), omits null/NaN/∞ independently of leftover-map comparison graphic leftover-map post ξ, distinct from leftoverMapComparePlotPostBadge / leftover-map graphic leftover-map criterion
  • LeftoverMapPlot.test.tsx leftover-map graphic leftover-map post Open leftover-map post Public post at ξ (+0.50, +0.10); leftover-map comparison graphic leftover-map post stays Open leftover map comparison graphic leftover-map post Public post at ξ (+0.50, +0.10)
  • App.test.tsx leftover-map graphic leftover-map post length 1; grouping comparison leftover-map post stays comparison name
  • oxlint 0 + tsc -b + vitest leftover-map + App + i18n (647 passed)

Devin Review

…c leftover-map post markers independently of leftover-map comparison graphic leftover-map post markers (v2.95.0)

Caption leftover-map graphic leftover-map post markers with persisted leftover-map person coordinates through leftoverMapPlotPostBadge independently of leftover-map comparison graphic leftover-map post markers (ADR 0338). Rank-0 unused axes still name leftover-map person coordinates (0.00, 0.00). A missing or non-finite leftover-map person coordinate pair omits independently of leftover-map comparison graphic leftover-map post ξ. Do not invent leftover-map person coordinates from leftover-map item coordinates ζ. UI-only; no SQL; never invent a leftover score or a theta.
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 23 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cd34705a-0e82-40e2-92e0-5f7469f63fff

📥 Commits

Reviewing files that changed from the base of the PR and between d9972c2 and c69459a.

📒 Files selected for processing (19)
  • AGENTS.md
  • ARCHITECTURE.md
  • CHANGELOG.d/2.95.0-leftover-map-plot-post-coordinates.md
  • CHANGELOG.md
  • CLAUDE.md
  • docs/adr/0267-leftover-map-coordinates.md
  • docs/adr/0268-leftover-map-graphic-display.md
  • docs/adr/0304-leftover-map-compare-graphic.md
  • docs/adr/0334-leftover-map-axis-tick-share-badge.md
  • docs/adr/0337-leftover-map-compare-plot-post-coordinates.md
  • docs/adr/0338-leftover-map-plot-post-coordinates.md
  • docs/product-technical-gap-baseline.md
  • docs/storybook-inventory.md
  • frontend/package.json
  • frontend/src/components/LeftoverMapPlot.test.tsx
  • frontend/src/components/LeftoverMapPlot.tsx
  • frontend/src/leftoverMapPlotLayout.test.ts
  • frontend/src/leftoverMapPlotLayout.ts
  • pyproject.toml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Stacked on #879 @ d9972c2. leftoverMapPlotPostBadge names leftover-map graphic leftover-map post leftover-map person coordinates independently of leftover-map comparison graphic leftover-map post markers (ADR 0338 / v2.95.0). Comparison leftover-map post action is unchanged. Rank-0 origin still names (0.00, 0.00). Fail-closed omit on missing/non-finite ξ keeps Open leftover-map post {title}. UI-only; no SQL; no new columns. Do not persist leftover-map inner product/cosine/length. Leave open for independent review. Devin COMMENT is not independent APPROVE. Do not self-approve. Do not squash-merge onto the unprotected leftover-map base. Issues #79 and #87 stay open. Do not merge #808. Do not mix #877 origin-tick stack.

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

Independent review request for leftoverMapPlotPostBadge (ADR 0338 / v2.95.0). Devin COMMENT is not independent APPROVE. Do not self-approve. Do not squash-merge.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

@seonghobae I will perform an independent review of #880. I will not self-approve or squash-merge the pull request.

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-31T17:28 KST: #880 @ c69459a (v2.95.0 leftoverMapPlotPostBadge / ADR 0338) is the exact-head leftover-map graphic leftover-map post ξ increment. Independent APPROVE still required. Do not self-approve. Do not squash-merge. Next buyer increment stacks leftover-map pair-list leftover-map post leftover-map person coordinates independently of leftover-map pair-list leftover-map criterion leftover-map item coordinates.

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-31T17:20 KST: #880 @ c69459a (v2.95.0 leftoverMapPlotPostBadge / ADR 0338) still lacks independent APPROVE. Devin COMMENT is not APPROVE. Do not self-approve. Do not squash-merge onto the unprotected leftover-map base.

Next buyer increment stacks leftover-map pair-list leftover-map post leftover-map person coordinates independently of leftover-map pair-list leftover-map criterion leftover-map item coordinates as leftoverMapListPostBadge (ADR 0339 / v2.96.0) onto this exact head. Distinct accessible name leftover pair leftover-map post {title} at ξ {person}. Missing/non-finite ξ omits independently so finite ξ still names when ζ is missing. Rank-0 still names (0.00, 0.00). Do not invent ξ from ζ. leftoverMapPlotPostBadge and leftoverMapComparePlotPostBadge stay unchanged this increment. Issues #79 and #87 stay open. Do not merge #808. Do not mix #877.

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-31T17:40 KST: #880 @ c69459a (v2.95.0 leftoverMapPlotPostBadge / ADR 0338) still lacks independent APPROVE. Devin COMMENT is not APPROVE. Do not self-approve. Do not squash-merge onto the leftover-map stack. Issues #79 and #87 stay OPEN. Do not merge #808 without independent APPROVE. Do not mix #877 origin-tick stack.

Next buyer increment: leftoverMapListPostBadge (ADR 0339 / v2.96.0) names leftover-map pair-list leftover-map post leftover-map person coordinates independently of leftover-map pair leftover-map criterion leftover-map item coordinates. Stack onto this exact head. Distinct accessible name leftover pair leftover-map post {title} at ξ {person}. Missing ξ omits independently so finite ξ still names when ζ is missing. Rank-0 still (0.00, 0.00). Do not invent leftover scores or thetas.

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

Independent review request for leftoverMapPlotPostBadge (ADR 0338 / v2.95.0) exact head c69459a. Devin COMMENT is not independent APPROVE. Do not self-approve. Do not squash-merge.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

@seonghobae I will perform an independent review of #880 at c69459a. I will not self-approve or squash-merge the pull request.

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Copy Markdown
Contributor Author

#881 leftoverMapListPostBadge (ADR 0339 / v2.96.0) is stacked on this exact head @ c69459a. Distinct accessible name leftover pair leftover-map post {title} at ξ {person}. Missing ξ omits independently so finite ξ still names when ζ is missing. Rank-0 still (0.00, 0.00). Leftover-map graphic leftover-map post markers stay Open leftover-map post {title} at ξ {person}. Leave both PRs open for independent review. Do not self-approve. Do not squash-merge.

@seonghobae
seonghobae marked this pull request as draft September 4, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant