feat(reports): leftover-map person coordinates on leftover-map pair leftover-map post independently of leftover-map pair leftover-map criterion leftover-map item coordinates (v2.96.0) - #881
Conversation
…eftover-map post independently of leftover-map pair leftover-map criterion leftover-map item coordinates (v2.96.0)
ADR 0339 leftoverMapListPostBadge names leftover-map pair leftover-map post leftover-map person coordinates independently of leftover-map pair leftover-map criterion leftover-map item coordinates. Distinct accessible name leftover pair leftover-map post {title} at ξ {person}. Missing ξ omits independently so finite ξ still names when ζ is missing. Rank-0 still (0.00, 0.00). Do not invent leftover scores or thetas. Stack onto leftoverMapPlotPostBadge (ADR 0338 / v2.95.0).
|
Warning Review limit reachedNext included review available in 16 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (24)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review Independent review request for leftoverMapListPostBadge (ADR 0339 / v2.96.0) exact head 167888d stacked on #880 @ c69459a. Devin COMMENT is not independent APPROVE. Do not self-approve. Do not squash-merge. Do not mix #877. Issues #79 and #87 stay OPEN. Do not merge #808 without independent APPROVE. |
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| aria-label={ | ||
| listPostBadge !== null | ||
| ? tf(listPostBadge.key, listPostBadge.values) |
There was a problem hiding this comment.
🟡 Pair buttons become indistinguishable
When two pairs share a post, aria-label gives both its title and coordinates. Screen readers lose each pair’s direction and criterion.
Prompt for agents
Preserve the pair kind and criterion in the accessible name when finite person coordinates are added. LeftoverPairList can emit closest and farthest rows for the same post, and every row for one post shares its title and person coordinates. The new coordinate-only aria-label therefore creates duplicate button names. Update the ADR 0339 label contract, translation key and tests together so the coordinate is included without removing the existing pair identity.
Was this helpful? React with 👍 or 👎 to provide feedback.
| export function leftoverMapListPostBadge( | ||
| title: string, | ||
| axis1: number | null | undefined, | ||
| axis2: number | null | undefined, | ||
| ): LeftoverMapListPostBadge | null { | ||
| const person = formatLeftoverMapCoordinatePair(axis1, axis2); | ||
| if (person === null) { | ||
| return null; | ||
| } | ||
| return { key: LEFTOVER_MAP_LIST_POST_ACTION, values: { title, person } }; |
There was a problem hiding this comment.
📝 Info: Person coordinates remain independent
leftoverMapListPostBadge accepts finite zero and negative values. Missing item coordinates cannot suppress the person-coordinate caption.
Was this helpful? React with 👍 or 👎 to provide feedback.
| : tf("Open leftover {kind} pair: {title} · {criterion}", { | ||
| kind: pair.pair_kind, | ||
| title: pair.post_title, | ||
| criterion, | ||
| }) |
There was a problem hiding this comment.
📝 Info: Older payloads retain labels
Missing or non-finite person coordinates preserve the existing pair direction, title, and criterion in the accessible name.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Cycle 2026-08-31T18:28 KST: write probe. Independent APPROVE still required on exact head |
|
Stacked leftover-map pair leftover-map criterion leftover-map item coordinates (v2.97.0 / ADR 0340 leftoverMapListCriterionBadge) on This PR (#881) still needs independent APPROVE on this exact head. Devin COMMENT is not APPROVE. Do not self-approve. Do not squash-merge. Do not mix #877 origin-tick stack. Issues #79 and #87 stay OPEN. |
seonghobae
added
enhancement
ChatGPT Codex Connector
1 participant
Summary
Stacked on #880 @
c69459a(feat/leftover-map-plot-post-coordinates-v2950). leftoverMapListPostBadge (ADR 0339 / v2.96.0) names leftover-map pair leftover-map post leftover-map person coordinates independently of leftover-map pair leftover-map criterion leftover-map item coordinates.leftover pair leftover-map post {title} at ξ {person}when leftover-map person coordinates are finite.Open leftover {kind} pair: {title} · {criterion}.ζare missing (formatLeftoverMapCoordinatesstill requires both).(0.00, 0.00).Open leftover-map post {title} at ξ {person}.Open leftover map comparison graphic leftover-map post {title} at ξ {person}.ζ. Do not invent leftover-map item coordinatesζfrom leftover-map person coordinatesξ.Test plan
pnpm exec oxlinton leftover-map pair-list files: 0 warnings, 0 errorspnpm exec tsc -bcleanLeave open for independent review. Do not self-approve. Do not squash-merge.