Skip to content

feat(reports): leftover-map comparison leftover-axis origin ticks independently of leftover-map axis share and leftover-map singular values (v2.102.0) - #887

Draft
seonghobae wants to merge 1 commit into
feat/leftover-map-compare-plot-tick-origin-badge-v21010from
feat/leftover-map-compare-axis-tick-origin-badge-v21020
Draft

feat(reports): leftover-map comparison leftover-axis origin ticks independently of leftover-map axis share and leftover-map singular values (v2.102.0)#887
seonghobae wants to merge 1 commit into
feat/leftover-map-compare-plot-tick-origin-badge-v21010from
feat/leftover-map-compare-axis-tick-origin-badge-v21020

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Stacked on #886 @ 4a31a41 (feat/leftover-map-compare-plot-tick-origin-badge-v21010). leftoverMapCompareAxisTickBadge (ADR 0345 / v2.102.0) names leftover-map comparison leftover-axis origin ticks independently of leftover-map axis share and leftover-map singular values.

  • Distinct accessible name leftover map comparison leftover axis {axis} origin tick {value} when leftoverMapPlotTickIsOrigin returns true (formatSignedLeftoverValue(0) === 0.00).
  • Rank-0 unused axes still name leftover-map origin 0.00.
  • Share and singular omit independently as leftover map comparison leftover axis {axis} origin tick {value} σ {singular}, leftover map comparison leftover axis {axis} origin tick {value} {share}%, and leftover map comparison leftover axis {axis} origin tick {value} σ {singular} {share}%.
  • Non-origin leftover-map comparison leftover-axis ticks stay leftover map comparison leftover axis {axis} tick {value}.
  • leftoverMapPlotTickAxisBadge stays leftover-map graphic leftover-map axis origin tick keys from ADR 0343.
  • leftoverMapComparePlotTickAxisBadge stays leftover-map comparison graphic leftover-map axis origin tick keys from ADR 0344.
  • leftoverMapAxisTickBadge stays leftover-map tick keys this increment. Do not mix feat(reports): leftover-map origin on leftover-map comparison graphic leftover-map axis ticks independently of leftover-map axis share and leftover-map singular values (v2.92.0) #877.
  • Do not invent leftover-map origin from leftover-map axis share or leftover-map singular values σ_k.
  • UI-only. No SQL. No new columns. Never invent a leftover score. Never invent a theta.

Test plan

Leave open for independent review. Do not self-approve. Do not squash-merge.


Devin Review

…ependently of leftover-map axis share and leftover-map singular values (v2.102.0)
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c00c8b09-5aa4-4be9-903e-3717805e9b57

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Exact head 7637fc8. oxlint 0/0, tsc -b clean, vitest 761 passed on leftover-map origin-tick files. Independent APPROVE required on this exact head (Devin COMMENT is not APPROVE). Leave stacked leftover-map PRs open. Do not squash-merge onto unprotected leftover bases. Do not mix #877. Issues #79 and #87 stay OPEN. Do not merge #808 without independent APPROVE. Do not self-approve.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-31T19:35KST: GitHub write probe. Independent APPROVE still required on exact head 7637fc8. Do not self-approve. Do not squash-merge. Issues #79 and #87 stay OPEN.

Copy link
Copy Markdown
Contributor Author

Cycle write probe (2026-08-31T10:40Z): independent APPROVE still required on exact head 7637fc8. Do not self-approve. Next buyer gap is leftover-map origin on leftover-axis ticks independently of leftover-map axis share and leftover-map singular values (v2.103.0), stacked on this head — not mixed into #74/#92 (already merged).

Copy link
Copy Markdown
Contributor Author

write-probe via gh api 2026-08-31T10:40Z — independent APPROVE still required; do not self-approve.

Copy link
Copy Markdown
Contributor Author

Next stacked increment is #889 leftover-map leftover-axis origin ticks independently of leftover-map axis share and leftover-map singular values (ADR 0346 / v2.103.0) @ 4bfb490 on feat/leftover-map-axis-tick-origin-badge-v21030. Independent APPROVE still required on this exact head 7637fc8 (Devin COMMENT is not APPROVE). Leave stacked leftover-map PRs open. Do not self-approve. Do not squash-merge. Do not mix #877. Issues #79 and #87 stay OPEN. Do not merge #808 without independent APPROVE.

Copy link
Copy Markdown
Contributor Author

Stacked #889 @ 4bfb490 (v2.103.0 / ADR 0346) names leftover-map leftover-axis origin ticks via leftoverMapAxisTickBadge independently of leftover-map axis share and leftover-map singular values. This PR (#887, leftoverMapCompareAxisTickBadge origin) remains the base. Do not squash-merge. Independent APPROVE required on this exact head. Do not mix #877. #79 and #87 stay open.

@seonghobae
seonghobae marked this pull request as draft September 3, 2026 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant