Skip to content

blockifier_reexecution: delete RpcStateReader methods superseded by get_block_info_with_txs#13834

Open
AvivYossef-starkware wants to merge 1 commit intoaviv/reexecution-thread-block-info-with-txsfrom
aviv/reexecution-delete-redundant-methods
Open

blockifier_reexecution: delete RpcStateReader methods superseded by get_block_info_with_txs#13834
AvivYossef-starkware wants to merge 1 commit intoaviv/reexecution-thread-block-info-with-txsfrom
aviv/reexecution-delete-redundant-methods

Conversation

@AvivYossef-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

AvivYossef-starkware commented Apr 20, 2026

@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 20, 2026

PR Summary

Low Risk
Low risk refactor that removes redundant RPC helper methods and related tests; behavior should remain unchanged as callers now rely on the existing get_block_info_with_txs/build_block_context flow.

Overview
Simplifies RpcStateReader by removing now-redundant methods (get_block_info, get_starknet_version, get_tx_hashes, get_all_txs_in_block, get_versioned_constants, get_block_context) in favor of the existing single-call get_block_info_with_txs + build_block_context path.

Updates RPC HTTP tests to stop exercising the deleted APIs (and derives test_block_number from get_block_info_with_txs), reducing surface area and duplication.

Reviewed by Cursor Bugbot for commit 28bfd4a. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants