blockifier_reexecution: extract contract_class_mapping_dumper into ConsecutiveRpcStateReaders

[AvivYossef-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[AvivYossef-starkware]

• blockifier_reexecution: delete RpcStateReader methods superseded by get_block_info_with_txs #13834
• blockifier_reexecution: cache BlockInfoWithTxs in consecutive readers to dedupe RPC fetches #13833
• blockifier_reexecution: add get_block_info_with_txs for single-call block fetch #13832
• blockifier_reexecution,starknet_transaction_prover: support DeployAccount V3 in simulate prefetch #13778
• blockifier_reexecution,starknet_transaction_prover: graceful fallback on prefetch failure #13743
• blockifier_reexecution,starknet_transaction_prover: parameterize skip_fee_charge in prefetch #13738
• blockifier_reexecution: remove fallback warn logs from SimulatedStateReader #13737
• blockifier_reexecution: wire prefetch_initial_reads into replay CLI #13712
• blockifier_reexecution: add prefetch_initial_reads to ConsecutiveRpcStateReaders #13711
• blockifier_reexecution: extract contract_class_mapping_dumper into ConsecutiveRpcStateReaders #13741 👈 (View in Graphite)
• blockifier_reexecution: add PrefetchedStateReader and move from starknet_transaction_prover #13654
• main-v0.14.2

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

PR Summary

Medium Risk
Medium risk because it changes how the contract-class mapping used for offline reexecution dumps is retained and consumed; mistakes could lead to missing mappings or panics during dump serialization.

Overview
Refactors offline reexecution dumping to store the contract_class_mapping_dumper directly on ConsecutiveRpcStateReaders, cloning the same Arc<Mutex<...>> from the initially-created last_block_state_reader.

When writing block reexecution data, the code now clones this Arc before self is consumed and then moves the mapping out via take() (instead of retrieving/cloning it through the nested block_state reader), ensuring the collected contract classes are captured for serialization without extra clones.

^{Reviewed by Cursor Bugbot for commit 1614cea. Bugbot is set up for automated code reviews on this repo. Configure here.}

[Yoni-Starkware]

@Yoni-Starkware made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on AvivYossef-starkware and noaov1).

---

crates/blockifier_reexecution/src/state_reader/rpc_state_reader.rs line 708 at r1 (raw file):

        let serializable_data_prev_block = SerializableDataPrevBlock {
            state_maps: block_state.get_initial_reads().unwrap(),
            contract_class_mapping: contract_class_mapping_dumper.lock().unwrap().clone().unwrap(),

Why do you need this additional clone?

Code quote:

er.lock().unwrap().clone().unwrap()

[AvivYossef-starkware]

@AvivYossef-starkware made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on noaov1 and Yoni-Starkware).

---

crates/blockifier_reexecution/src/state_reader/rpc_state_reader.rs line 708 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Why do you need this additional clone?

We can take it here since it's the end of its use,

[Yoni-Starkware]

@Yoni-Starkware reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on noaov1).