blockifier_reexecution: remove fallback warn logs from SimulatedStateReader#13737
Conversation
PR SummaryLow Risk Overview This reduces log noise in reexecution flows where cache misses are expected (e.g., for non-invoke-v3 transaction types) without changing read behavior. Reviewed by Cursor Bugbot for commit 2086d68. Bugbot is set up for automated code reviews on this repo. Configure here. |
6814f93 to
e2f7d54
Compare
b6c95ee to
ea9ce6d
Compare
e2f7d54 to
a445f0a
Compare
ea9ce6d to
2a6d5ad
Compare
Yoni-Starkware
left a comment
There was a problem hiding this comment.
Why?
@Yoni-Starkware made 1 comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on noaov1).
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
When I originally added this warns,
We used it only for the transaction prover, which allows only inoke v3 txs.
But now we are going to get those warnings for almost every state read in every other tx in the replay
@AvivYossef-starkware made 1 comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on noaov1).
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on noaov1).
2a6d5ad to
99d4007
Compare
a445f0a to
18a5758
Compare
18a5758 to
a99950d
Compare
99d4007 to
6cf404a
Compare
…Reader SimulatedStateReader is now used in the reexecution flow where non-invoke-V3 transactions (L1 handlers, declares, deploy accounts) are expected. Cache misses for these transaction types are normal behavior, not warnings.
6cf404a to
2086d68
Compare

SimulatedStateReader is now used in the reexecution flow where
non-invoke-V3 transactions (L1 handlers, declares, deploy accounts)
are expected. Cache misses for these transaction types are normal
behavior, not warnings.