Skip to content

blockifier_reexecution: remove fallback warn logs from SimulatedStateReader#13737

Merged
AvivYossef-starkware merged 1 commit intomain-v0.14.2from
aviv/reexecution-remove-prefetch-warns
Apr 15, 2026
Merged

blockifier_reexecution: remove fallback warn logs from SimulatedStateReader#13737
AvivYossef-starkware merged 1 commit intomain-v0.14.2from
aviv/reexecution-remove-prefetch-warns

Conversation

@AvivYossef-starkware
Copy link
Copy Markdown
Contributor

SimulatedStateReader is now used in the reexecution flow where
non-invoke-V3 transactions (L1 handlers, declares, deploy accounts)
are expected. Cache misses for these transaction types are normal
behavior, not warnings.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 13, 2026

PR Summary

Low Risk
Low risk: this is a logging-only change that stops emitting warn! on prefetched-state cache misses while preserving the existing RPC fallback behavior.

Overview
Removes warn! logging in SimulatedStateReader when prefetched StateMaps miss on storage/nonce/class-hash/declared-contract lookups, and now silently falls back to the inner RpcStateReader for those reads.

This reduces log noise in reexecution flows where cache misses are expected (e.g., for non-invoke-v3 transaction types) without changing read behavior.

Reviewed by Cursor Bugbot for commit 2086d68. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@Yoni-Starkware made 1 comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on noaov1).

Copy link
Copy Markdown
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I originally added this warns,
We used it only for the transaction prover, which allows only inoke v3 txs.
But now we are going to get those warnings for almost every state read in every other tx in the replay

@AvivYossef-starkware made 1 comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on noaov1).

Copy link
Copy Markdown
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on noaov1).

@graphite-app graphite-app Bot changed the base branch from aviv/reexecution-prefetch-cli to graphite-base/13737 April 14, 2026 17:42
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/reexecution-remove-prefetch-warns branch from 2a6d5ad to 99d4007 Compare April 14, 2026 18:45
@AvivYossef-starkware AvivYossef-starkware changed the base branch from graphite-base/13737 to aviv/reexecution-prefetch-cli April 14, 2026 18:45
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/reexecution-prefetch-cli branch from 18a5758 to a99950d Compare April 15, 2026 12:22
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/reexecution-remove-prefetch-warns branch from 99d4007 to 6cf404a Compare April 15, 2026 12:22
@AvivYossef-starkware AvivYossef-starkware changed the base branch from aviv/reexecution-prefetch-cli to main-v0.14.2 April 15, 2026 15:42
…Reader

SimulatedStateReader is now used in the reexecution flow where
non-invoke-V3 transactions (L1 handlers, declares, deploy accounts)
are expected. Cache misses for these transaction types are normal
behavior, not warnings.
Merged via the queue into main-v0.14.2 with commit c74cb16 Apr 15, 2026
22 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants