blockifier_reexecution: add PrefetchedStateReader and move from starknet_transaction_prover#13654
Conversation
835ad9b to
76f6139
Compare
76f6139 to
5b6e2a8
Compare
f70ab5a to
ea58a4d
Compare
e10ac13 to
528037f
Compare
528037f to
a1ace29
Compare
PR SummaryMedium Risk Overview Updates Reviewed by Cursor Bugbot for commit 411b881. Bugbot is set up for automated code reviews on this repo. Configure here. |
…m starknet_transaction_prover
a1ace29 to
411b881
Compare
einat-starkware
left a comment
There was a problem hiding this comment.
@einat-starkware reviewed 9 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on noaov1 and Yoni-Starkware).

Move the prefetched state reader and initial_reads deserialization utilities
from starknet_transaction_prover into blockifier_reexecution so both crates
share a single implementation. starknet_transaction_prover now imports
PrefetchedStateReader and deserialize_rpc_initial_reads from
blockifier_reexecution, and the local serde_utils module + SimulatedStateReader
are deleted.
Made-with: Cursor
Note
Medium Risk
Moves and rewires simulate-based state prefetch used during transaction execution/proving; mistakes could cause extra RPC fallbacks or incorrect cached reads in a critical execution path. Scope is contained but touches state-reading and RPC integration.
Overview
Centralizes simulate-based state prefetch in
blockifier_reexecutionby introducingprefetched_state_reader(SimulatedStateReader,simulate_and_get_initial_reads, andinitial_readsdeserialization) and adding a dedicatedPrefetchStateerror variant.starknet_transaction_provernow imports and uses this shared implementation forprefetch_stateexecution, and deletes its localserde_utils, duplicatedSimulatedStateReader, and the old simulate/prefetch unit test (replaced with a new mock-based test inblockifier_reexecution).Reviewed by Cursor Bugbot for commit 528037f. Bugbot is set up for automated code reviews on this repo. Configure here.