Skip to content

blockifier_reexecution,starknet_transaction_prover: support DeployAccount V3 in simulate prefetch#13778

Open
AvivYossef-starkware wants to merge 1 commit intomain-v0.14.2from
aviv/reexecution-prefetch-deploy-account-v3
Open

blockifier_reexecution,starknet_transaction_prover: support DeployAccount V3 in simulate prefetch#13778
AvivYossef-starkware wants to merge 1 commit intomain-v0.14.2from
aviv/reexecution-prefetch-deploy-account-v3

Conversation

@AvivYossef-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@AvivYossef-starkware AvivYossef-starkware marked this pull request as ready for review April 15, 2026 16:51
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 15, 2026

PR Summary

Low Risk
Changes are limited to optional RPC prefetch construction and type wiring; correctness impact is mitigated by existing fallback-to-RPC behavior when prefetching is skipped or fails.

Overview
State prefetching via starknet_simulateTransactions now accepts full Transaction values and includes DeployAccount V3 alongside Invoke V3 when building the simulation request.

Unsupported transaction types (Declare/L1Handler/Deploy and pre-V3 variants) are now silently skipped (returning empty StateMaps if nothing is simulatable), letting execution fall back to per-key RPC reads instead of failing prefetch.

VirtualBlockExecutor adapts its invoke-only tx list to the new API, and tests were updated to wrap invoke txs in Transaction::Invoke.

Reviewed by Cursor Bugbot for commit 082ba0f. Bugbot is set up for automated code reviews on this repo. Configure here.

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/reexecution-prefetch-deploy-account-v3 branch from 729af1b to 2115848 Compare April 16, 2026 08:10
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/reexecution-prefetch-fallback branch from 408650d to 1f187b0 Compare April 16, 2026 08:10
@AvivYossef-starkware AvivYossef-starkware changed the base branch from aviv/reexecution-prefetch-fallback to main-v0.14.2 April 20, 2026 08:33
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/reexecution-prefetch-deploy-account-v3 branch from 2115848 to 082ba0f Compare April 20, 2026 08:35
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Apr 20, 2026

Merge activity

  • Apr 20, 8:35 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants