Skip to content

blockifier_reexecution,starknet_transaction_prover: parameterize skip_fee_charge in prefetch#13738

Merged
AvivYossef-starkware merged 1 commit intomain-v0.14.2from
aviv/reexecution-skip-fee-charge-param
Apr 20, 2026
Merged

blockifier_reexecution,starknet_transaction_prover: parameterize skip_fee_charge in prefetch#13738
AvivYossef-starkware merged 1 commit intomain-v0.14.2from
aviv/reexecution-skip-fee-charge-param

Conversation

@AvivYossef-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 13, 2026

PR Summary

Medium Risk
Changes the simulation flags used for state prefetching, which can alter cache hit rates and which state keys are prefetched, potentially impacting performance or causing more RPC fallbacks if misconfigured.

Overview
Adds a skip_fee_charge parameter to simulate_and_get_initial_reads and plumbs it through SimulatedStateReader::from_rpc_state_reader, making inclusion of the SKIP_FEE_CHARGE simulation flag configurable instead of always enabled.

Updates call sites to use different defaults by context: block reexecution keeps fee charging enabled during prefetch (skip_fee_charge = false) to better match real blocks, while virtual block execution disables fee charging (skip_fee_charge = true) since transactions may not pay fees; tests are updated for the new function signature.

Reviewed by Cursor Bugbot for commit b4e1482. Bugbot is set up for automated code reviews on this repo. Configure here.

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/reexecution-remove-prefetch-warns branch from b6c95ee to ea9ce6d Compare April 13, 2026 12:46
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/reexecution-skip-fee-charge-param branch from b951913 to c60012e Compare April 13, 2026 12:46
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/reexecution-skip-fee-charge-param branch from c60012e to 710f918 Compare April 14, 2026 11:32
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/reexecution-remove-prefetch-warns branch from ea9ce6d to 2a6d5ad Compare April 14, 2026 11:32
@AvivYossef-starkware AvivYossef-starkware changed the title blockifier_reexecution,starknet_transaction_prover: make skip_fee_charge a parameter of simulate_and_get_initial_reads blockifier_reexecution,starknet_transaction_prover: parameterize skip_fee_charge in prefetch Apr 14, 2026
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/reexecution-skip-fee-charge-param branch from 710f918 to cf57e7f Compare April 14, 2026 18:45
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/reexecution-remove-prefetch-warns branch from 2a6d5ad to 99d4007 Compare April 14, 2026 18:45
Copy link
Copy Markdown
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on noaov1).

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/reexecution-skip-fee-charge-param branch from cf57e7f to de3ba72 Compare April 15, 2026 12:22
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/reexecution-remove-prefetch-warns branch from 99d4007 to 6cf404a Compare April 15, 2026 12:22
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/reexecution-skip-fee-charge-param branch from de3ba72 to 910c0f2 Compare April 15, 2026 16:45
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/reexecution-remove-prefetch-warns branch from 6cf404a to 2086d68 Compare April 15, 2026 16:45
@AvivYossef-starkware AvivYossef-starkware changed the base branch from aviv/reexecution-remove-prefetch-warns to main-v0.14.2 April 15, 2026 17:29
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/reexecution-skip-fee-charge-param branch from 910c0f2 to b4e1482 Compare April 16, 2026 08:10
Copy link
Copy Markdown
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AvivYossef-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on noaov1).

Copy link
Copy Markdown
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoni-Starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on noaov1).

@AvivYossef-starkware AvivYossef-starkware added this pull request to the merge queue Apr 20, 2026
Merged via the queue into main-v0.14.2 with commit 50a6515 Apr 20, 2026
36 of 48 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants