Skip to content

blockifier_reexecution: wire prefetch_initial_reads into replay CLI#13712

Merged
AvivYossef-starkware merged 1 commit intomain-v0.14.2from
aviv/reexecution-prefetch-cli
Apr 15, 2026
Merged

blockifier_reexecution: wire prefetch_initial_reads into replay CLI#13712
AvivYossef-starkware merged 1 commit intomain-v0.14.2from
aviv/reexecution-prefetch-cli

Conversation

@AvivYossef-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 13, 2026

PR Summary

Medium Risk
Changes the default RPC replay execution path to optionally (and by default) prefetch initial reads via starknet_simulateTransactions, which may impact performance and compatibility with RPC nodes. Scope is limited to the replay tooling and wiring/plumbing rather than core execution logic.

Overview
Adds a new rpc-replay flag --prefetch-initial-reads (default true) and wires it through main/run_rpc_replay into ConsecutiveRpcStateReaders so replay workers can enable/disable simulate-based prefetching.

Updates Kubernetes job.yaml (via PREFETCH_INITIAL_READS env var) and replay docs/Claude runbook to surface the new toggle; offline dump mode explicitly forces prefetching off, and tests are updated for the new constructor parameter.

Reviewed by Cursor Bugbot for commit a99950d. Bugbot is set up for automated code reviews on this repo. Configure here.

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/reexecution-consecutive-prefetch branch from 83cfb63 to 8c4100f Compare April 13, 2026 12:46
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/reexecution-prefetch-cli branch from 6814f93 to e2f7d54 Compare April 13, 2026 12:46
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/reexecution-prefetch-cli branch from e2f7d54 to a445f0a Compare April 14, 2026 11:32
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/reexecution-consecutive-prefetch branch from 8c4100f to 42e8f70 Compare April 14, 2026 11:32
@graphite-app graphite-app Bot changed the base branch from aviv/reexecution-consecutive-prefetch to graphite-base/13712 April 14, 2026 12:33
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/reexecution-prefetch-cli branch from a445f0a to 59b5566 Compare April 14, 2026 17:42
@graphite-app graphite-app Bot changed the base branch from graphite-base/13712 to main-v0.14.2 April 14, 2026 17:43
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Apr 14, 2026

Merge activity

  • Apr 14, 5:43 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/reexecution-prefetch-cli branch from 59b5566 to 18a5758 Compare April 14, 2026 18:45
Copy link
Copy Markdown
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AvivYossef-starkware reviewed 1 file.
Reviewable status: 1 of 6 files reviewed, all discussions resolved (waiting on noaov1 and Yoni-Starkware).

Copy link
Copy Markdown
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoni-Starkware reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on AvivYossef-starkware and noaov1).


crates/blockifier_reexecution/src/rpc_replay.rs line 215 at r2 (raw file):

        contract_class_manager.clone(),
    );
    readers.prefetch_initial_reads = prefetch_initial_reads;

Pass through the constructor

Code quote:

    readers.prefetch_initial_reads = prefetch_initial_reads;

Copy link
Copy Markdown
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AvivYossef-starkware made 1 comment and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on noaov1).


crates/blockifier_reexecution/src/rpc_replay.rs line 215 at r2 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Pass through the constructor

Done

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/reexecution-prefetch-cli branch from 18a5758 to a99950d Compare April 15, 2026 12:22
Copy link
Copy Markdown
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on noaov1).

@AvivYossef-starkware AvivYossef-starkware added this pull request to the merge queue Apr 15, 2026
Merged via the queue into main-v0.14.2 with commit 2fa1b7b Apr 15, 2026
22 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants