Repository navigation
π Reviewer-stated rules: ignore quotes and questions, match more future phrasings, and give the preferences a Settings card - #19143
Conversation
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
a5308df to
5750061
Compare
UI render evidenceRender evidence captured. Built from
These are fixture renders, not live data: the page was built from the PR head and filled with synthetic data from |
There was a problem hiding this comment.
Correctness: no in-scope blocker found at 5750061. Two low out-of-scope notes, which don't block this PR:
src/cmd/hive/review_feedback_wire.go:258: the debounce usesCreatedAtandEvaluatedis keyed by comment id, so a comment edited into a rule after it was first classified is never re-read.src/cmd/hive/review_feedback_wire.go:268: refused comments (rule limit reached) are retried and warn on every sweep pass.
-- hive: agent=adjudicator backend=claude model=claude-sonnet-5-5 claude=2.1.327
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Review follow-ups: 3 open of 3 (below
|
β¦re phrasings, and give the preferences a Settings card The rule classifier read the whole comment, so a reply that quotes the hive and asks whether the hive can add something to the knowledge base would be recorded as the reviewer's rule with the hive's words as its text. Block quotes, fenced code and questions no longer count, a short rule sentence that refers back keeps the rest of the comment, and going-forward also matches future assessments, moving forward and for the future. Which phrases count and whose rules are recorded at once are the owner's preferences: review_feedback.rules.enabled, trusted_associations, extra_phrases and disabled_signals in hive.yaml, with the env vars still honoured and a saved value winning. An owner-only Settings card under Features, Review edits them in place, validated, audited as config_review_feedback_rules, and applied on the sweep's next pass. The candidate set and evaluated-id backfill this issue also asked for landed in #19146. Fixes #19135 Signed-off-by: Andy Anderson <andy@clubanderson.com>
ee59ad0 to
8b397ba
Compare
|
hive/scanner: this PR has merge conflicts with v5 (mergeable_state=dirty). It is not a hive-authored branch, so I am not pushing to it; please rebase onto origin/v5 and force-push, and the sweep will pick it up once CI is green. π Hive Agent: |
|
Merge blocked: this PR now has merge conflicts with the base branch. Please rebase or merge the base in (signed off); it was otherwise CI-green and approved. π Hive Agent: |
Resolve conflicts with #19144: keep the Classifier/sentence-based quote and question handling from this branch, take v5 doc line numbers, and keep the review-feedback/rules API rows. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
There was a problem hiding this comment.
CI is red on this head for a docs reason, and the fix is mechanical. I did not trace the classifier logic in pkg/reviewrules in depth, so this is not a correctness sign-off.
api-reference citations drifted (changelog-fragment-guard, relative links and anchors resolve). The PR adds /api/config/review-feedback/rules and edits dashboard/openapi.json plus route-registering and static page files, so the guard reports: "api-reference citations must be resynced". Run bash src/scripts/check-api-reference-citations.sh --fix and commit the result. If static pages under src/pkg/dashboard/ changed, the same job asks for the matching baseline in src/pkg/dashboard/webstatic/style_ratchet_test.go (styleRatchetBaselines) to be lowered.
native-queue-policy is also failing on exact-head evidence ("Admission blocked"); I did not read the provider verdict it names, so that one needs the author's eye.
The conflicts-with-open-pr label is set; I did not compare it against the other PR.
-- hive: agent=reviewer-2 backend=claude model=claude-sonnet-5-5 claude=2.1.327
β¦le is too short to stand alone Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
There was a problem hiding this comment.
Correctness review at head 56fb518: no blockers. The classifier now ignores quotes, fenced code and questions, and short back-referring rule sentences keep the surrounding comment. Settings merge over env as documented, SetConfig and CaptureComment take the store lock, and the owner-only API validates input and rolls back when the save fails. One low edge case is on the line comment (hard-wrapped questions). I did not run the tests.
-- hive: agent=ci-maintainer backend=claude model=claude-sonnet-5-5 claude=2.1.327
| @@ -85,45 +199,69 @@ var metaClause = regexp.MustCompile(`(?i)^\s*(?:please\s+|and\s+)?(?:capture|rec | |||
|
|
|||
| var sentenceSplit = regexp.MustCompile(`[.!?]+\s+|\n+`) | |||
There was a problem hiding this comment.
Low: every newline is a sentence boundary here, and a sentence is a question only if it ends in '?' (line 256). A hard-wrapped question such as "Could we document this\nin future?" leaves its first line as a non-question that matches capture-request, so it is recorded as a rule. An optional fix is to join single newlines within a paragraph before splitting, keeping blank lines, list items and headings as boundaries.
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Andy Anderson <andy@clubanderson.com> # Conflicts: # src/docs/api-reference/auth.md
Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
New changes are detected. LGTM label has been removed. |
Fixes #19135
A maintainer asked that rules reviewers state on the hive's assessment PRs ("X is the source of truth", "we should consider this in future") land in the hive's knowledge base. Thanks to @nate-double-u for the request and the concrete example on cncf/techdocs#424. #19086 and #19095 added the capture; this PR fixes why that example would never be captured once deployed, and gives the preferences a Settings home.
What changes
The capture half of #19135 (every human comment is a rule candidate, an evaluated-id index separate from the sweep's handled ids, one-time backfill) landed in #19146 while this PR was in CI; this PR is rebased on it and keeps the rest.
>), fenced code and questions never count, so a comment that quotes the hive and asks "is there a way to add to the knowledge-base?" is not recorded as the reviewer's rule (with β¨ Review-rule capture reads its own candidate setΒ #19146 such plain PR comments are now candidates, so this matters). A short rule sentence that refers back ("we should consider this in future") keeps the rest of the comment.going-forwardalso matches "future assessments", "moving forward" and "for the future".review_feedback.rules.enabled,trusted_associations,extra_phrasesanddisabled_signalsin hive.yaml (the env vars still work; a saved value wins). Owner-onlyGET/PUT /api/config/review-feedback/rules, validated, audited asconfig_review_feedback_rules, applied on the sweep's next pass without a restart (Store.SetConfig). The card sits under Settings, Features, Review, with a one-line explanation, the default, and where each current value comes from. Defaults are unchanged:OWNER,MEMBER,COLLABORATOR, all built-in signals, no extra phrases. The vocabulary reaches the dashboard throughpkg/config, sopkg/dashboardgains no import.Beads
The issue compares the beads ledger with the
review-ruleschannel. Beads do not reach the authoring agent's next kick directly, have no per-scope pinning, provenance or retraction semantics, so this PR keeps the channel and adds no beads path.Tests
pkg/reviewrules: future-looking phrasings, quotes, code and questions, the real inline comment from Add draft documentation analysis for Hive Commons (pilot)Β cncf/techdocs#424, extra phrases and disabled signals, phrase validation, live config change, env parsing.cmd/hive: a conversation comment that quotes the hive and asks is not captured while one stating a rule is; settings win over env; capture off yields no store.pkg/configandpkg/dashboard: round trip, owner-only, validation, audit, clear.π€ Generated with Claude Code