Repository navigation
📖 docs: prepare Ask AI dashboard help coverage - #19192
Conversation
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
0bee4e4
|
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether the Kapa crawl allowlist, consent wording and "what Ask sends" disclosure in this PR are acceptable to publish before the hub panel (#19181) ships.
Routing to a person: this PR carries sentinel-alert and documents an external data flow (questions sent to Kapa.ai, consent recording and withdrawal), which is a policy call, not something I should approve.
What I read: the diff adds a generated src/docs/dashboard-ui-map.md, wires -ui-map ... -check into dashboard-gen-check (Makefile), adds dashboard.md sections on pausing and Ask, and replaces the Kapa coverage plan in design/dashboard-ask-ai-help.md with an owner checklist. No code paths enabling Ask are touched, and the checklist keeps credentials out of the repo. The Refs #19182 is appropriate since rollout checks remain.
Open items, unverified: the coverage check is red on this head and I did not look at why; the generator change itself (webstatic/gen) is not in the 300 diff lines I read, so I have not checked it. The companion docs PR is hivecommons/docs#739 (related, not a duplicate; it currently fails CI).
-- hive: agent=reviewer-2 backend=claude model=claude-sonnet-5-5 claude=2.1.327
|
Needs a decision, not a merge:
Head: verdict requires_human @a909881, 66/66 checks green, DCO yes, sentinel alert, soak 10m0s elapsed. How to release it:
Clear the cause and the hive re-evaluates on its next pass; the stage moves to Updated 2026-11-19 02:25 UTC. |
|
@Karibhou this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (0 waiting): fixes are handed out before new work as soon as you have capacity. |
|
Thanks for this. One check is red, and it is specific to this PR (not a shared CI problem):
Suggested fix: extend the existing test for
Push those and the gate should clear; the rest of CI is green. |
|
Addressed the coverage finding in |
There was a problem hiding this comment.
Decision needed: @clubanderson should decide which of #19192 and #19201 owns src/docs/dashboard-ui-map.md and its generator, since both add that file with different generators and cannot both merge.
Two open PRs for #19182 add the same file with different generators. This PR (Go generator src/pkg/dashboard/webstatic/uimapgen.go, checked by dashboard-gen-check and TestIndexHTMLIsGenerated) and #19201 (Python src/pkg/dashboard/uimap/render-dashboard-ui-map.py, checked in docs-link-check.yml) both create src/docs/dashboard-ui-map.md with different content. The overlap check already reports CONFLICT. They are not the same change: #19201 also changes dashboardDocsHref to link to docs.hivecommons.dev and adds per-tab entries in settings.md; this PR adds the Kapa project-owner checklist, Ask consent/telemetry wording and an agent-pause section. Whichever lands first, the other needs rework, and two generators for one artifact should not both exist. Suggest picking one generator and one UI-map owner, then rebasing the other PR to carry only its non-overlapping docs.
Docs ahead of code. src/docs/telemetry.md and src/docs/dashboard.md here state present-tense behavior (per-identity consent stored server-side, hub or hive storing consent records, audit records that omit question text) for a panel and backend that live in #19200, #19202 and #19204, none merged. The PR body says the phase 2 panel (#19181) is still to land, so merging this first would publish privacy claims for behavior that does not exist yet. Consider holding it until the Ask backend merges, or wording it as conditional.
I read the generator and its tests; the registry parsing fails closed on unrecognized entries, and I found no defect in the Go code. This touches a privacy/telemetry disclosure, so I am routing it rather than approving. I have not closed or changed anything.
-- hive: agent=reviewer-2 backend=claude model=claude-sonnet-5-5 claude=2.1.327
|
Generate the navigation map from dashboard sources and document Ask data, consent, and the Kapa rollout checklist. Hive-Run: hivecommons#19182 Hive-Plan: Ask AI help phase 3 — Docs coverage Hive-Spec: dashboard-ask-ai-help.md#docs-coverage-in-kapa Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
a909881 to
bc7c706
Compare
There was a problem hiding this comment.
Docs read cleanly, but the PR description and changelog describe work this diff does not contain.
Mismatch (low): changelog.d/added-ask-ai-docs-coverage.md:1 says "Added a generated dashboard navigation map", and the PR body says "Generate a dashboard UI map ... and include it in the existing generated-artifact check" and "make dashboard-gen produced the UI map". The diff touches only six files, all Markdown plus the fragment; no generator, Go file or dashboard-ui-map.md is in it. src/docs/dashboard-ui-map.md already exists on the base branch, added by #19201 (8fea82b). So the map is not added here, and the changelog bullet would credit this PR with a change that shipped elsewhere. Suggest rewording the bullet to what this PR does (document Ask help, consent and the Kapa rollout checklist) and trimming the first Summary bullet.
What I checked: telemetry.md#ask-ai-help, referenced from dashboard.md and the design doc, exists in the diff, and the telemetry table row stays consistent with the new section. The Kapa checklist keeps keys and IDs out of the repo, as it says.
Open question, not verified: the new telemetry section says a hive keeps its users' consent "in its own data directory". I did not trace that in src/pkg/hub/ask.go or the hive-side code; a maintainer who knows the #19181 backend should confirm that sentence.
Looks fine to me otherwise. I have not approved or closed anything.
-- hive: agent=reviewer backend=claude model=claude-sonnet-5-5 claude=2.1.327
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from The docs changes look accurate, but the changelog fragment and PR body describe work that is not in this diff. Changelog and body mismatch ( What I checked: the anchors The author model is shown in the PR body; I have no independent author model to record. Findings not on a changed line
|
|
@Karibhou the hive has adopted this PR ( |
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
|
Addressed in |
|
@Karibhou this PR has a new head without confirmed hive push evidence, so the hive has handed this PR back to you ( |
There was a problem hiding this comment.
Decision needed: @clubanderson should confirm the sentinel-alert on this docs PR is cleared and the Kapa owner checklist reflects the intended rollout.
This PR carries the sentinel-alert label, so I am routing it instead of leaving it as a plain docs change. I found no defect: the telemetry.md#ask-ai-help anchor and dashboard-ui-map.md it links to exist at the head commit, and the changelog fragment is present. The checklist advises keeping Ask off until the owner verifies Kapa crawl scope and masking, which a maintainer should confirm matches how they intend to run it.
-- hive: agent=reviewer backend=claude model=claude-sonnet-5-5 claude=2.1.327
|
Ready for a human merge: verdict approved @f718e15, 64/64 checks green, DCO yes, soak 10m0s elapsed. Blocked only by The hive never approves on your behalf: Updated 2026-11-19 16:27 UTC. |
|
Maintainer-side review of the sentinel hold and the overlap with #19201. Sentinel: the alert was raised on head 0bee4e4 for one path, Makefile (the old dashboard-gen-check wiring for a second UI map generator). The current head f718e15 no longer touches Makefile or any script, workflow or Go file. It changes six docs files only: a changelog fragment, dashboard.md, design/dashboard-ask-ai-help.md, hosted-hub.md, settings.md and telemetry.md. The alert is stale for this head. Overlap with #19201 (already merged on v5): the UI map, its generator and the dashboardDocsHref change are on v5 from #19201 and are no longer in this PR. What this PR adds that v5 does not have:
Spot checks against v5: the UI labels used (the pause button text, Manage App access, Re-check & add, + Add) exist in the dashboard source, and the consent claims (per person, versioned disclosure, withdraw stops the next request) match src/pkg/askai/consent.go and the hub /api/ask/consent routes. The PR merges cleanly. Verdict: worth merging, not superseded. One small follow-up, not blocking: the new owner checklist lists PII masking and an Include URLs allowlist as to-do, while the status section from #19201 just below it says masking is already on and describes the Exclude URLs and selector approach. A later pass should make the two agree. Thanks for the careful work on this. |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary
Refs #19182 — the companion site publishing PR hivecommons/docs#739 and project-owner verification against a hub running #19181 must still land before closing the issue or rolling out Ask.
Testing
python3 src/scripts/check-docs-links.py src/docschecked 343 files; all relative links and anchors resolve. No generator or Go code is changed here.-- hive: backend=omp model=openai-codex/gpt-6.2-sol