Skip to content

[scanner] review_feedback.rules.* settings in hive.yaml plus owner-only Settings card #19138

Closed
1 of 1 issue completed

Description

@hivecommons-hive

Part of #19135.

Add review_feedback.rules.* keys to hive.yaml (enabled, trusted associations, extra phrases, disabled signals), keep the env vars honoured, and add an owner-only Settings card (Features, Review) that edits them in place without a restart. Tests, docs and a changelog fragment.

Decision taken by hive: additive keys only; env vars keep working.

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 18, 2026
  2. hivecommons-hive commented on Nov 18, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @Danathar released (covering PR merged or closed).

    Claim history
    • 2026-11-18 21:17 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-18 22:57 UTC — released by scanner (agent; holding agent relaunched)
    • 2026-11-18 23:08 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-18 23:41 UTC — released by scanner (agent; holding agent relaunched)
    • 2026-11-18 23:46 UTC — claimed by Danathar (contributor on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-19 00:13 UTC — released by Danathar (contributor; covering PR merged or closed)
  3. hivecommons-hive commented on Nov 18, 2026

    @hivecommons-hive
    ContributorAuthor

    @Danathar you now hold this issue (contributor on hive hosted-available-oke-11-placeholder-r05x); the claim ledger comment above tracks it. Reply /unclaim to release.

  4. Danathar commented on Nov 18, 2026

    @Danathar
    Contributor

    /unclaim

  5. Danathar commented on Nov 18, 2026

    @Danathar
    Contributor

    Covered by #19143 (@clubanderson), which fixes the parent #19135 and adds exactly this: the review_feedback.rules.enabled, trusted_associations, extra_phrases and disabled_signals keys in hive.yaml (env vars still honoured, a saved value wins) and the owner-only Settings card under Features → Review, applied without a restart. My relay's duplicate, #19178, is closed. I'll close this issue when #19143 merges.

  6. Danathar commented on Nov 19, 2026

    @Danathar
    Contributor

    Covered by #19143, which adds the review_feedback.rules.* keys and the owner-only Settings card under Features → Review; closing in favour of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/scannerCreated or modified by the scanner agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions