Repository navigation
✨ Review-rule capture reads its own candidate set - #19146
Conversation
Rule capture only saw the routed burst, so a rule stated in a comment that was already handled, sat in a resolved or answered thread, or was a plain PR comment not addressed to the hive was never classified. Capture now reads every human comment on the PR (RuleCandidates), and the rule index keeps its own evaluated comment ids, separate from the sweep's handled ids, so the first pass is a one-time backfill and later passes read only new comments. Kick routing is unchanged; the brief looks up rules by comment id. Closes #19136 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Mutation testinggremlins found 3 surviving mutant(s) in changed files: the code ran under tests, but changing it did not fail any test.
ℹ️ 4 mutant(s) on added lines were SKIPPED because gremlins v0.6.0 only honours the first
Verdict: |
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Review follow-ups: 2 open of 2 (below
|
There was a problem hiding this comment.
Style review at head 9593332: no blockers. The diff is consistent with repo idioms, and the docs, changelog and tests are updated.
Advisory: src/cmd/hive/review_feedback_wire.go:126 calls postRuleNotices, and captureRules ends with another postRuleNotices call, so it runs twice per pass. The first call looks redundant.
-- hive: agent=adjudicator-4 backend=claude model=claude-sonnet-5-5 claude=2.1.327
…re phrasings, and give the preferences a Settings card The rule classifier read the whole comment, so a reply that quotes the hive and asks whether the hive can add something to the knowledge base would be recorded as the reviewer's rule with the hive's words as its text. Block quotes, fenced code and questions no longer count, a short rule sentence that refers back keeps the rest of the comment, and going-forward also matches future assessments, moving forward and for the future. Which phrases count and whose rules are recorded at once are the owner's preferences: review_feedback.rules.enabled, trusted_associations, extra_phrases and disabled_signals in hive.yaml, with the env vars still honoured and a saved value winning. An owner-only Settings card under Features, Review edits them in place, validated, audited as config_review_feedback_rules, and applied on the sweep's next pass. The candidate set and evaluated-id backfill this issue also asked for landed in #19146. Fixes #19135 Signed-off-by: Andy Anderson <andy@clubanderson.com>
…re phrasings, and give the preferences a Settings card (#19143) * 🐛 Reviewer-stated rules: ignore quotes and questions, match more future phrasings, and give the preferences a Settings card The rule classifier read the whole comment, so a reply that quotes the hive and asks whether the hive can add something to the knowledge base would be recorded as the reviewer's rule with the hive's words as its text. Block quotes, fenced code and questions no longer count, a short rule sentence that refers back keeps the rest of the comment, and going-forward also matches future assessments, moving forward and for the future. Which phrases count and whose rules are recorded at once are the owner's preferences: review_feedback.rules.enabled, trusted_associations, extra_phrases and disabled_signals in hive.yaml, with the env vars still honoured and a saved value winning. An owner-only Settings card under Features, Review edits them in place, validated, audited as config_review_feedback_rules, and applied on the sweep's next pass. The candidate set and evaluated-id backfill this issue also asked for landed in #19146. Fixes #19135 Signed-off-by: Andy Anderson <andy@clubanderson.com> * 🐛 Reviewer-stated rules: keep the whole comment when the extracted rule is too short to stand alone Signed-off-by: Andy Anderson <andy@clubanderson.com> * 📖 docs: refresh api-reference citations after merging v5 Signed-off-by: Andy Anderson <andy@clubanderson.com> * 📖 docs: refresh api-reference citations after merging v5 Signed-off-by: Andy Anderson <andy@clubanderson.com> --------- Signed-off-by: Andy Anderson <andy@clubanderson.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
A reviewer-stated rule was only classified while its comment was still unanswered feedback, so a rule in a comment the agent already handled, in a resolved or answered thread, or in a plain PR comment not addressed to the hive never reached the hive's knowledge (the maintainers.yaml comment on cncf/techdocs#424 is one). Capture now reads every human comment on the hive's open PRs, and the rule index keeps its own evaluated comment ids, separate from the sweep's handled ids, so the first pass after deploy is a one-time backfill and later passes classify only new comments. Kick routing is unchanged; the brief looks up captured rules by comment id. Classifier phrasing (#19137) and settings keys (#19138) are left to their own PRs.
Closes #19136
🤖 Generated with Claude Code
-- hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.327