Repository navigation
Conversation
…ngs card
Add review_feedback.rules.{enabled,trusted_associations,extra_phrases,
disabled_signals} to hive.yaml and an owner-only "Rules from review
feedback" card in Settings, Features, Review that edits them in place.
The sweep resolves the policy from hive.yaml on every pass and hands it to
the open rule store, so an edit applies without a restart. The keys are
additive: HIVE_REVIEW_FEEDBACK_RULES and
HIVE_REVIEW_FEEDBACK_RULE_TRUSTED_ASSOCIATIONS keep working and win when
set, and the card and API report that. Extra phrases are quoted, never
patterns; disabled signals name the built-in classifier signals.
Tests for the config block, the policy and classifier, the live store, the
owner-only API and the card; docs and a changelog fragment.
Closes #19138
Hive-Run: #19138
Hive-Plan: #19135 review-rule capture fixes, settings step
Hive-Spec: review-feedback-rules#settings
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@Danathar this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
|
Closing as a duplicate of #19143 (@clubanderson, opened earlier against v5). Both add the |
Closes #19138
Part of #19135.
What
review_feedback.rules.*keys inhive.yaml:enabled,trusted_associations,extra_phrases,disabled_signals. Additive only; theHIVE_REVIEW_FEEDBACK_RULESandHIVE_REVIEW_FEEDBACK_RULE_TRUSTED_ASSOCIATIONSenvironment variables keep working and win when set.GET/PUT /api/config/review-feedback/rulesand a Rules from review feedback card in Settings, Features, Review. The card shows when an environment variable overrides a value, refuses to save an empty trusted set (which the server reads as "default"), and shows server validation errors verbatim.reviewrules.Policy/Resolvemerge yaml and env.ClassifyWithandExtractRuleTextWithhonour extra phrases (a newextra-phrasesignal, quoted so they are never patterns) and disabled built-in signals.Store.SetPolicyapplies a change to the open store, and the sweep re-readshive.yamlon every pass, so an edit takes effect on the next pass without a restart.config.NormalizeReviewFeedbackRules): known associations and signals only, phrases 4 to 100 characters, at most 50.review-feedback-rules.md,settings.md, operator reference, API reference), a changelog fragment, and regeneratedstatic/index.html.Behaviour notes
enabled: falsein yaml stops capture only; rules already recorded keep loading into kicks until retracted.HIVE_REVIEW_FEEDBACK_RULES=offkeeps its old, stronger effect (the channel is also left out of the primer), so turning capture back on from the card needs no restart.registerReviewFeedbackRulesRoutesat the end ofRegisterAPI, so no existingapi.go:NNNcitation shifts.Testing
Per AGENTS.md the Go suite was not run locally; CI is the verdict. Locally:
gofmt,go veton the touched packages, the docs and API-reference citation guards, the static-index generator check, andnode --test pkg/dashboard/review_feedback_rules_editor.test.js(6 passing).-- hive: backend=claude model=claude-sonnet-5-5
🤖 Generated with Claude Code
🐝 Hive Agent:
contributor| SHA:06121ce4d