Repository navigation
✨ Close tracker and umbrella issues whose referenced work is done (opt-in) - #19151
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. hive/awaiting-ci: rebased onto v5 and pushed; CI pending - sweep will merge when green. 🐝 Hive Agent: merged by Hive trusted-author auto-merge: author |
…t-in trackers_too) Adds repos.<repo>.parent_autoclose: trackers_too, which implies epics_too and also closes tracker or umbrella issues with no sub-issue children once every issue and PR they reference is finished. Done is computed from state (task list items, a close_when checklist, PRs that reference the tracker), never from close keywords. Off by default; hive/tracking and hold issues never close, a person's reopen is final, and the close needs the same evidence on two reads and leaves an evidence comment. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
…composed-parent close Signed-off-by: Andrew Anderson <andy@clubanderson.com>
9ae0e96 to
00534d1
Compare
Fixes #19071
Adds an opt-in per-repo policy,
repos.<repo>.parent_autoclose: trackers_too, that closes tracker and umbrella issues which have no sub-issue children once everything they reference is finished. Off by default; every other value behaves exactly as before.What counts as done (v5 merges never auto-close, so this is computed from state, never from close keywords):
close_whenchecklist in the tracker body, when present, is the whole set: every item ticked or, for an item naming an issue or PR, closed.Refs, a closing keyword orPart of. Done means the set is non-empty, every PR in it is merged or closed and every issue in it is closed.Which issues are read: only ones that announce themselves as trackers (the shared umbrella classifier from hub.contribute_umbrella, an
auditorroadmaplabel, or aclose_whenchecklist). A design or feature issue that merely hasRefsPRs is never a candidate, becauseRefsis partial work by definition.Safety:
hive/trackingissues (label, marker, "Keep this issue open") never close, andhold-labelled issues never close even thoughtrackers_tooimpliesepics_too.Also: the Settings card gets a fourth option, "Also close trackers whose work is done" (served from the options list the PUT validates against), plus docs, OpenAPI, notification write-site inventory and changelog fragment. Tests cover: all done closes with an evidence comment, one open reference keeps it open,
hive/trackingand hold never close, reopened never re-closes, an empty reference set never closes, non-trackers withRefsPRs are not candidates,close_whenreplaces the inferred set, and the default andepics_toopolicies never close trackers.Not included: closing done-but-open issues in
stage/040-covered-by-prwhen the covering PR merges. That is a separate reconcile and can follow.No live hive config is changed.