Skip to content

✨ Close tracker and umbrella issues whose referenced work is done (opt-in) - #19151

Merged
hivecommons-hive[bot] merged 3 commits into
v5from
feat/tracker-autoclose
Nov 18, 2026
Merged

hivecommons-hive[bot] merged 3 commits into
v5from
feat/tracker-autoclose

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #19071

Adds an opt-in per-repo policy, repos.<repo>.parent_autoclose: trackers_too, that closes tracker and umbrella issues which have no sub-issue children once everything they reference is finished. Off by default; every other value behaves exactly as before.

What counts as done (v5 merges never auto-close, so this is computed from state, never from close keywords):

  • A close_when checklist in the tracker body, when present, is the whole set: every item ticked or, for an item naming an issue or PR, closed.
  • Otherwise the set is every task-list item that names an issue or PR plus every PR that references the tracker with Refs, a closing keyword or Part of. Done means the set is non-empty, every PR in it is merged or closed and every issue in it is closed.

Which issues are read: only ones that announce themselves as trackers (the shared umbrella classifier from hub.contribute_umbrella, an audit or roadmap label, or a close_when checklist). A design or feature issue that merely has Refs PRs is never a candidate, because Refs is partial work by definition.

Safety:

  • hive/tracking issues (label, marker, "Keep this issue open") never close, and hold-labelled issues never close even though trackers_too implies epics_too.
  • A tracker a person reopened after a hive auto-close is never closed again (same timeline check as decomposed parents).
  • An unreadable reference or timeline, or more than 50 references, means no close.
  • Reads are cached per tracker; the close needs the same finished evidence on two fresh reads 15 minutes apart.
  • An evidence comment listing every reference and its state is posted before the close and carries the parent-autoclose marker.

Also: the Settings card gets a fourth option, "Also close trackers whose work is done" (served from the options list the PUT validates against), plus docs, OpenAPI, notification write-site inventory and changelog fragment. Tests cover: all done closes with an evidence comment, one open reference keeps it open, hive/tracking and hold never close, reopened never re-closes, an empty reference set never closes, non-trackers with Refs PRs are not candidates, close_when replaces the inferred set, and the default and epics_too policies never close trackers.

Not included: closing done-but-open issues in stage/040-covered-by-pr when the covering PR merges. That is a separate reconcile and can follow.

No live hive config is changed.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 18, 2026
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#19143 🐛 Reviewer-stated rules: ignore quotes and questions, match more future phrasings, and give the preferences a Settings card same files dashboard/openapi.json
src/docs/api-reference/configuration.md
src/docs/settings.md

@hivecommons-hive

hivecommons-hive Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • test (rest 3/4)

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

hive/awaiting-ci: rebased onto v5 and pushed; CI pending - sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 0f56aad7e

Evidence bundle `#1915100534d1` sha256:ecc6dde97ef4c8a3021078d97c6e31b6bc78af1ff6f02413472a9eb69f78532d — download from the dashboard or `hivectl review evidence #19151`.

merged by Hive trusted-author auto-merge: author clubanderson holds role owner and GitHub permission admin on repo; CI green at 00534d1.

@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 18, 2026
@kubestellar-prow kubestellar-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 18, 2026
…t-in trackers_too)

Adds repos.<repo>.parent_autoclose: trackers_too, which implies epics_too and
also closes tracker or umbrella issues with no sub-issue children once every
issue and PR they reference is finished. Done is computed from state (task
list items, a close_when checklist, PRs that reference the tracker), never
from close keywords. Off by default; hive/tracking and hold issues never
close, a person's reopen is final, and the close needs the same evidence on
two reads and leaves an evidence comment.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
…composed-parent close

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@hivecommons-hive
hivecommons-hive Bot force-pushed the feat/tracker-autoclose branch from 9ae0e96 to 00534d1 Compare November 18, 2026 22:18
@kubestellar-prow kubestellar-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 18, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit ce90f9b into v5 Nov 18, 2026
94 of 95 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the feat/tracker-autoclose branch November 18, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🧹 Close tracker and umbrella issues whose referenced work is done

1 participant