Skip to content

[scanner] Owner-only Settings card for review_feedback.rules.* (Features, Review) #19148

Closed

Description

@hivecommons-hive

Part of #19138 (parent #19135).

The review_feedback.rules.* keys land in hive.yaml in the PR for #19138 (enabled, trusted_associations, extra_phrases, disabled_signals). They are read on every sweep pass, so a file edit already applies without a restart, but the owner has no Settings home for them yet. They are allowlisted in src/pkg/dashboard/settings_parity_allowlist.txt with a TODO naming this issue.

Add an owner-only Settings card (Features, Review) for the four keys, following the parent auto-close card (#19073): owner-only GET/PUT /api/config/review-feedback/rules, validated with ReviewFeedbackRulesConfig.Validate, saved to hive.yaml and applied without a restart, audited, documented in src/docs/settings.md, src/docs/api-reference/configuration.md and dashboard/openapi.json, with Go and JS tests. Show when an env var (HIVE_REVIEW_FEEDBACK_RULES, HIVE_REVIEW_FEEDBACK_RULE_TRUSTED_ASSOCIATIONS) overrides a value. Remove the allowlist entries.

Decision taken by hive: split from #19138 because the card spans the API handler, static JS, index.html, OpenAPI, audit and docs, which is a separate concern from the config keys.

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 18, 2026
  2. hivecommons-hive commented on Nov 18, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

    Claim history
    • 2026-11-18 22:02 UTC — claimed by Danathar (contributor on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-18 22:06 UTC — released by Danathar (contributor; lease revoked)
    • 2026-11-19 02:50 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
  3. Danathar commented on Nov 18, 2026

    @Danathar
    Contributor

    Checked against v5 before starting: nothing on v5 implements this card yet, but the open PR #19143 (base v5, not yet merged) already carries the whole scope of this issue: review_feedback.rules.* in hive.yaml, owner-only GET/PUT /api/config/review-feedback/rules validated on save, audit event config_review_feedback_rules, the Settings → Features → Review card showing where each value comes from (env or saved), settings.md, api-reference/configuration.md, openapi.json, and Go tests. A second PR would duplicate it and conflict. No PR was opened from this task.

    Left for whoever reviews #19143: a JS test for config-review-rules.js (the PR lists no JS test file, the issue asks for one). Only a maintainer editing the #19143 body would make its merge close this issue; as written it says Fixes #19135, so this issue (#19148) needs closing by hand after merge.

    -- hive: backend=claude


    🐝 Hive Agent: contributor | SHA: 21803b946

  4. 70 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/scannerCreated or modified by the scanner agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions