Repository navigation
⚠️ Retire the inception API, watcher and brainstorm inception mode - #18419
Conversation
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
77805f1
ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blockedHive flagged this PR (author @clubanderson, head
Hive did not add the |
Mutation testing❌ gremlins did not produce a report for 1 package(s), so no verdict can be derived from this run (see the job log):
gremlins found 3 surviving mutant(s) in changed files: the code ran under tests, but changing it did not fail any test.
Verdict: |
There was a problem hiding this comment.
Does not compile as it stands: the deleted dashboard_inception_handlers_test.go held a shared test helper.
src/pkg/dashboard/dashboard_inception_handlers_test.go:14on the base (v5) definesfunc newMinimalServer(t *testing.T) *Server. This PR deletes that file, butsrc/pkg/dashboard/api_knowledge_graph_promote_test.go:92(and lines 141, 229, 266, 301) still calls it. Nothing else in the PR head defines it.- CI shows exactly this:
build-go/ Vet fails withpkg/dashboard/api_knowledge_graph_promote_test.go:92:9: undefined: newMinimalServer. Thetest (dashboard *)andgolangci-lintfailures look like the same package failing to build, though I only read the vet log.
Fix: move newMinimalServer into a surviving test file (as was done for the e2e_helpers_test.go split) and re-check for any other helpers defined only in the removed test files.
Otherwise the approach reads sensibly: 410 Gone stubs for one release, wiki reconnect kept read-only, and the deletion path for /data/inception-wiki removed. I did not review the other 90 files in depth.
— hive: agent=reviewer backend=claude model=claude-sonnet-5-5 claude=2.1.325
77805f1 to
22cc3d9
Compare
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: merged v5 (docs citation conflicts only, regenerated with check-docs-citations.py --fix); CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.325 Review findings from Not a code defect I could find, but a breaking, irreversible-ish removal with red checks; a maintainer should make the call. What I read: Open items, not verified as defects:
I have not approved or closed anything. Review findings from One verified blocker: the
What I read, and it looks right:
Not covered: I did not read the ~16k deleted lines or every call site of the removed I have not merged, approved or closed anything. |
|
@clubanderson this PR is back in your court (
Once the new head lands, CI and the review swarm re-run automatically and the PR returns to the normal path. Current head: Updates (newest last):
|
|
scanner: golangci-lint and the dashboard shards fail with 🐝 Hive Agent: — hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.325 |
18af932 to
e8849be
Compare
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether the inception API, watcher and brainstorm inception mode are retired in this release, given that /api/inception/* now only answers 410 Gone for one release (src/pkg/dashboard/inception_gone.go) and the brainstorm-advisory policy and level-1 pack entries are removed.
This is a breaking removal (src/pkg/dashboard/inception_gone.go) returns a replacement and docs pointer for every retired route, which is the right migration shape.
What a maintainer should confirm:
- Callers of
/api/inception/*get 410 for one release, then 404. That is a deprecation window the PR sets, and nothing else in the diff enforces or schedules the final removal. - The diff also deletes the
brainstorm-advisorypolicy (src/policies/andsrc/pkg/policies/defaults/) and editssrc/pkg/config/packs/level-1.yaml. Both are policy surfaces on live hives, so someone who owns policy should sign off.
Not verified: I did not build or run the tests, and I did not check that nothing outside the diff still references the removed packages.
— hive: agent=reviewer-2 backend=claude model=claude-sonnet-5-5 claude=2.1.325
There was a problem hiding this comment.
Delta re-review (e8849be → 509cfb0): the 140-file delta is three merges of v5 and is mostly unrelated to the inception retirement. In this PR's own surface the 14 /api/inception/* routes still map to handleInceptionGone (src/pkg/dashboard/api.go:431-444), and the merge-resolved main.go has no live inception wiring left. No previous findings existed. I couldn't build or run tests locally.
- CI is red at this head.
test (rest 2/4)andSign-off survives the squashfail. I couldn't fetch the test log, so I can't tell whether the test failure comes from the merge resolution or is a flake. Please re-run or rebase and confirm. The sign-off failure only you can clear. - Stale comments (low).
src/cmd/hive/main.go:3049still says bootKnowledge "resumes or parks the brainstorm inception", andsrc/cmd/hive/main.go:3544still says bootDashboardAPI starts "inception watcher loops". Drop those clauses.
— hive: agent=adjudicator backend=claude model=claude-sonnet-5-5 claude=2.1.325
Review follow-ups (below
|
|
Scanner triage (baseline check: not shared, the failures are in this diff). Three fixes needed; I'm not pushing to this author-owned branch, so they are proposed here.
hive/awaiting-ci: held for author fixes; sweep will merge once checks are green. 🐝 Hive Agent: — hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.325 |
Remove the inception engine (pkg/knowledge/inception.go, including the
campaign archive and scaffold code), the dashboard inception handlers
and brainstorm bead watcher, the scheduler's inception wiring, the boot
resume/crash re-kick logic and the brainstorm prompt's inception mode.
Every former /api/inception/* route answers 410 Gone for one release
with a pointer to /api/sessions. Facts from past inception runs stay:
boot still reconnects the inception-wiki vault, and no file under /data
is deleted. ${INCEPTION_*} template variables render empty for one
release so custom templates keep working.
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
…defined Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
509cfb0 to
7ce814c
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
The scanner reached owner-session PRs as unattributed FIX-BEFORE-NEW rows (they default to scanner) and pushed its own commits onto branches another worker was still pushing to, turning 'Sign-off survives the squash' red (#18419), racing the worker's next push and duplicating its fix. A red or conflicted PR the hive App did not open is now listed as 'suggest, do not push' in FIX-BEFORE-NEW, the CI_FAILING push queue and PR_LIST while its branch is busy: a live claim by another worker on the PR or a linked issue (worker-claim ledger), or a head pushed within HIVE_SCANNER_BUSY_BRANCH_MINUTES (default 60, from the head's earliest CI activity, no new GitHub calls). App-authored lane branches, in-place adoptions and idle branches are listed exactly as before. Fixes #18488 Signed-off-by: Andy Anderson <andy@clubanderson.com>
…) (#18878) The /api/inception/* routes were retired in #18419 (410 Gone, replacement /api/sessions), so every !inception subcommand failed. Option B per the owner: keep the command registered and owner-gated, answer any subcommand with a pointer to the dashboard Sessions section, refuse multi-line input as a whole, and delete the chat interview state machine. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Third of three PRs that retire inception Campaigns in favour of Inception (spek) sessions. Earlier: #18400 (Campaigns tab) and #18407 (
/api/campaigns, Jam, Recheck and the one-time export).Callers found before removing anything
I grepped for every caller of
/api/inception/*, the inception engine and watcher, and the brainstorm inception mode.No caller found:
cmd/hivectl,pkg/hivectl)cmd/hive-admin-mcporadminmcpin this repo, andmcp_knowledge.godoes not call inceptionNon-UI callers found, and how each is handled:
dashboard/build-snapshot.mjsfetched/api/inception/stateto bake the old wizard into public snapshots. The fetch and the snapshot render are removed in this PR.src/docs/inception.md("Driving the workflow through the API"),api-reference/inception.mdandruns.md(inception approval as a run admission path). These are rewritten with a deprecation note.brainstorm-advisory.md, both the embedded default and thesrc/policiescopy. Its inception mode (the capture, clarify, structure and scaffold branches) is removed. Stale seeded copies refresh throughReconcileSeededDefaults.SetInceptionand the${INCEPTION_*}template variables. The engine wiring is removed. The six variables now always render empty for one release, so a custom template that names them keeps rendering.cmd/hive/main.go): the brainstorm resume, the stale-inception reset and the crash re-kick are removed. Brainstorm is still parked at boot, since it stays on-demand.Since there are external callers (scripts and docs), all 14
/api/inception/*routes stay registered and answer410 Gonefor one release. Nothing is read or changed. The body is:{"ok": false, "error": "The inception API was retired. Use Inception (spek) sessions instead ...", "replacement": "/api/sessions", "docs": "https://github.com/hivecommons/hive/blob/v5/src/docs/inception.md"}dashboard/openapi.jsonmarks the routesdeprecatedwith only a410response. The api-reference rows say so too.Removed
pkg/dashboard/inception_handlers.goandinception_watcher.go, with their tests and the kick/pluk-subscriber tests that only exercised them.pkg/knowledge/inception.go: the engine, the campaign archive code, the scaffold generator and the i18n strings, with their tests.slugifyandxmlEscapeare still used elsewhere, so they move topkg/knowledge/slug.go.Dependencies.Inception, the kick seams onServer, the boot deps (newInceptionEngine,restartBrainstorm,startInceptionWatcher) andboot.inceptionEngine.src/test. The shared HTTP helpers thatruns_e2e_test.gouses are kept ase2e_helpers_test.go.cruxandagentparse, and the stale copy in docs, the L1 pack, the FAQ and the hub journey.Kept: knowledge facts from past inception runs
Past ideation facts live in the knowledge store and as Markdown in
/data/inception-wiki. Nothing in this PR deletes them.knowledge.ReconnectInceptionWikidoes the same: it reads only, and uses the saved wiki name frominception/state.json, defaulting toinception-wiki.inception_wiki_test.go, including that the fact file stays on disk.StartandResetused to wipe the wiki directory. That deletion path is now gone./data/inception/stays on disk. The campaign archives were exported by ⚠️ Retire /api/campaigns, campaign Jam and Recheck #18407.Also kept: the
brainstormagent itself (ideation-only, on-demand), the ACMM "L1 Inception" level name, andknowledge.InceptionState, which the wiki reconnect reads.v6
The v5 to v6 top-up carries this change to v6. The v6-only transcript fact-confirmation panel from the old wizard was already removed by an earlier top-up.
🤖 Generated with Claude Code