Repository navigation
✨ Inbox: ● Record in the dashboard - #18422
Conversation
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Why:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. Evidence bundle `#184223777dee` sha256:e4844365c1297aae48e804ed2418b6efd9a8a5bbb8378dd7def62d6b1dcf27af — download from the dashboard or `hivectl review evidence #18422`. |
Record a meeting or note from the microphone straight into the Inbox: consent notice before every recording, red ● Recording indicator for the whole session, timer, level meter, Pause/Resume/Stop and upload status. MediaRecorder chunks every 10 s at 32 kbit/s go to an IndexedDB queue and leave it only on a 2xx, so a network drop or reload resumes the upload. Wake Lock and a hidden-tab warning; a shortcut in Inception. Hidden for read users. inbox.recording.enabled now defaults to true. Signed-off-by: Andy Anderson <andy@clubanderson.com>
396da16 to
13f8deb
Compare
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether microphone recording ships enabled by default on every hive, given that recording laws vary by jurisdiction.
One decision needed: inbox.recording.enabled flips from false to true (src/pkg/config/inbox_recording.go:15, src/docs/inbox-recording.md:57), so every existing hive gets a ● Record control for owner and read-write users on upgrade, with no operator opt-in.
What I read: the default flip and its test change (src/pkg/inbox/recordings_test.go), plus the recorder state-machine tests, which cover consent being required on every start, never stored, and Start disabled until the box is ticked. The PR body states default-on as intentional, so I am not questioning the choice. The open point is that it turns on audio capture of people, which is a legal/privacy risk class. That is a maintainer's call, not a code defect.
If default-on is intended, no change is needed from me. I did not exhaustively review the roughly 1,300 lines of recorder JS in static-src/js/inbox-recorder.js, so this is not a full code approval.
— hive: agent=reviewer backend=claude model=claude-sonnet-5-5 claude=2.1.325
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 3777dee. |
Second of the "record a meeting directly in hive" PRs (backend: #18408). This adds the dashboard recorder, microphone only, and turns
inbox.recording.enabledon by default. Tab audio and auto-transcription follow in their own PRs.What it adds
inbox.recording.enabled, the viewer is owner or read-write, and the browser hasMediaRecorder+getUserMedia.2026-11-v1) is sent with the start request and stored with the user (backend). If transcription is off on this hive, the notice says the recording will not be transcribed until an owner enables it.AnalyserNodeinto a<meter>), Pause/Resume, Stop and save, Discard, and the upload status ("All chunks saved on the hive" vs "N chunks waiting to upload", plus retry countdown and Retry now).MediaRecorder.start(10000),audioBitsPerSecond32000, WebM/Opus or MP4 (Safari); pieces overmax_chunk_bytesare split. Every chunk is written to an IndexedDB queue first and removed only on a 2xx; network errors, 408/429/5xx retry with backoff (2 s doubling to 30 s); a 409 withexpected_seqpast the chunk means the hive already has it (lost ack); other refusals stop the upload with the reason. After a reload, queued chunks upload and the recording is finalized. A Web Lock keeps another tab from finalizing a recording that is still live.hive-recordingshow who recorded them, their own pending text, and audio expired (kept N days) with no play control after retention.blob:preview; playback is same-origin from the hive). Permissions-Policy already hasmicrophone=(self)for the dashboard document.--red,--surface,--sp-*, ...); no inline styles.src/docs/inbox-recording.mddefault updated.Tests
JS node (
inbox_recorder.test.js, sandboxed fromstatic/index.htmlwith injected helpers): recorder state machine with a fake MediaRecorder and getUserMedia (chunks in order, pause excluded from duration, finalize, mic released), consent required every time and never stored, consent text, queue resume after a simulated network failure with backoff, lost-ack 409, fatal refusal, reload resume, live-lock skip, mic refusal and refused start, discard, panel, role and browser support matrix. Go: flag default.🤖 Generated with Claude Code