Repository navigation
✨ Inbox: record recordings directly in hive (backend) - #18408
Conversation
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. clubanderson this PR is held at Why:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. hive/awaiting-ci: rebased onto v5 (clean, no conflicts); CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.325 |
8da1e84 to
f1cc41e
Compare
f1cc41e to
0a5b177
Compare
Mutation testing⏱️ The 900s mutation budget ran out, so 2 package(s) were not fully mutated and the results below do not cover them:
4 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the
Verdict: |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Store recordings made in the hive's own dashboard: start (consent version and user stored), ordered 512 KiB chunks fsynced per part with 409 gap detection and idempotent re-send, finalize (in-order concatenation into audio.webm or audio.mp4 plus a pending personal-layer Knowledge fact), abort, and same-origin Range playback with no-store. Caps: max_seconds 3h, max_bytes 200 MiB, quota_bytes 2 GiB; idle recordings finish after 2h. A sweep deletes raw audio after inbox.recording.retention_days (default 5) and keeps the transcript and fact. RecordingSource lists recordings as hive-recording Inbox items. Owner and read-write only, audited. Off by default in this PR. Signed-off-by: Andy Anderson <andy@clubanderson.com>
0a5b177 to
aa709d7
Compare
|
New changes are detected. LGTM label has been removed. |
First of the sequential "record a meeting directly in hive" PRs: the backend store and API. The dashboard recorder follows in the next PR; this one keeps
inbox.recording.enableddefault false.What it adds
inbox.recordingconfig:enabled(false here),retention_days5,max_seconds10800 (3h),max_bytes200 MiB,quota_bytes2 GiB,idle_finalize_minutes120.max_bytesmust not exceedquota_bytes.POST /api/inbox/recordingswith{title, mime, consent_version, includes_tab_audio}returns{id, max_chunk_bytes, max_seconds, retention_days, transcribes}. The consent notice version and the user are stored in the recording's metadata. One active recording per user (409 withactive_id).POST /api/inbox/recordings/{id}/chunks?seq=N: raw body throughhttp.MaxBytesReader(512 KiB), in order only (409 withexpected_seqon a gap), idempotent re-send by sha256 (200duplicate: true), each part fsynced. The first chunk is sniffed for a WebM (EBML) or MP4 (ftyp) signature; anything else is 415. The hive never decodes audio.POST .../finalize: concatenates parts in order intoaudio.webm/audio.mp4, writesmeta.jsonand a pending Knowledge fact in the personal layer (never published to the hub).DELETE .../{id}: abort (the recorder, or an owner).GET .../{id}/audio: same-originhttp.ServeContent(Range),Cache-Control: no-store,Cross-Origin-Resource-Policy: same-origin; 410 "audio expired (kept 5 days)" after retention. The generic Inbox player path/api/inbox/hive-recording/{id}/audio/streamserves the same file from disk (no HTTP call to itself).<knowledge data>/connector-state/recordings/<id>/, 0700 dirs and 0600 files.retention_days, logged and audited. Transcripts and facts stay.RecordingSource(hive-recording, builtin): implementsSourceandAudioSource, plus a newAudioOpenerfor local files. Items carryrecorded_by,audio_expiredandaudio_retention_days; expired items are not transcribable.inbox_recording_start,inbox_recording_finalize,inbox_recording_abort,inbox_recording_audio,inbox_recording_audio_expired.src/docs/inbox-recording.md(consent guidance, retention, storage), API reference rows, OpenAPI entries.Tests
Go: role matrix (read and unverified owner 403), consent required and stored, one active per user, MIME and container sniff (rejects non-media), chunk order, gap 409, idempotent resend and mismatch, chunk size, max_bytes, quota, max_seconds, finalize concatenation (WebM and fragmented MP4 box walk), empty finalize, abort, retention sweep at 5 days keeps transcript and fact, configurable retention, idle auto-finalize, Range 206 and no-store on the audio endpoint, 410 after expiry, config defaults, YAML and validation.
🤖 Generated with Claude Code