Skip to content

✨ Inbox: read Word (.docx) documents dropped or linked - #18425

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
feat/inbox-upload-docx
Nov 16, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
feat/inbox-upload-docx

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Third of three PRs that retire inception Campaigns in favour of Inception (spek) sessions. Earlier: #18400 (Campaigns tab) and #18407 (/api/campaigns, Jam, Recheck and the one-time export).

Callers found before removing anything

I grepped for every caller of /api/inception/*, the inception engine and watcher, and the brainstorm inception mode.

No caller found:

  • hivectl (cmd/hivectl, pkg/hivectl)
  • MCP tools: there is no cmd/hive-admin-mcp or adminmcp in this repo, and mcp_knowledge.go does not call inception
  • the hub
  • chat commands

Non-UI callers found, and how each is handled:

  • dashboard/build-snapshot.mjs fetched /api/inception/state to bake the old wizard into public snapshots. The fetch and the snapshot render are removed in this PR.
  • Docs that told users to curl the API: src/docs/inception.md ("Driving the workflow through the API"), api-reference/inception.md and runs.md (inception approval as a run admission path). These are rewritten with a deprecation note.
  • Agent prompt: brainstorm-advisory.md, both the embedded default and the src/policies copy. Its inception mode (the capture, clarify, structure and scaffold branches) is removed. Stale seeded copies refresh through ReconcileSeededDefaults.
  • Scheduler: SetInception and the ${INCEPTION_*} template variables. The engine wiring is removed. The six variables now always render empty for one release, so a custom template that names them keeps rendering.
  • Boot (cmd/hive/main.go): the brainstorm resume, the stale-inception reset and the crash re-kick are removed. Brainstorm is still parked at boot, since it stays on-demand.

Since there are external callers (scripts and docs), all 14 /api/inception/* routes stay registered and answer 410 Gone for one release. Nothing is read or changed. The body is:

{"ok": false, "error": "The inception API was retired. Use Inception (spek) sessions instead ...", "replacement": "/api/sessions", "docs": "https://github.com/hivecommons/hive/blob/v5/src/docs/inception.md"}

dashboard/openapi.json marks the routes deprecated with only a 410 response. The api-reference rows say so too.

Removed

  • pkg/dashboard/inception_handlers.go and inception_watcher.go, with their tests and the kick/pluk-subscriber tests that only exercised them.
  • pkg/knowledge/inception.go: the engine, the campaign archive code, the scaffold generator and the i18n strings, with their tests.
    • slugify and xmlEscape are still used elsewhere, so they move to pkg/knowledge/slug.go.
  • Dependencies.Inception, the kick seams on Server, the boot deps (newInceptionEngine, restartBrainstorm, startInceptionWatcher) and boot.inceptionEngine.
  • The integration-tagged inception e2e and regression suites in src/test. The shared HTTP helpers that runs_e2e_test.go uses are kept as e2e_helpers_test.go.
  • Stale comments in crux and agentparse, and the stale copy in docs, the L1 pack, the FAQ and the hub journey.

Kept: knowledge facts from past inception runs

Past ideation facts live in the knowledge store and as Markdown in /data/inception-wiki. Nothing in this PR deletes them.

  • The engine used to reconnect that vault on boot. The new knowledge.ReconnectInceptionWiki does the same: it reads only, and uses the saved wiki name from inception/state.json, defaulting to inception-wiki.
  • It is tested in inception_wiki_test.go, including that the fact file stays on disk.
  • The removed engine's Start and Reset used to wipe the wiki directory. That deletion path is now gone.
  • /data/inception/ stays on disk. The campaign archives were exported by ⚠️ Retire /api/campaigns, campaign Jam and Recheck #18407.
  • Ideation fact types are unchanged.

Also kept: the brainstorm agent itself (ideation-only, on-demand), the ACMM "L1 Inception" level name, and knowledge.InceptionState, which the wiki reconnect reads.

v6

The v5 to v6 top-up carries this change to v6. The v6-only transcript fact-confirmation panel from the old wizard was already removed by an earlier top-up.

🤖 Generated with Claude Code

Headings, paragraphs, lists and tables become markdown; the title comes
from docProps/core.xml or the first heading. Read in Go with archive/zip
and encoding/xml: entry-count, inflated-size (declared and actual) and
compression-ratio caps against zip bombs; DTDs and unknown entities are
refused (no XXE).

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18419 ⚠️ Retire the inception API, watcher and brainstorm inception mode same files dashboard/openapi.json
#18405 ✨ Inbox: send items into an Inception (spek) session same files dashboard/openapi.json
#18424 ✨ meetings: Betty drafts issues, RFCs, Spek sessions and knowledge notes for approval (Betty F) same files dashboard/openapi.json
src/docs/api-reference/knowledge.md
#18416 ✨ meetings: Quorum v0.2.0 and Discord speech through the TTS service same files dashboard/openapi.json
src/docs/api-reference/knowledge.md
#18417 ✨ meetings: Settings tab "Meeting attendee" with Kokoro persona presets (Betty E) same files dashboard/openapi.json
src/docs/api-reference/knowledge.md

@github-actions

Copy link
Copy Markdown
Contributor

Mutation testing

gremlins found 23 surviving mutant(s) in changed files: the code ran under tests, but changing it did not fail any test.

File Line Mutation
src/pkg/inbox/upload_docx.go 50 CONDITIONALS_BOUNDARY
src/pkg/inbox/upload_docx.go 57 CONDITIONALS_BOUNDARY
src/pkg/inbox/upload_docx.go 60 CONDITIONALS_BOUNDARY
src/pkg/inbox/upload_docx.go 60 CONDITIONALS_BOUNDARY
src/pkg/inbox/upload_docx.go 63 CONDITIONALS_BOUNDARY
src/pkg/inbox/upload_docx.go 63 CONDITIONALS_NEGATION
src/pkg/inbox/upload_docx.go 77 CONDITIONALS_BOUNDARY
src/pkg/inbox/upload_docx.go 85 ARITHMETIC_BASE
src/pkg/inbox/upload_docx.go 89 CONDITIONALS_BOUNDARY
src/pkg/inbox/upload_docx.go 160 CONDITIONALS_NEGATION
src/pkg/inbox/upload_docx.go 208 INCREMENT_DECREMENT
src/pkg/inbox/upload_docx.go 209 ARITHMETIC_BASE
src/pkg/inbox/upload_docx.go 209 CONDITIONALS_NEGATION
src/pkg/inbox/upload_docx.go 209 CONDITIONALS_NEGATION
src/pkg/inbox/upload_docx.go 234 CONDITIONALS_BOUNDARY
src/pkg/inbox/upload_docx.go 251 CONDITIONALS_BOUNDARY
src/pkg/inbox/upload_docx.go 251 CONDITIONALS_NEGATION
src/pkg/inbox/upload_docx.go 255 CONDITIONALS_BOUNDARY
src/pkg/inbox/upload_docx.go 288 CONDITIONALS_NEGATION
src/pkg/inbox/upload_docx.go 292 CONDITIONALS_BOUNDARY
src/pkg/inbox/upload_docx.go 297 CONDITIONALS_BOUNDARY
src/pkg/inbox/upload_docx.go 299 CONDITIONALS_BOUNDARY
src/pkg/inbox/upload_docx.go 299 CONDITIONALS_BOUNDARY

5 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the mutation/acknowledged label to accept this.

File Line Mutation
src/pkg/inbox/upload_docx.go 245 CONDITIONALS_NEGATION
src/pkg/inbox/upload_docx.go 314 ARITHMETIC_BASE
src/pkg/inbox/upload_docx.go 314 INVERT_NEGATIVES
src/pkg/inbox/upload_docx.go 334 CONDITIONALS_BOUNDARY
src/pkg/inbox/upload_docx.go 334 CONDITIONALS_NEGATION

Verdict: lived (#17349).

@hivecommons-hive
hivecommons-hive Bot merged commit 6f0dbd2 into v5 Nov 16, 2026
84 of 90 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the feat/inbox-upload-docx branch November 16, 2026 14:25
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#184258d78382` sha256:c52d68d1d93280c74bf4b00b572da461296c7b9ccde4abaacf4f8d610241a7bf — download from the dashboard or `hivectl review evidence #18425`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 8d78382.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant