Repository navigation
✨ meetings: Betty drafts issues, RFCs, Spek sessions and knowledge notes for approval (Betty F) - #18424
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. clubanderson this PR is held at Why:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. Review findings from Delta re-review at ae497a2 (correctness). Prior findings, re-checked at this head:
I did not read the full 16k-line delta; I checked the prior-finding sites only. Review findings from Style re-review at ae497a2 (delta vs e4ce816 is mostly rebase noise: 140 files, only ~35 belong to this PR). Nothing new from the style perspective in the PR's own files. Prior findings at this head:
hive/awaiting-ci: merged v5 in (clean, signed off); CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.325 Evidence bundle `#184249f52ea8` sha256:063d50fc374169e28687b89a530a83f321f89565e9dad49e1c34fa2ab0975fb4 — download from the dashboard or `hivectl review evidence #18424`. |
e4ce816 to
4bf8f6d
Compare
Review follow-ups (below
|
There was a problem hiding this comment.
Security review: one fix needed
src/pkg/meetings/actions/actions.go:2914 (clean): RequestedBy gets only oneLine+clip, while Title/Body/Excerpt/Request go through Defang. RenderBody then writes it into the filed item (", asked for by %s (meeting display name)"). The display name is set by any meeting participant, so a name like @someone pings that user from the hive App on approval. A name containing ](http://…) can inject links. This contradicts the PR's stated safety property that @ mentions are removed before filing. MeetingTitle goes into [%s](%s) unescaped in the same function.
Suggested fix:
- d.RequestedBy = clipRunes(oneLine(d.RequestedBy), MaxTitleRunes)
+ d.RequestedBy = clipRunes(Defang(oneLine(d.RequestedBy)), MaxTitleRunes)
+ d.MeetingTitle = clipRunes(Defang(oneLine(d.MeetingTitle)), MaxTitleRunes)Also strip [, ], ( and ) from both before they are interpolated in RenderBody.
Checked and fine: role gating on every route (requireMeetingsScheduleRole, owner-only settings PUT), repo checked against monitored repos in Submit and Edit, auto-approve limited to knowledge, excerpt fenced.
— hive: agent=adjudicator-2 backend=claude model=claude-sonnet-5-5 claude=2.1.325
Mutation testing⏱️ The 900s mutation budget ran out, so 3 package(s) were not fully mutated and the results below do not cover them:
❌ gremlins did not produce a report for 1 package(s), so no verdict can be derived from this run (see the job log):
4 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the
Verdict: |
89566f6 to
ae497a2
Compare
There was a problem hiding this comment.
Security delta re-review @ ae497a2 (read actions.go, link_fetch.go at head; mailin/auth not deeply audited)
Still present (in-scope): speaker display name filed un-defanged. clean() (src/pkg/meetings/actions/actions.go:484) sets d.RequestedBy = clipRunes(oneLine(d.RequestedBy), MaxTitleRunes) with no Defang, unlike Title/Body/Excerpt/Request (lines 480-483). It is then written verbatim into the filed issue body at actions.go:761-762 ("asked for by %s"). A participant who joins with the display name @some-maintainer or @org/team makes the hive's issue ping that user. The comment on line 135 says the name is unverified, and Defang's own doc (line 463) says meeting text must never ping anyone.
Fix:
d.RequestedBy = clipRunes(Defang(oneLine(d.RequestedBy)), MaxTitleRunes)
Also consider running Defang on d.MeetingTitle before it is used at line 752-756, since calendar titles are attacker-influenced too.
Other previous findings (correctness/intent) are outside this perspective; I did not re-verify them. The new link fetcher (src/pkg/inbox/link_fetch.go:50-274) blocks private/link-local/metadata ranges at dial time and checks redirects, so no SSRF finding.
— hive: agent=adjudicator-2 backend=claude model=claude-sonnet-5-5 claude=2.1.325
|
hive/scanner: rebase onto 🐝 Hive Agent: — hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.325 |
…tes for approval People can ask Betty in a meeting, spoken or typed, to open an issue, open an RFC, start a Spek session or save a knowledge note. She drafts it from the request and the recent transcript (title, short body, target repo when named, link to the meeting, transcript excerpt), confirms in the chat that it is waiting for approval, and asks one clarifying question when the request is unclear. Nothing is created from the meeting itself. - pkg/meetings/actions: the approval queue (actions.json in the meetings data dir), approve / edit / reject, executors per type, result announced back to the meeting. Only knowledge notes may be auto-approved. - betty/actions.go: request detection (with or without a comma after the name), clarification, model or rule drafting; meeting text stays data, the type comes from the request and repos are checked against the monitored list. - live: Runner.SetPersonaActions and Runner.Announce (chat while live, notes after). - cmd/hive: issue and RFC through the GitHub issue path (rfc label and "RFC: " title), Spek session through the Inbox spek_rfc destination, knowledge note through the meetings vault write. - dashboard: /api/meetings/actions list, edit, approve, reject (owner or read-write) and /api/meetings/actions/settings (read: owner or read-write; save: owner); "Drafts from meetings" in the Calendar section. - config: meetings.persona.actions (enabled, types, default_repo, auto_approve) with HIVE_MEETINGS_PERSONA_ACTIONS_* overrides. - Docs: meetings.md "Asking Betty to do things", env-vars, api-reference, dashboard-sections, openapi.json; changelog fragment. Part of #18391. Fixes #18406 Signed-off-by: Andy Anderson <andy@clubanderson.com>
…ettings Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
bb7d6f2 to
4158ff4
Compare
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 9f52ea8. |
Part of #18391. Fixes #18406
People in a meeting can ask Betty, spoken or in the meeting chat, to open an issue, open an RFC, start a Spek session or save a knowledge note ("Betty, open an issue for the lobby timeout", "make that an RFC, Betty", "betty start a spek session on calendar sync", "save that as a knowledge note"). She drafts the item and confirms in the chat: "Drafted an issue: '<title>'. It's waiting for approval in the hive." Nothing is created from the meeting itself.
Flow
betty/actions.go: detects a request addressed to her (also the comma-less form speech-to-text writes), drafts title and body from the request plus the last three minutes (meetings model, rule fallback), attaches the meeting link and a transcript excerpt, and asks one clarifying question when the request names nothing and nothing was said before it (the model may ask that one question too, never twice). Confirmations never say the item exists.pkg/meetings/actions: the approval queue (<meetings.data_dir>/actions.json, atomic writes), Approve / Edit / Reject, a restart mid-approval marks the draft failed instead of retrying it. Only knowledge notes may be auto-approved.github.Client.CreateIssue(App, provenance label, exact-title dedupe; RFC =RFC:title plus therfclabel rfcnotify reads), Spek session through the Inboxspek_rfcdestination, knowledge note through themeetingsvault write meeting notes use. The result is posted in the meeting chat while it is live (Runner.Announce), otherwise added to the meeting notes./api/meetings/actionslist,/{aid}/edit|approve|rejectneed the verified owner or a read-write user.Config
meetings.persona.actions:enabled(default true),types(default all four),default_repo(falls back toinbox.spek.repo,project.primary_repo, the first repo),auto_approve(all false; validation refuses anything butknowledge). Env:HIVE_MEETINGS_PERSONA_ACTIONS_ENABLED,_TYPES,_DEFAULT_REPO,_AUTO_APPROVE_KNOWLEDGE. Settings API for the Meeting attendee tab (#18417 is not merged yet, so this is a separate endpoint):GET /api/meetings/actions/settings(owner or read-write) andPUT(owner); a saved change applies without a restart.Safety: meeting text reaches the model only inside the data block with delimiters stripped; the type comes from the request, never the model; a repo the model or speaker names is used only when it is monitored;
@mentions are removed before filing; the excerpt is quoted as a code block.Tests: chat and speech replays for every type, repo from the request, clarification (answer, other speaker, cancel, expiry, model-asked once), type off / actions off, auto-approve only for knowledge, prompt injection treated as data, submit failure, queue approve / edit / reject / retry / restart / prune, announce to chat and notes, executors, auth on every route, settings validation, and the UI wiring and split executed in node.
Docs: meetings.md "Asking Betty to do things", configuration table, env-vars, api-reference, dashboard-sections, openapi.json;
static/index.htmlregenerated.🤖 Generated with Claude Code