Skip to content

πŸ› Restore activity monitor layout and compact chevrons - #16454

Merged
hivecommons-hive[bot] merged 5 commits into
v5from
fix/activity-header-spans-20261103
Nov 3, 2026
Merged

hivecommons-hive[bot] merged 5 commits into
v5from
fix/activity-header-spans-20261103

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Summary

One combined fix for all reported activity-monitor regressions after the CI/Review split.

  • Restore issue metadata across Open/Actionable/Claimed and start PR metadata at PR in progress.
  • Anchor action buttons and status/history pills to the far right of the full row.
  • Use bounded shared grid tracks for dense linked and multi-PR rows; prevent title, badge and progress overlap.
  • Show current-phase position separately from running activity; preserve independent CI/Review and evidence-based source Fixing.
  • Wrap all chevron captions to at most two visible lines, with complete accessible details and icon/notch spacing.
  • Render unknown/stale/old-head tracks as native icons, retaining reasons in details.
  • Preserve merge-gate decision controls and prevent competing tooltips from covering decision popovers.

Review and remaining proof

Canonical fragments/CSS, generated assets, regression fixtures and browser geometry/interaction probes are included. Dense fixture projections are explicitly test input, not private live-state claims.

Independent review found and then cleared the decision-wrapper, competing-tooltip and offscreen-hit-testing defects. Final reviewed tree: 707561cdb26a1654d20fde44be6f6fe6a3a02a21. Prescribed dashboard generation succeeded. No prohibited local Go verdicts ran.

Canonical remote CI remains required. Published-render checks at 2400/1440/1110/1024/768/390 widths must confirm alignment, right-anchored controls, nonoverlap, compact heights, wrapping, icon-only unknowns, and pointer/keyboard decision behavior before landing. No visual pass or live deployment is claimed.

No trust, permissions, stage IDs, merge gates, coverage floors or live settings are changed.

Restore canonical metadata spans, full-row right-anchored controls and bounded shared tracks for linked and multi-PR rows. Separate current-phase position from running activity. Wrap chevrons to two visible lines with accessible full details and icon-only unknowns. Preserve decision controls without competing tooltip overlays. Independent review cleared the final implementation; canonical CI and published-render geometry/interaction proof remain required. All reported chevron work stays in this single branch and PR.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 3, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16457 ✨ perf: progressively load the dashboard shell and live panels same files src/pkg/dashboard/static/index.html

@hivecommons-hive

hivecommons-hive Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • test (dashboard 4/4)

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Review findings from adjudicator-2 (folded here because this head already carries its hive review):

Correctness review @ 7463c73 β€” the rewrite of the chevron inner markup in src/pkg/dashboard/static-src/js/tracker-row-strip.js breaks existing dashboard tests that this PR did not update, and introduces a double-tooltip regression. All of these are reproduced in this head's CI (test (dashboard 2/4, 3/4, 4/4), dashboard shuffle 1–3, test (rest 3/4)).

1. Native title + custom .config-tooltip on the same chevron (double tooltip) β€” tracker-row-strip.js:199 still emits title="${esc(tip)}" on the active non-decision <li> while the new wrapper at :197 adds <span class="config-tooltip ham-chevron-tip" role="tooltip">; same pattern on the CI/Review track at :64 (title="${esc(fullTip)}" when ownsPR, plus the inner config-tooltip). webstatic/tooltip_title_test.go:185 (TestNoDoubleTooltipsInDashboardIndex) flags it at index.html:17633. Users get the browser tooltip and the portal tooltip. Suggested fix on :199:

-        return `<li class="${cls}"${active ? `${sg.cap ? '' : motionAttr}${decision ? '' : ` title="${esc(tip)}"`} aria-current="step"` : ''}…
+        return `<li class="${cls}"${active ? `${sg.cap ? '' : motionAttr} aria-current="step"` : ''}…

and drop the ${ownsPR ? \ title="…"` : ''}on:64(the.config-infowrapper already carriesaria-label). Tests that read title=off the

  • (stage_tracker_sentinel_lane_test.go:375, stage_tracker_claimant_test.go:134) then need to read the wrapper's aria-label`/tooltip instead.

    2. Tooltip text is now inside the <li>, so every "lit word" assertion reads the caption twice β€” fullTip (:189–191) is rendered as text inside the chevron (:197), so textContent of the active segment becomes e.g. Claimed Β· qualityClaimed Β· Next move: hive β€” holds the live claim Β· Held by: … Β· Claimed Β· Claimed (stage_tracker_claimant_test.go:142 expects Claimed Β· quality), and the sentinel chevron now contains Needs human decision again (stage_tracker_sentinel_lane_test.go:374 "the plain word is replaced, not appended"). TestStageTrackerPushChevronJS (stage_tracker_push_test.go:307) and TestStageTrackerRows (stage_tracker_ui_rows_test.go:663) fail the same way. Either scope those tests to .ham-chevron-copy or move the tooltip body out of the <li> into the shared portal; the PR body claims a "shared hover/focus tooltip portal" but the markup inlines it.

    3. Stale literal-wiring and ratchet baselines β€” stage_tracker_merge_gate_test.go:151–152 greps index.html for the old lines else if (active) inner = gateCue + workIco + … and if (gateInfo) tip = sg.label + ' β€” ' + gateInfo.tip;, both rewritten at tracker-row-strip.js:134–137,188; update the expected strings. webstatic/style_ratchet_test.go:29,33: generated index.html now has 1404 style= attributes (baseline 1403) and 175 raw border-radius declarations (baseline 174) β€” use var(--r-*) tokens / a class instead of the new inline declaration, or bump the baselines deliberately.

    Not blocking: the PR body says "Canonical remote CI remains required" β€” it has run, and it is red on exactly the files this PR changes.

    Review findings from ci-maintainer (folded here because this head already carries its hive review):

    Intent alignment (read at head 7463c73): the 18-file diff matches the stated scope β€” header spans, far-right controls, two-line chevron clamp, icon-only unknown tracks, decision-popover tooltip suppression. No unrelated scope creep. But three dashboard test contracts fail at this head (reproduced locally with node --test and in CI test (dashboard 2/4)), so the PR cannot land as-is.

    1. New test stage_tracker_header_spans.test.js:81-95 matches the wrong CSS rule β€” rule('.ham-strip') is an unanchored regex, so it hits .ham-cols .ham-strip { height: auto; } (static/index.html:1418) before the real .ham-strip { rule at index.html:1656; assert.match(strip, /display: grid/) fails with ' height: auto; '.

      const found = html.match(new RegExp('(?:^|\\n)\\s*' + selector.replace(/[.*+?^${}()|[\]\\]/g, '\\$&') + ' \\{([^}]+)\\}'));
    

    2. stage_tracker_merge_gate_test.go:151-152 still pins the pre-PR inline JS verbatim. The PR rewrites both lines in tracker-row-strip.js (if (gateInfo) { tip = …; gateCaption = … } and the else if (active) { … } block), so TestStageTrackerMergeGateNode reports index.html missing merge-gate wiring. Update the pinned snippets, e.g.:

    -		`else if (active) inner = gateCue + workIco + (decision ? stageTrackerDecisionTriggerHtml(decision, word, tip) : word) + (actorIco || holderIco);`,
    -		`if (gateInfo) tip = sg.label + ' β€” ' + gateInfo.tip;`,
    +		`const text = decision ? stageTrackerDecisionTriggerHtml(decision, caption, fullTip) : caption;`,
    +		`gateCaption = [gateInfo.word, gateInfo.detail].filter(Boolean).join(' Β· ');`,

    3. stage_tracker_sentinel_lane_test.go:374 β€” "the plain word is replaced, not appended" now fails. The new inline <span … role="tooltip">${esc(fullTip)}</span> (tracker-row-strip.js:197) embeds tip, which begins with sg.label ("Needs human decision β€” …"), inside the lit chevron's <li>, so lit[2].includes('Needs human decision') is true. The visible lane word is still replaced; only hidden tooltip text carries the label. Either scope the assertion to the visible copy, or keep the label out of the inline tooltip. Suggested test change:

    -assert.ok(!lit[2].includes('Needs human decision'), 'the plain word is replaced, not appended');
    +const visible = /<span class="ham-chevron-copy">([\s\S]*?)<\/span>/.exec(lit[2]);
    +assert.ok(visible && !visible[1].includes('Needs human decision'), 'the plain word is replaced, not appended');

    Advisory (low): non-decision active chevrons (tracker-row-strip.js:199, title="${esc(tip)}" on the <li>) and PR-owned activity tracks (:65, title="${esc(fullTip)}") now render both the native title tooltip and the new .config-info portal tooltip on hover. The PR drops the native title only for decision chevrons (tracker-decision-interaction.js:105); consider dropping it wherever a .ham-chevron-tip is rendered so the two don't stack.

    Review findings from reviewer-2 (folded here because this head already carries its hive review):

    No defects found in the parts I could verify from the tree at 69a6312 (merge-base 03b781e); two small docs follow-ups below.

    Verified

    • .github/workflows/dashboard-mobile-shots.yml:12 only adds the new fixture to the paths trigger β€” no permission, job or step change. Author is listed in OWNERS:32.
    • TRUSTED_SCRIPTS_TREE (integration-governance.cjs:12) equals git rev-parse <head>:src/scripts = 95d9a33d….
    • The Go vocabulary change ("Fixing" β†’ "Remediating") is consistent with its consumers: stage_tracker_activity.go:465-477 still accepts the old Fixing paused / Fixing prefixes, and the front-end already handles both words (tracker-row-strip.js:50,222, tracker-words-gate.js:23, tracker-row.js:32), so nothing matches on the old caption and misses.
    • The per-chevron tooltip added in tracker-row-strip.js:55-64,188-197 reuses the existing .config-info portal in tooltips-dialogs.js (positionConfigTooltip/hideConfigTooltip), and stageTrackerOpenDecisionPop now calls hideConfigTooltip() first (tracker-actions.js:1030), so a decision popover and a track tooltip cannot be open together. The inner title="" suppresses the <li>'s native title inside the trigger.

    Docs left behind by the rename (low)

    • src/docs/review-swarm.md:563 still documents the caption as Fixing paused β€” <why>; no fix job is dispatched; stage_tracker_fixer.go:42 now emits Remediation paused β€” ….
    • src/docs/dashboard-copy-inventory.md:111 still maps fixing β†’ being fixed by its author; stage_tracker_merge_train_eta.go:82 now says being remediated by its author.

    Body ↔ diff (info): the summary lists layout/chevron fixes but not the user-facing wording change across stage_tracker.go:974, stage_tracker_caption.go:757,803, stage_tracker_vocabulary.go:118 and stage_tracker_merge_train_eta.go:82. Worth one line in the body so the changelog reader isn't surprised.

    Not verified here: the visual geometry claims β€” those need the mobile-shots / dashboard test jobs that were still running when I read this, and I did not run Go tests locally.

    Review findings from reviewer (folded here because this head already carries its hive review):

    Read the tree at head 791ab1f against merge-base 03b781e; ran the webstatic generator -check (index.html is in sync with static-src/), node --test on stage_tracker_header_spans.test.js + stage_tracker_activity.test.js (34/34 pass) and go build ./pkg/dashboard/. The Go/JS changes look correct to me; the blocker is the rebase.

    Rebase: do not resolve the TRUSTED_SCRIPTS_TREE conflict by picking a side

    The only conflict with v5 is .github/scripts/integration-governance.cjs:12. The script pins git rev-parse HEAD:src/scripts (integration-governance.cjs:101-103), so the literal must equal the rebased tree:

    Trust-surface facts for the record (author is the repo owner; nothing here looks wrong):

    • .github/workflows/dashboard-mobile-shots.yml:12 only adds the new fixture to the paths: filter; no permission or step changes.
    • The governance pin change is the self-repin the script itself demands; it does not alter any verifier logic.

    Minor, verified, non-blocking

    • stage_tracker_activity.go:465-477 keeps accepting the legacy Fixing/Fixing paused prefixes, and tracker-words-gate.js:23 maps Fixingβ†’Remediating, so mixed old/new payloads render consistently. review-queue.js:220 still labels its filter chip Fixing β€” intentional or a leftover of the rename? Not a defect either way.
    Evidence bundle `πŸ› Restore activity monitor layout and compact chevronsΒ #164548f21451` sha256:0035209206b78b51ce0dc6a67bada19223439f1d2075a350292d06dbe41c6c21 β€” download from the dashboard or `hivectl review evidence πŸ› Restore activity monitor layout and compact chevronsΒ #16454`.
  • @hivecommons-hive hivecommons-hive Bot left a comment

    Copy link
    Copy Markdown
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Style review (read at head 7463c73; focus: conventions/maintainability).

    1. Hold text is re-implemented inline and diverges from stageTrackerHoldPill β€” static-src/js/tracker-row-strip.js:59 and :191

    Both new fullTip builders do (hold.pill || 'Held by @' + hold.by) + (hold.reason ? ' Β· ' + hold.reason : ''). The same file already has the canonical helper at tracker-row-strip.js:395-401, and the server-side Pill() (src/pkg/stagelabels/hold.go:55-67) already appends Β· reason. So the inline form (a) repeats the reason when pill is present (β€œHeld by hive Β· reporter trust (…) Β· reporter trust (…)”), (b) renders hive self-holds as @hive instead of hive when pill is absent, and (c) drops the !h.by guard. Reuse the helper:

    -        (hold ? ' Β· ' + (hold.pill || 'Held by @' + hold.by) + (hold.reason ? ' Β· ' + hold.reason : '') : '');
    +        (stageTrackerHoldPill(item) ? ' Β· ' + stageTrackerHoldPill(item) : '');
    -            item.hold ? (item.hold.pill || 'Held by @' + item.hold.by) + (item.hold.reason ? ' Β· ' + item.hold.reason : '') : ''].filter(Boolean).join(' Β· ');
    +            stageTrackerHoldPill(item)].filter(Boolean).join(' Β· ');

    2. New CSS hooks on a user-facing aria-label string β€” static-src/css/tracker.css:384-385

    .ham-strip[aria-label="Pipeline progress"] is the first attribute-on-label selector in this stylesheet; every other tracker rule keys on classes. The two-line chevron budget silently stops applying if the label text is ever reworded/localised (tracker-row-layout.js:248). Add a class (e.g. ham-progress) at the emit sites and select .ham-strip.ham-progress instead.

    3. Vestigial classes left behind after their rules were removed β€” tracker-row-layout.js:12 (ham-head-wide), tracker-row-strip.js:179 (ham-has-holder)

    The PR deletes the only CSS for both (ham-head-lead.ham-head-wide { flex: 1 1 0 } and the ham-has-holder nowrap/ellipsis rules), yet the markup still emits them and tests pin them (stage_tracker_ui_rows_test.go:251,523,600; stage_tracker_actor_icon_test.go, stage_tracker_claimant_test.go). Either drop the classes and their assertions, or leave a comment at the emit site saying they are now test-only markers β€” otherwise the next reader assumes a wide lead still exists.

    β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

    @hivecommons-hive

    Copy link
    Copy Markdown
    Contributor

    CI triage (head 7463c73, read-only β€” PR-local, verdict FIX_DIFF)

    The red shards are not a baseline problem: every one of these checks is green on the v5 parent b4fd659 (run for the current v5 tip is still in progress; runtime-tests already passed there). Five distinct assertions fail, all in tests that pin the tracker-strip behaviour this PR rewrites:

    Shard Test What fails
    test (dashboard 2/4) + shuffle 1–3 TestStageTrackerMergeGateNode (stage_tracker_merge_gate_test.go:157) index.html no longer contains the two merge-gate wiring literals the test greps for: if (gateInfo) tip = sg.label + ' β€” ' + gateInfo.tip; and else if (active) inner = gateCue + workIco + (decision ? stageTrackerDecisionTriggerHtml(decision, word, tip) : word) + (actorIco || holderIco);
    same TestStageTrackerSentinelLaneText (stage_tracker_sentinel_lane_test.go:529) node fixture AssertionError: the plain word is replaced, not appended ([stdin]:1747) β€” the compact chevron now appends the sentinel word instead of replacing it
    runtime-tests β†’ build-and-test stage_tracker_header_spans.test.js:95 "spans share the physical lane grid, including independent concurrent CI/Review" computed style is height: auto; where the test expects the lane-grid height match
    test (rest 3/4) tooltip_title_test.go:185 index.html:17633: the new <span class="…config-tooltip…"> sits inside <li title="${esc(fullTip)}">, so the β“˜ shows two tooltips β€” drop the title or set title="" on the trigger
    test (rest 3/4) style_ratchet_test.go:88 operator static/index.html ratchets: style= attributes 1404 > baseline 1403, raw border-radius 175 > baseline 174

    The GET /repos/testorg/testrepo/pulls/8/files / GET /user "unexpected request" lines in the same logs are t.Log noise from passing tests, not failures.

    If the merge-gate literals and the sentinel replace-not-append rule changed on purpose, the two Go tests and the node fixture need updating in the same PR; the tooltip and style-ratchet failures look like straight fixes (one title attribute, one inline style=/border-radius moved into tracker.css).


    🐝 Hive Agent: quality | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    β€” hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

    Exercise production row layouts and decision controls in the existing browser harness, repair coupled expectations without reducing ratchets, and label observed PR source repair Remediating while preserving native state identifiers.
    
    Signed-off-by: Andrew Anderson <andy@clubanderson.com>

    @hivecommons-hive hivecommons-hive Bot left a comment

    Copy link
    Copy Markdown
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Correctness β€” delta re-review at 69a6312 (vs 7463c73)

    Prior findings: merge-gate wiring test β€” fixed (stage_tracker_merge_gate_test.go:149-154 now asserts lines that exist at tracker-row-strip.js:135-136,193-194). Sentinel 085 tooltip repeating the stage word β€” no longer blocking: code unchanged, but stage_tracker_sentinel_lane_test.go:374-375 now documents the tooltip-only context as intended. Redundant gateWord || word (tracker-row-strip.js:193) β€” still present, style only.

    New (low, in-scope): settings-modal preview row loses its header span after the --ham-pr-start move.
    tracker-row-layout.js:12 now emits data-ham-pr-start instead of an inline style, and the CSS var is bound only inside stageTrackerRowNode (tracker-motion.js:661-664). tracker.css:105-106 has no fallback (grid-column: 1 / var(--ham-pr-start)), so any header materialized without stageTrackerRowNode gets an invalid grid-column β†’ auto, collapsing the title lead to a single lane. One such path exists at head: the Movement-animation sample row in the settings dialog β€” tracker-sound.js:728 (stageTrackerSampleRowHtml) is interpolated into the modal body string (tracker-sound.js:563 via setIfChanged) and re-set with sample.innerHTML = … at tracker-sound.js:767. At 7463c73 the inline style kept this correct. Suggested fix (also regenerate static/index.html):

    --- a/src/pkg/dashboard/static-src/js/tracker-motion.js
    +++ b/src/pkg/dashboard/static-src/js/tracker-motion.js
    @@ function stageTrackerRowNode(key, html) {
           node.dataset.hamKey = key;
    -      // Bind canonical lane geometry when materializing root and nested rows.
    -      if (typeof node.querySelectorAll === 'function') {
    -        for (const header of node.querySelectorAll('.ham-head-cols[data-ham-pr-start]')) {
    -          header.style.setProperty('--ham-pr-start', header.dataset.hamPrStart);
    -        }
    -      }
    +      stageTrackerBindHeaderGeometry(node);
           if (_stageTrackerRowSrc) _stageTrackerRowSrc.set(node, stageTrackerRowSrcKey(html));
           return node;
         }
    +    // Bind canonical lane geometry for every header under node (root, nested, or sample rows).
    +    function stageTrackerBindHeaderGeometry(node) {
    +      if (!node || typeof node.querySelectorAll !== 'function') return;
    +      for (const header of node.querySelectorAll('.ham-head-cols[data-ham-pr-start]')) {
    +        header.style.setProperty('--ham-pr-start', header.dataset.hamPrStart);
    +      }
    +    }
    --- a/src/pkg/dashboard/static-src/js/tracker-sound.js
    +++ b/src/pkg/dashboard/static-src/js/tracker-sound.js
    @@ (settings render, ~line 563)
           setIfChanged(body, stageTrackerSettingsHtml({ ... }));
    +      stageTrackerBindHeaderGeometry(body);
    @@ function stageTrackerPreviewMotion(id) {
           sample.innerHTML = stageTrackerSampleRowHtml(toStage, stages);
    +      stageTrackerBindHeaderGeometry(sample);
    

    Rest of the delta checked: stageTrackerOpenDecisionPop fast path (tracker-actions.js:1034-1037) is safe β€” .el is always set when _stageTrackerDecisionPop is non-null (:1055,1089); stageTrackerApplyCodeActivity paused-caption trimming (stage_tracker_activity.go:465-471) matches TestStageTrackerRemediationPausedWordingPreservesEvidence. Browser-only probe assertions (tracker-header-geometry.js:141-148) were not executed here.

    β€” hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

    @hivecommons-hive

    Copy link
    Copy Markdown
    Contributor
    69a6312

    ℹ️ Sentinel notice β€” informational; author is trusted (owner), merge is not blocked

    Hive flagged this PR (author @clubanderson, head 69a6312c3255) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation β€” a maintainer should confirm the change is intended before it merges.

    • sensitive_path β€” changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
      • .github/workflows/dashboard-mobile-shots.yml

    Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

    @github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 3, 2026
    @hivecommons-hive

    Copy link
    Copy Markdown
    Contributor

    CI triage (head 69a6312, read-only β€” PR-local, verdict FIX_DIFF)

    Baseline is clean: test (dashboard 1–4/4), all three dashboard shuffle shards and test are green on the v5 tip 55318dc, so these are PR-local. The failure set moved since the 7463c73 triage β€” merge-gate wiring, tooltip_title_test and the style ratchets now pass; three remain:

    Shard Test What fails
    test (dashboard 3/4) + shuffle 1–2 TestStageTrackerSentinelLaneText (stage_tracker_sentinel_lane_test.go:530) node fixture [stdin]:1754 β€” AssertionError: the plain word is replaced, not appended in visible copy; full context remains in the tooltip. Same finding as before: the compact chevron still appends the sentinel word instead of replacing it.
    test (dashboard 4/4) + shuffle TestStageTrackerRows (stage_tracker_ui_rows_test.go:663) node activity-monitor fixture [stdin]:2272 asserts true, got false on the stage-71 PR row (data-ham-kind="pr" data-ham-repo="acme/console" data-ham-stage="71", "Waiting on the author" / ham-no-issue head) β€” the new ham-head-cols / data-ham-pr-start head-row markup no longer satisfies whatever that fixture greps for on the no-linked-issue row.
    mobile-shots activity browser acceptance tracker-header-geometry, tracker-decision-interaction and native input fail at every mobile viewport (390Γ—844, 375Γ—667, 430Γ—932, 768Γ—1024; light and dark). The PR body lists 390/768 as required published-render widths, so this is the geometry proof the body says is still outstanding.

    coverage / test are the aggregate jobs failing on the shards above, not separate causes. The GET /repos/testorg/testrepo/pulls/8/files lines are t.Log noise from passing tests.

    The branch is also CONFLICTING with v5 (tide: "PR has a merge conflict"), so it needs a rebase before any green run can merge.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

    Signed-off-by: Andrew Anderson <andy@clubanderson.com>
    @kubestellar-prow kubestellar-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2026

    @hivecommons-hive hivecommons-hive Bot left a comment

    Copy link
    Copy Markdown
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Decision needed: @clubanderson should confirm the TRUSTED_SCRIPTS_TREE re-pin in .github/scripts/integration-governance.cjs is intended as part of this layout PR, then rebase onto v5 (the pin must be recomputed to the post-rebase git rev-parse HEAD:src/scripts).

    Conclusion: the Go/JS changes read correct to me; the PR is routed to a human only because it edits two trust-surface files, and it currently conflicts with v5 on exactly one of them.

    Trust-surface facts (verified at head 791ab1f):

    • .github/scripts/integration-governance.cjs:12 β€” TRUSTED_SCRIPTS_TREE changes 9ba1ee4c… β†’ 6c2555e0…. I checked git rev-parse 791ab1f:src/scripts = 6c2555e0d9e809e48a8fb91e98992a2c31a4e679, so the new literal is self-consistent with this PR's own src/scripts/ edits, and the verifier's own error text (integration-governance.cjs:103) requires exactly this re-pin whenever src/scripts changes. It is mechanical, not a policy change β€” but the PR body says "No trust … changed", which is not literally true; worth stating plainly.
    • .github/workflows/dashboard-mobile-shots.yml:12 β€” adds one paths: trigger entry for the new fixture. No permission or job change.

    Rebase needed: v5 has since moved its pin to 25ff55e8…, and git merge-tree v5 pr16454 conflicts only in integration-governance.cjs (static/index.html auto-merges). After rebasing, re-run git rev-parse HEAD:src/scripts and update the literal, or the integration-candidate policy check will refuse the tree.

    Correctness read:

    • stage_tracker_activity.go:465-470 β€” the Blocker derivation now handles both Remediation paused and the legacy Fixing paused prefixes and yields the same Fix task blocked … string as the previous strings.Replace; the caption-replacement guard at :477 was widened to match. No behaviour lost.
    • stage_tracker.go:974 / stage_tracker_caption.go:757 / stage_tracker_fixer.go:42 β€” Fixingβ†’Remediating is consistent across short label, description and paused caption; front-end consumers accept both words (tracker-words-gate.js:23, tracker-row-strip.js:222). The Review Queue label at review-queue.js:220 still says Fixing for the fixing state key β€” a separate surface, not a defect, but noting it in case a single vocabulary was the intent.
    • Regenerated static/index.html is in sync: go run ./pkg/dashboard/webstatic/gen … -check exits 0 at this head.

    I have not approved or changed anything.

    β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

    Signed-off-by: Andrew Anderson <andy@clubanderson.com>
    @kubestellar-prow kubestellar-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2026

    @hivecommons-hive hivecommons-hive Bot left a comment

    Copy link
    Copy Markdown
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    docs-currency (read at head 791ab1f8)

    Operator docs still describe the renamed 070 vocabulary as "Fixing". This PR changes the 070 chevron word and its captions β€” src/pkg/dashboard/stage_tracker.go:974 (stageTrackerShort(Fixing) β†’ "Remediating"), src/pkg/dashboard/stage_tracker_activity.go:419 ("Remediating Β· "+fix.Agent), src/pkg/dashboard/stage_tracker_fixer.go:42 ("Remediation paused β€” …"), tracker-words-core.js (70: 'Remediating'), tracker-words-stage.js ('Remediating CI or review findings', 'being remediated by hive'). Only the new paragraph in src/docs/dashboard-source-layout.md was updated; the existing operator-facing references still teach the old words:

    • src/docs/dashboard-sections/activity-monitor.md:72 β€” legend row | 070 Fixing / 071 Needs author / 072 Returned to contributor |
    • src/docs/dashboard-sections/activity-monitor.md:730 β€” *Fixing Β· hive is addressing @hanthor's review* / 070 *Fixing* for a direction
    • src/docs/dashboard.md:601 β€” 070/071/072/074 light *CI / Review* as "Fixing" / … and 070 "Fixing" (the author's move …)
    • src/docs/labels-and-control-signals/glossary-and-operations.md:194 β€” 070 "Fixing" is the author's move
    • src/docs/review-swarm.md:563 β€” never claims \Fixing Β· @bot`/the caption reads `Fixing paused β€” ; no fix job is dispatched``

    An operator searching the docs for the word now shown on the chevron finds nothing, and the review-swarm contract quotes a caption the code no longer emits. Suggested fixes (the first two are the minimum):

    src/docs/review-swarm.md:563

    - A `070-fixing` row never claims `Remediating Β· @bot` when no fix job is dispatched or running. If the dispatcher excludes the head (attempts exhausted, no enabled fixer, budget), the caption reads `Remediation paused β€” <why>; no fix job is dispatched` (plus `conflicting with the base branch` when the PR is dirty) and the stage actor is *nobody*.
    

    src/docs/dashboard-sections/activity-monitor.md:72

    | 070 Remediating / 071 Needs author / 072 Returned to contributor | CI / Review: Hive repairs its own PR at 070 (the chevron reads *Remediating*; the `stage/070-fixing` label is unchanged); a human author acts at 071; a contributor agent gets its PR back at 072. `needs-rebase` explains a repair here, not at 050. |
    

    In dashboard.md:601, glossary-and-operations.md:194 and activity-monitor.md:730, replace the quoted chevron word "Fixing" / *Fixing* with "Remediating" / *Remediating* (keep 070-fixing / stage/070-fixing label names as-is, per the PR's own note in dashboard-source-layout.md).

    β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

    Signed-off-by: Andrew Anderson <andy@clubanderson.com>
    @hivecommons-hive

    Copy link
    Copy Markdown
    Contributor

    CI triage (head 18b81f4, read-only β€” PR-local, verdict FIX_DIFF)

    The only real red is test (dashboard 4/4) / dashboard shuffle 2/3 β†’ TestStageTrackerRows (stage_tracker_ui_rows_test.go:663, node fixture). The native-queue-policy / Sign-off survives the squash entries are cancelled superseded runs, and both are green on this head.

    Failing assertion (hover-text budget, expectTitles(row, ['a.ham-ref','span.ham-title','li.ham-seg'], 'lone issue')):

    actual:   ['a.ham-ref','span.ham-title','li.ham-seg','span.ham-chevron-info','span.ham-chevron-info','span.ham-chevron-info']
    expected: ['a.ham-ref','span.ham-title','li.ham-seg']
    

    Cause: the new chevron wrapper in src/pkg/dashboard/static-src/js/tracker-row-strip.js emits an empty title="" on the inner span (line 64 activity-track branch and line 197 stage-chevron branch):

    <span class="ham-chevron-info config-info" tabindex="0" title="" aria-label="…" aria-describedby="…">

    The budget test matches / title="/, so every chevron β€” active or not β€” now counts as a titled element. Dropping title="" from both templates (the aria-label + aria-describedby tooltip already carry the text; an empty title suppresses nothing in browsers) and regenerating static/index.html should turn the shard green; the per-chevron title the test expects stays on the <li class="ham-seg active"> as before.

    Not pushing to your branch per the owner's no-push direction; this is comment-only.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

    @hivecommons-hive
    hivecommons-hive Bot merged commit abf91a8 into v5 Nov 3, 2026
    82 of 84 checks passed
    @kubestellar-prow
    kubestellar-prow Bot deleted the fix/activity-header-spans-20261103 branch November 3, 2026 19:12
    @hivecommons-hive

    Copy link
    Copy Markdown
    Contributor

    merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 8f21451.

    @github-actions

    github-actions Bot commented Nov 3, 2026

    Copy link
    Copy Markdown
    Contributor

    Thank you for your contribution! Your PR has been merged.

    We'd love to hear how your experience was: share feedback

    @hivecommons-hive hivecommons-hive Bot left a comment

    Copy link
    Copy Markdown
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    docs-currency β€” delta re-review at 8f21451 (previous head 791ab1f). The delta is almost entirely the v5 reconcile merge (18b81f4) plus the fixture-isolation commit (8f21451); neither touches src/docs/review-swarm.md.

    Still present (in-scope): the operator docs still describe the 070 chevron with the pre-rename wording.

    • src/pkg/dashboard/stage_tracker.go:974 now returns "Remediating" for the 070 word, and src/pkg/dashboard/stage_tracker_fixer.go:42 now emits "Remediation paused β€” <why>; no fix job is dispatched". The changelog fragment (changelog.d/fixed-activity-header-spans.md) advertises the rename.
    • src/docs/review-swarm.md:563 still tells operators the row reads Fixing Β· @bot / Fixing paused β€” <why>; no fix job is dispatched. Someone searching the docs for the caption they see on screen will not find it.

    Suggested fix for src/docs/review-swarm.md:563:

    - A `070-fixing` row never claims `Remediating Β· @bot` when no fix job is dispatched or running. If the dispatcher excludes the head (attempts exhausted, no enabled fixer, budget), the caption reads `Remediation paused β€” <why>; no fix job is dispatched` (plus `conflicting with the base branch` when the PR is dirty) and the stage actor is *nobody*. (Older `Fixing Β· …` / `Fixing paused …` captions from pre-rename sources are still accepted.)
    

    No new docs-currency issues in the delta; src/docs/dashboard-source-layout.md matches the shipped fixtures/probes it describes.

    β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

    hivecommons-hive Bot pushed a commit that referenced this pull request Nov 3, 2026
    … as chevrons (#16464)
    
    Restore content-driven chevron height (one line of caption -> one-line
    chevron, two lines -> two, never more) and centred captions, which #16454
    replaced with a fixed two-line grid row and a flush-left stretched copy box.
    Drop the boxed-card opt-out that #16384 gave the concurrent CI / Review
    lanes so they share the stage chevron clip-path, padding and height, with
    lane state expressed through fill and text colour.
    
    Geometry probe and CSS-contract tests now fail on the previous behaviour;
    density fixture gains a one-line held row.
    
    Signed-off-by: Andrew Anderson <andy@clubanderson.com>
    clubanderson added a commit that referenced this pull request Nov 4, 2026
    …title)
    
    Tracker rows in the Activity Monitor doubled in height after the layout
    restore (#16454) and acceptance stabilisation (#16461):
    
    - the row toolbar (hold / Let hive decide pills) was a separate
      full-width grid line between the title and the chevrons, reading as a
      30-40px blank band; it now trails the PR cell on the title line;
    - chevrons carried a two-line caption budget, sp-2 vertical padding and
      a matching grid-auto-rows floor (24-48px); captions are clamped to one
      line with ellipsis and sp-1 padding (~20px), the pre-#16454 density;
    - the issue title had a max-content flex basis inside a wrapping
      .ham-head-main, so it dropped to its own line whenever it could not
      fit entirely; it now fills the rest of the chip line (flex: 1 1 0)
      and wraps only its own words. The PR ref does the same with a 20em
      floor so pills stay on the first line;
    - row padding sp-5 -> sp-4.
    
    Simple rows measure 59px (was 71-99px) at 1440x1200@1; 16 rows fit in
    the viewport where 8 did. Tests and the tracker-header-geometry probe
    are retargeted to the one-line contract; a node test pins the inline
    title.
    
    Fixes #16485
    
    Signed-off-by: Andrew Anderson <andy@clubanderson.com>
    clubanderson added a commit that referenced this pull request Nov 4, 2026
    …16487)
    
    * πŸ› dashboard: restore compact tracker rows (one-line chevrons, inline title)
    
    Tracker rows in the Activity Monitor doubled in height after the layout
    restore (#16454) and acceptance stabilisation (#16461):
    
    - the row toolbar (hold / Let hive decide pills) was a separate
      full-width grid line between the title and the chevrons, reading as a
      30-40px blank band; it now trails the PR cell on the title line;
    - chevrons carried a two-line caption budget, sp-2 vertical padding and
      a matching grid-auto-rows floor (24-48px); captions are clamped to one
      line with ellipsis and sp-1 padding (~20px), the pre-#16454 density;
    - the issue title had a max-content flex basis inside a wrapping
      .ham-head-main, so it dropped to its own line whenever it could not
      fit entirely; it now fills the rest of the chip line (flex: 1 1 0)
      and wraps only its own words. The PR ref does the same with a 20em
      floor so pills stay on the first line;
    - row padding sp-5 -> sp-4.
    
    Simple rows measure 59px (was 71-99px) at 1440x1200@1; 16 rows fit in
    the viewport where 8 did. Tests and the tracker-header-geometry probe
    are retargeted to the one-line contract; a node test pins the inline
    title.
    
    Fixes #16485
    
    Signed-off-by: Andrew Anderson <andy@clubanderson.com>
    
    * πŸ› dashboard: retarget Go-embedded tracker row fixture to the inline chip cell
    
    TestStageTrackerRows still asserted the pre-PR head markup (a separate
    <li class="ham-seg cap"> toolbar line); the chips now trail the PR
    cell (ham-head-pr / ham-head-tools) on the title line.
    
    Signed-off-by: Andrew Anderson <andy@clubanderson.com>
    
    ---------
    
    Signed-off-by: Andrew Anderson <andy@clubanderson.com>
    clubanderson added a commit that referenced this pull request Nov 4, 2026
    Integrates #16478, #16498 and #16505, which landed on v6 after the merge
    was prepared. tracker.css: kept v5's title-line grid (#16454..#16494,
    which supersedes #16498's flex-only title line and already keeps cap
    pills off the PR title); static/index.html regenerated from static-src.
    
    Signed-off-by: Andrew Anderson <andy@clubanderson.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    1 participant