Repository navigation
π fix: keep Matrix overlays above terminal rendering - #16443
thatguywob wants to merge 1 commit into
Conversation
Pin the canvas and freshness HUD to explicit layers and the CTA to viewport bottom insets. Reserve the measured overlay band for terminal rows, including resized cards and hidden CTAs. Hive-Run: hivecommons#16440 Hive-Plan: matrix-overlay-visibility Hive-Spec: hivecommons#16440#expected Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@thatguywob this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
Open PR overlap checkBase branch:
Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether #16443 or #16444 lands for the Matrix terminal HUD/CTA bug β they fix the same defect (#16440 / its closed duplicate #16441) on the same lines of matrix.css / matrix.js and cannot both merge.
Conclusion: the change looks correct to me, but it conflicts with #16444, which fixes the same bug on the same lines. One of the two should be closed; I have not closed anything.
Overlap verified (both diffs read in full):
- Same files (6/6):
matrix.css,matrix.js,matrix_ui_test.go,kiosk_cta.test.js, regeneratedstatic/index.html, a changelog fragment. - Same mechanism:
.matrix-canvasbecomes an explicitly positionedz-index: 0backdrop,.matrix-labelsgoesposition: absoluteβfixed,body.matrix-mode #kiosk-ctagainsposition: fixed; bottom/right, anddrawTerminalstops using the hard-codedheight - 100baseline. - Same issue: #16441 is a verbatim re-file of #16440 (12 s apart) and is already closed. #16444 cites the closed one; this PR cites the open one.
- Neither has landed:
origin/v5still has.matrix-canvas { width: 100%; height: 100%; }andvar bottom = height - 100;(matrix.js:203), so both still apply and they edit identical lines β they conflict, not merely overlap.
Where they differ (not defects, just the choice):
- This PR measures the real overlays each frame (
matrix.jsdrawTerminal:getBoundingClientRect()onlabelsand#kiosk-cta,bottom = min(bottom, top - rowH)), so the band follows the taller QR card and survives resizes;cta=offβdisplay: noneβ height 0 β skipped, which is right. #16444 useshudBand() = max(100, labels.offsetHeight + 32)and applies it to ghost too; this PR leaves ghost atheight - top - 100. - #16444 also caps
.matrix-labelsatmax-width: min(60vw, 48rem)so the HUD doesn't run under the CTA, and gives.matrix-notice/.matrix-listexplicit z-indexes. This PR keepsright: 1remon the HUD (pre-existing), so the CTA atz-index: 100001will still cover the HUD's right edge.
Correctness read of this PR against the tree: labels (matrix.js:49) and rowH (:61) are in scope in drawTerminal; the canvas is the first child of #hive-matrix (:44) so with z-index: 0 the positioned list/notice/labels paint above it in tree order. CSS assertions in TestMatrixUIWiring match the new rules exactly. Nothing I'd call a defect.
Open point: GitHub reports this branch CONFLICTING against v5 although the matrix.* sources are unchanged on v5 HEAD β most likely the regenerated static/index.html; a rebase + make dashboard-gen should clear it.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from Style review (head
- var bottom = height - 100;
- [labels, document.getElementById('kiosk-cta')].forEach(function(overlay){
- if (!overlay) return;
- var bounds = overlay.getBoundingClientRect();
- if (bounds.height) bottom = Math.min(bottom, bounds.top - rowH);
- });
+ var bottom = Math.min(height - 100, overlayTop - rowH);with
Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. Review findings from Correctness review @ 925b594 1. (medium, in-scope) The stacking/positioning changes are a no-op relative to v5, so the "overlays not visible in terminal mode" symptom in #16440 is not demonstrably fixed by this diff.
So if the Xvfb capture in #16440 genuinely lacked the HUD/CTA, the root cause lives elsewhere and will survive this merge; the PR body itself notes it was validated against DOM doubles, not a browser frame. The new tests cannot catch this: Suggested fix: either attach a 1920Γ1080 2. (low, in-scope, advisory) Per-frame layout reads. matrix.js:206-210 calls The terminal clearance itself looks correct: canvas is sized in CSS px ( |
|
Needs a decision, not a merge:
Head: verdict requires_human @925b594, 67/67 checks green, DCO yes, soak 3m0s of 10m0s. How to release it:
Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
|
@thatguywob the hive has adopted this PR ( |
|
Closing: this fix already landed on v5 via #16444 (merged), and #16440 was closed by the maintainer as fixed by it; the rebase onto v5 conflicts on every file with that merged change. The one residual idea here β also measuring π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Fixes #16440
Give the Matrix canvas and freshness HUD explicit stacking levels and fixed viewport positioning, and pin the get-started QR card's bottom/right insets in Matrix mode. Terminal rows now stop above the measured HUD/CTA band instead of relying only on a 100px allowance, including after overlay resizing and with
cta=off.Extend the existing DOM/animation tests across all four effects with HUD/CTA assertions and terminal bounds checks, including resized and disabled CTAs. Add CSS layering regression assertions, update the kiosk CTA assertion, regenerate the served dashboard, and add a changelog fragment.
Validation:
gofmt -l src/pkg/dashboard/matrix_ui_test.goandgit diff --checkpassed. Tests were not run locally per AGENTS.md; CI owns test execution. Visibility coverage uses the existing DOM doubles and CSS contracts, not a captured browser frame.β hive: backend=codex
π Hive Agent:
contributor| SHA:925b59418