Skip to content

πŸ› Stabilize activity monitor browser acceptance - #16461

Merged
hivecommons-hive[bot] merged 2 commits into
v5from
fix/activity-browser-readiness-20261103
Nov 3, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
v5from
fix/activity-browser-readiness-20261103

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Follow-up to #16454, which already merged the activity-monitor UI fixes.

This changes the canonical screenshot harness only: wait for computed render readiness with a bounded timeout, dismiss preceding fixture overlays through the native policy, and preserve strict geometry, native-input, hit-test, and pixel assertions. Added behavior tests cover readiness, cleanup, and failure paths.

Runtime UI source and generated assets are unchanged (generated asset SHA-256: 5877eb2a1bedd2925b15404797cee5784e3ba882accc7bd8c67e79db61968527). Fresh canonical CI and actual browser artifacts are required; inspection is not an acceptance claim.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@clubanderson clubanderson added the no-changelog No changelog fragment required label Nov 3, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Changelog: this PR changes code but carries no changelog entry
(no changelog.d/ fragment and no CHANGELOG.md edit).

If it is user-visible β€” a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking β€”
please add a fragment file changelog.d/<category>-<pr-or-slug>.md
containing exactly your entry (see changelog.d/README.md; the
category is one of added/changed/deprecated/fixed/security). Please
do not append to CHANGELOG.md's ## Unreleased directly β€” that
shared section is the merge-conflict generator fragments replaced
(#5675). If it is a refactor, a test-only change, or dependency
churn, no entry is needed and you can ignore this.

This is a reminder, not a gate; it never blocks a merge.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the harness, the new fixture module, and the dashboard code it calls at a706bfc. Looks correct to me; nothing blocking.

What I verified against the tree (not the body):

  • hiveDismissTopOverlay / hiveOverlayIsOpen are top-level declarations in the main classic <script> (static-src/js/config-dialog.js:92,125, included via manifest.txt:129 after glue/main-script-open.html), so they are reachable as globals from Runtime.evaluate. The harness's evaluate already passes awaitPromise: true (dashboard-mobile-shots.mjs:299), so the now-async resetJS resolves rather than returning a pending Promise.
  • The dismissal loop terminates: every closer hiveDismissTopOverlay selects for the three owned producers hides synchronously β€” hiveDialogClose β†’ overlay.remove() (tooltips-dialogs.js:431-438), kbCloseModal β†’ style.display='none' (knowledge.js:1414), closeConfigDialog β†’ classList.add('hidden') (config-dialog.js:62) β€” so the next iteration sees them closed and maxDismissals is only a safety bound.
  • Waiting one requestAnimationFrame for the scroll lock is sufficient: the modal-open toggle is driven by a MutationObserver on class/style (layout.js:292-320), which fires as a microtask before the next frame.
  • TRUSTED_SCRIPTS_TREE re-pin in .github/scripts/integration-governance.cjs:12: git rev-parse a706bfc:src/scripts = aa20dad4…, matching the literal; integration-governance.test.cjs:71 passes. This is the mechanical re-pin the file's own error message demands for any src/scripts edit, not a change to permissions or rules.
  • node --test src/pkg/dashboard/stage_tracker_activity.test.js: 30/30 pass, including the four new readiness/cleanup tests. The one failing case in integration-governance.test.cjs ("Generated merge lacks its own actual author signoff") fails identically on origin/v5, so it is pre-existing and unrelated.

Agree with the body that this is not browser-level acceptance; the canonical CI artifacts are still the proof.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit b80e424 into v5 Nov 3, 2026
83 of 84 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/activity-browser-readiness-20261103 branch November 3, 2026 19:49
@hivecommons-hive

hivecommons-hive Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#16461a706bfc` sha256:471ba40912ddf890fff7ef750efba2626624babde0e75c37945e731009124a73 β€” download from the dashboard or `hivectl review evidence #16461`.

Review findings from reviewer-2 (folded here because this head already carries its hive review):

Looks correct to me. Read at a706bfc against the v5 tree; harness-only change as stated, and the mechanisms it leans on exist and behave as the new helper assumes.

Verified

  • hiveDismissTopOverlay / hiveOverlayIsOpen are real page globals (src/pkg/dashboard/static-src/js/config-dialog.js:92,125). The dismissal list natively covers exactly the three producers in the helper's ownedSelector: #config-overlay β†’ closeConfigDialog (:161), #kb-modal-overlay β†’ kbCloseModal (:169), .hive-dialog-overlay β†’ el.hiveDialogClose() (:157). It returns false only when nothing is open, so the maxDismissals loop terminates on a clean page.
  • resetJS becoming an async IIFE and renderReady() returning a Promise both depend on the CDP wrapper awaiting promises β€” it does (src/scripts/dashboard-mobile-shots.mjs:299, awaitPromise: true), so a rejected cleanup/readiness fails the state instead of serializing to {}.
  • The .github/scripts/integration-governance.cjs edit is the mechanical re-pin the gate itself demands (:103): the new literal aa20dad4… equals git rev-parse a706bfc:src/scripts, and the old literal 55bc8023… equals origin/v5:src/scripts. Nothing else in .github/ changes.
  • node --test pkg/dashboard/stage_tracker_activity.test.js β†’ 30 pass, 0 fail.

One open question, not a defect (docs-currency, low)

src/docs/dashboard-source-layout.md now says the file-page "cannot receive the status refresh that normally reveals the body before its boot fallback". I could not find a boot fade in the tree: <body> carries no inline opacity (static/index.html:7055), no CSS rule sets body/html opacity, and the only writer is the guard at static-src/js/refresh.js:486, which fires only if opacity is already '0'. waitForDashboardPaint is harmless either way (opacity is '1' from first paint, so it just waits for two stable frames), but if there is no fade-in the sentence describes a mechanism that doesn't exist β€” worth a one-line trim, or a pointer to where the body starts hidden if I missed it.

mobile-shots was still in progress when I read; I did not wait on it.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at a706bfc.

clubanderson added a commit that referenced this pull request Nov 4, 2026
…title)

Tracker rows in the Activity Monitor doubled in height after the layout
restore (#16454) and acceptance stabilisation (#16461):

- the row toolbar (hold / Let hive decide pills) was a separate
  full-width grid line between the title and the chevrons, reading as a
  30-40px blank band; it now trails the PR cell on the title line;
- chevrons carried a two-line caption budget, sp-2 vertical padding and
  a matching grid-auto-rows floor (24-48px); captions are clamped to one
  line with ellipsis and sp-1 padding (~20px), the pre-#16454 density;
- the issue title had a max-content flex basis inside a wrapping
  .ham-head-main, so it dropped to its own line whenever it could not
  fit entirely; it now fills the rest of the chip line (flex: 1 1 0)
  and wraps only its own words. The PR ref does the same with a 20em
  floor so pills stay on the first line;
- row padding sp-5 -> sp-4.

Simple rows measure 59px (was 71-99px) at 1440x1200@1; 16 rows fit in
the viewport where 8 did. Tests and the tracker-header-geometry probe
are retargeted to the one-line contract; a node test pins the inline
title.

Fixes #16485

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
clubanderson added a commit that referenced this pull request Nov 4, 2026
…16487)

* πŸ› dashboard: restore compact tracker rows (one-line chevrons, inline title)

Tracker rows in the Activity Monitor doubled in height after the layout
restore (#16454) and acceptance stabilisation (#16461):

- the row toolbar (hold / Let hive decide pills) was a separate
  full-width grid line between the title and the chevrons, reading as a
  30-40px blank band; it now trails the PR cell on the title line;
- chevrons carried a two-line caption budget, sp-2 vertical padding and
  a matching grid-auto-rows floor (24-48px); captions are clamped to one
  line with ellipsis and sp-1 padding (~20px), the pre-#16454 density;
- the issue title had a max-content flex basis inside a wrapping
  .ham-head-main, so it dropped to its own line whenever it could not
  fit entirely; it now fills the rest of the chip line (flex: 1 1 0)
  and wraps only its own words. The PR ref does the same with a 20em
  floor so pills stay on the first line;
- row padding sp-5 -> sp-4.

Simple rows measure 59px (was 71-99px) at 1440x1200@1; 16 rows fit in
the viewport where 8 did. Tests and the tracker-header-geometry probe
are retargeted to the one-line contract; a node test pins the inline
title.

Fixes #16485

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ› dashboard: retarget Go-embedded tracker row fixture to the inline chip cell

TestStageTrackerRows still asserted the pre-PR head markup (a separate
<li class="ham-seg cap"> toolbar line); the chips now trail the PR
cell (ham-head-pr / ham-head-tools) on the title line.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. no-changelog No changelog fragment required size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant