Repository navigation
π Stabilize activity monitor browser acceptance - #16461
Conversation
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Changelog: this PR changes code but carries no changelog entry If it is user-visible β a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
There was a problem hiding this comment.
Read the harness, the new fixture module, and the dashboard code it calls at a706bfc. Looks correct to me; nothing blocking.
What I verified against the tree (not the body):
hiveDismissTopOverlay/hiveOverlayIsOpenare top-level declarations in the main classic<script>(static-src/js/config-dialog.js:92,125, included viamanifest.txt:129afterglue/main-script-open.html), so they are reachable as globals fromRuntime.evaluate. The harness'sevaluatealready passesawaitPromise: true(dashboard-mobile-shots.mjs:299), so the now-asyncresetJSresolves rather than returning a pending Promise.- The dismissal loop terminates: every closer
hiveDismissTopOverlayselects for the three owned producers hides synchronously βhiveDialogClose β overlay.remove()(tooltips-dialogs.js:431-438),kbCloseModal β style.display='none'(knowledge.js:1414),closeConfigDialog β classList.add('hidden')(config-dialog.js:62) β so the next iteration sees them closed andmaxDismissalsis only a safety bound. - Waiting one
requestAnimationFramefor the scroll lock is sufficient: themodal-opentoggle is driven by aMutationObserveronclass/style(layout.js:292-320), which fires as a microtask before the next frame. TRUSTED_SCRIPTS_TREEre-pin in.github/scripts/integration-governance.cjs:12:git rev-parse a706bfc:src/scripts=aa20dad4β¦, matching the literal;integration-governance.test.cjs:71passes. This is the mechanical re-pin the file's own error message demands for anysrc/scriptsedit, not a change to permissions or rules.node --test src/pkg/dashboard/stage_tracker_activity.test.js: 30/30 pass, including the four new readiness/cleanup tests. The one failing case inintegration-governance.test.cjs("Generated merge lacks its own actual author signoff") fails identically onorigin/v5, so it is pre-existing and unrelated.
Agree with the body that this is not browser-level acceptance; the canonical CI artifacts are still the proof.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Evidence bundle `#16461a706bfc` sha256:471ba40912ddf890fff7ef750efba2626624babde0e75c37945e731009124a73 β download from the dashboard or `hivectl review evidence #16461`.Review findings from Looks correct to me. Read at Verified
One open question, not a defect (docs-currency, low)
|
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at a706bfc. |
β¦title) Tracker rows in the Activity Monitor doubled in height after the layout restore (#16454) and acceptance stabilisation (#16461): - the row toolbar (hold / Let hive decide pills) was a separate full-width grid line between the title and the chevrons, reading as a 30-40px blank band; it now trails the PR cell on the title line; - chevrons carried a two-line caption budget, sp-2 vertical padding and a matching grid-auto-rows floor (24-48px); captions are clamped to one line with ellipsis and sp-1 padding (~20px), the pre-#16454 density; - the issue title had a max-content flex basis inside a wrapping .ham-head-main, so it dropped to its own line whenever it could not fit entirely; it now fills the rest of the chip line (flex: 1 1 0) and wraps only its own words. The PR ref does the same with a 20em floor so pills stay on the first line; - row padding sp-5 -> sp-4. Simple rows measure 59px (was 71-99px) at 1440x1200@1; 16 rows fit in the viewport where 8 did. Tests and the tracker-header-geometry probe are retargeted to the one-line contract; a node test pins the inline title. Fixes #16485 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
β¦16487) * π dashboard: restore compact tracker rows (one-line chevrons, inline title) Tracker rows in the Activity Monitor doubled in height after the layout restore (#16454) and acceptance stabilisation (#16461): - the row toolbar (hold / Let hive decide pills) was a separate full-width grid line between the title and the chevrons, reading as a 30-40px blank band; it now trails the PR cell on the title line; - chevrons carried a two-line caption budget, sp-2 vertical padding and a matching grid-auto-rows floor (24-48px); captions are clamped to one line with ellipsis and sp-1 padding (~20px), the pre-#16454 density; - the issue title had a max-content flex basis inside a wrapping .ham-head-main, so it dropped to its own line whenever it could not fit entirely; it now fills the rest of the chip line (flex: 1 1 0) and wraps only its own words. The PR ref does the same with a 20em floor so pills stay on the first line; - row padding sp-5 -> sp-4. Simple rows measure 59px (was 71-99px) at 1440x1200@1; 16 rows fit in the viewport where 8 did. Tests and the tracker-header-geometry probe are retargeted to the one-line contract; a node test pins the inline title. Fixes #16485 Signed-off-by: Andrew Anderson <andy@clubanderson.com> * π dashboard: retarget Go-embedded tracker row fixture to the inline chip cell TestStageTrackerRows still asserted the pre-PR head markup (a separate <li class="ham-seg cap"> toolbar line); the chips now trail the PR cell (ham-head-pr / ham-head-tools) on the title line. Signed-off-by: Andrew Anderson <andy@clubanderson.com> --------- Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Follow-up to #16454, which already merged the activity-monitor UI fixes.
This changes the canonical screenshot harness only: wait for computed render readiness with a bounded timeout, dismiss preceding fixture overlays through the native policy, and preserve strict geometry, native-input, hit-test, and pixel assertions. Added behavior tests cover readiness, cleanup, and failure paths.
Runtime UI source and generated assets are unchanged (generated asset SHA-256: 5877eb2a1bedd2925b15404797cee5784e3ba882accc7bd8c67e79db61968527). Fresh canonical CI and actual browser artifacts are required; inspection is not an acceptance claim.