Repository navigation
π Size activity chevrons to their captions and render CI/Review lanes as chevrons - #16464
Conversation
β¦ as chevrons Restore content-driven chevron height (one line of caption -> one-line chevron, two lines -> two, never more) and centred captions, which #16454 replaced with a fixed two-line grid row and a flush-left stretched copy box. Drop the boxed-card opt-out that #16384 gave the concurrent CI / Review lanes so they share the stage chevron clip-path, padding and height, with lane state expressed through fill and text colour. Geometry probe and CSS-contract tests now fail on the previous behaviour; density fixture gains a one-line held row. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Evidence bundle `#164642f832b7` sha256:030408ded57a7dccd99bd2077ba12cf82a1b9462f05092ac738569adfb06f2a7 β download from the dashboard or `hivectl review evidence #16464`.Review findings from Correctness review (head 2f832b7) β the CSS/markup contract holds: lane known-state copy is already inside
.ham-seg.ham-activity-track[data-activity-state="failing"], .ham-seg.ham-activity-track[data-activity-state="changes_requested"] { background: color-mix(in srgb, var(--amber) 18%, var(--panel)); color: var(--amber); box-shadow: none; opacity: 1; }
+ /* Fresh observed work still outranks a finding: a red check with
+ others running keeps the lit .active fill. */
+ .ham-seg.active.ham-activity-track[data-activity-state="failing"] { background: var(--amber); color: var(--surface-0); }
...
- media (prefers-reduced-motion: reduce) { .ham-seg.active { animation: none; box-shadow: inset 0 0 0 2px var(--surface-0); } .ham-seg.active[data-motion]::before { display: none; } .ham-seg.active[data-motion="needs-human"] { background: color-mix(in srgb, var(--amber) 45%, var(--red)); } }
+ media (prefers-reduced-motion: reduce) { .ham-seg.active, .ham-seg.active.ham-activity-track[data-activity-state="failing"] { animation: none; box-shadow: inset 0 0 0 2px var(--surface-0); } .ham-seg.active[data-motion]::before { display: none; } .ham-seg.active[data-motion="needs-human"] { background: color-mix(in srgb, var(--amber) 45%, var(--red)); } }
|
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 2f832b7. |
There was a problem hiding this comment.
Read the stylesheet at the PR head against tracker-row-strip.js and stage_tracker_activity.go; this looks correct to me, with one low-severity behaviour shift worth a conscious yes/no.
Verified
- Dropping
white-space: normalfrom.ham-activity-trackis safe: the known-state caption is rendered inside.ham-chevron-copy(static-src/js/tracker-row-strip.js:62), which keepswhite-space: normal; the unknown state is icon-only, so.ham-seg { white-space: nowrap }never bites. grid-auto-rows: minmax(one-line, auto)+align-self: stretchon.ham-seg(tracker.css:397-398) does what the body says β.ham-segis alreadydisplay:flex; align-items:center(tracker.css:320), so vertical centring of a one-line caption in a two-line row comes for free.TRUSTED_SCRIPTS_TREEre-pin is the mechanical one the gate demands: old literalaa20dadβ¦=src/scriptstree at merge-baseb80e424, new literal68aa6a3β¦=git rev-parse 2f832b7:src/scripts. Onlyfixtures/dashboard-activity-density.mjschanged under that tree.- Markup/ARIA/
data-*unchanged as claimed βtracker-row-strip.jsis not in the diff.
One behaviour shift (low) β tracker.css:360
The new .ham-seg.ham-activity-track[data-activity-state="failing"], β¦[data-activity-state="changes_requested"] rule is (0,3,0) and sits after .ham-seg.active (0,2,0, tracker.css:350), so it now outranks the lit .active fill, not just the .ham-current tint. At base the failing rule was (0,2,0) and earlier than .ham-seg.active, so an active-failing lane was lit amber.
That combination is real: stage_tracker_activity.go:120 ranks failing highest, and :149 sets Active = running && fresh, so "CI failing Β· X Β· others running" yields class="β¦ active" data-activity-state="failing". After this PR that lane shows the 18% tint with amber text (the [data-motion="active"]::before pulse still runs over it). If "a finding outranks the lit fill too" is intended, fine β the comment at :357-359 only mentions outranking the current-phase tint, so a word there (or in dashboard-source-layout.md) would make it deliberate rather than incidental. Not a blocker.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Rows are now only as tall as their longest caption (#16464), so the browser geometry probe's requirement that each lane keep the same height across rows contradicted the shipped contract and failed every viewport in the reporting-only screenshot workflow. Within-row uniformity and the content-driven height check remain. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
What
Follow-up to #16454 / #16384 on the activity monitor stage strip.
grid-auto-rowsto a fixed two-line box and set.ham-seg { height: 100% }, so single-line captions such as "βΈ Open Β· hold" sat in a chevron twice as tall as needed. The grid row now usesminmax(one-line, auto)so sibling icon-only cells still stretch to the row's tallest chevron..ham-chevron-copyhadflex: 1 1 auto, stretching a start-aligned text box across the chevron and leaving the words flush-left. It now shrink-wraps (flex: 0 1 auto; text-align: center), so a wrapped second line is centred under the first.clip-path: none; border; border-radius). They now inherit the.ham-segnotched polygon, padding and height; lane state (current, failing, changes requested, active) reads through fill tint and text colour like every other stage. Markup, icons, captions, tooltips, ARIA anddata-*attributes are unchanged.Tests
tracker-header-geometry.js(canonical browser probe): row height β max(one-line floor, lines Γ line-height + padding) Β±1px; glyphs centred in the copy and copy centred in the chevron; every[data-track]cell matches a sibling chevron's clip-path, padding, border and height; coverage requires at least one one-line and one two-line row.stage_tracker_header_spans.test.js/stage_tracker_activity.test.js: CSS-contract assertions that fail on the previous stylesheet.Scripts tree re-pinned in
integration-governance.cjs. Canonical CI and the dashboard screenshot workflow are the verdict; nothing was verified locally per AGENTS.md.