Skip to content

πŸ› Size activity chevrons to their captions and render CI/Review lanes as chevrons - #16464

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
fix/activity-chevron-height-20261103
Nov 3, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
fix/activity-chevron-height-20261103

Conversation

@clubanderson

Copy link
Copy Markdown
Member

What

Follow-up to #16454 / #16384 on the activity monitor stage strip.

  • Chevron height is content-driven again. One line of caption β†’ a one-line chevron; two lines β†’ two; never more (the 2-line clamp stays). πŸ› Restore activity monitor layout and compact chevronsΒ #16454 had pinned grid-auto-rows to a fixed two-line box and set .ham-seg { height: 100% }, so single-line captions such as "⏸ Open Β· hold" sat in a chevron twice as tall as needed. The grid row now uses minmax(one-line, auto) so sibling icon-only cells still stretch to the row's tallest chevron.
  • Captions are centred. .ham-chevron-copy had flex: 1 1 auto, stretching a start-aligned text box across the chevron and leaving the words flush-left. It now shrink-wraps (flex: 0 1 auto; text-align: center), so a wrapped second line is centred under the first.
  • CI / Review / Merge-queue lanes are chevrons. ✨ Show concurrent CI and Review lanes with evidence-based FixingΒ #16384 introduced them as bordered rounded cards (clip-path: none; border; border-radius). They now inherit the .ham-seg notched polygon, padding and height; lane state (current, failing, changes requested, active) reads through fill tint and text colour like every other stage. Markup, icons, captions, tooltips, ARIA and data-* attributes are unchanged.

Tests

  • tracker-header-geometry.js (canonical browser probe): row height β‰ˆ max(one-line floor, lines Γ— line-height + padding) Β±1px; glyphs centred in the copy and copy centred in the chevron; every [data-track] cell matches a sibling chevron's clip-path, padding, border and height; coverage requires at least one one-line and one two-line row.
  • stage_tracker_header_spans.test.js / stage_tracker_activity.test.js: CSS-contract assertions that fail on the previous stylesheet.
  • Density fixture gains a one-line held row (release: v5.61.0Β #9009); CI/Review lanes were already present.

Scripts tree re-pinned in integration-governance.cjs. Canonical CI and the dashboard screenshot workflow are the verdict; nothing was verified locally per AGENTS.md.

… as chevrons

Restore content-driven chevron height (one line of caption -> one-line
chevron, two lines -> two, never more) and centred captions, which #16454
replaced with a fixed two-line grid row and a flush-left stretched copy box.
Drop the boxed-card opt-out that #16384 gave the concurrent CI / Review
lanes so they share the stage chevron clip-path, padding and height, with
lane state expressed through fill and text colour.

Geometry probe and CSS-contract tests now fail on the previous behaviour;
density fixture gains a one-line held row.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 3, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive
hivecommons-hive Bot merged commit 6a6d1d3 into v5 Nov 3, 2026
85 of 89 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/activity-chevron-height-20261103 branch November 3, 2026 20:42
@hivecommons-hive

hivecommons-hive Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#164642f832b7` sha256:030408ded57a7dccd99bd2077ba12cf82a1b9462f05092ac738569adfb06f2a7 β€” download from the dashboard or `hivectl review evidence #16464`.

Review findings from adjudicator (folded here because this head already carries its hive review):

Correctness review (head 2f832b7) β€” the CSS/markup contract holds: lane known-state copy is already inside .ham-chevron-copy (static-src/js/tracker-row-strip.js:62), so dropping white-space: normal with the .ham-activity-track card rule is safe, and the src/scripts tree re-pin resolves to 68aa6a3… at this head. One in-scope cascade regression and one test gap:

  1. failing + .active CI lane loses its lit/active cue (static-src/css/tracker.css:360). The backend emits state="failing" with Active=true when one required check is red and another is still running (stage_tracker_activity.go:116,149-151, caption "… Β· others running"). The new selector is specificity (0,3,0) and outranks .ham-seg.active (0,2,0, tracker.css:350), so that lane now renders the muted 18% tint with amber text instead of the amber .active fill. Under prefers-reduced-motion it is worse: the ::before pulse is hidden and the rule's box-shadow: none also beats the reduced-motion ring at tracker.css:768, leaving no active indication at all β€” indistinguishable from a plain failing lane. Before this PR the old (0,2,0) rule only touched border-color/color and .ham-seg.active still won. Suggested fix (apply to static-src/css/tracker.css and the compiled static/index.html):
     .ham-seg.ham-activity-track[data-activity-state="failing"], .ham-seg.ham-activity-track[data-activity-state="changes_requested"] { background: color-mix(in srgb, var(--amber) 18%, var(--panel)); color: var(--amber); box-shadow: none; opacity: 1; }
+    /* Fresh observed work still outranks a finding: a red check with
+       others running keeps the lit .active fill. */
+    .ham-seg.active.ham-activity-track[data-activity-state="failing"] { background: var(--amber); color: var(--surface-0); }
...
-    media (prefers-reduced-motion: reduce) { .ham-seg.active { animation: none; box-shadow: inset 0 0 0 2px var(--surface-0); } .ham-seg.active[data-motion]::before { display: none; } .ham-seg.active[data-motion="needs-human"] { background: color-mix(in srgb, var(--amber) 45%, var(--red)); } }
+    media (prefers-reduced-motion: reduce) { .ham-seg.active, .ham-seg.active.ham-activity-track[data-activity-state="failing"] { animation: none; box-shadow: inset 0 0 0 2px var(--surface-0); } .ham-seg.active[data-motion]::before { display: none; } .ham-seg.active[data-motion="needs-human"] { background: color-mix(in srgb, var(--amber) 45%, var(--red)); } }
  1. Test gap (stage_tracker_activity.test.js:553): the "no clip-path/border/inset ring on lane rules" loop uses /\.ham-(?:seg\.)?ham-activity-track[^{]*\{[^}]*\}/g, which only matches selectors beginning .ham-seg.ham-activity-track; the two .ham-activity-track.ham-current… blocks at tracker.css:355-356 are never inspected, so a border reintroduced there would pass.
  for (const block of css.match(/\.(?:ham-seg\.)?ham-activity-track[^{]*\{[^}]*\}/g)) {

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 2f832b7.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the stylesheet at the PR head against tracker-row-strip.js and stage_tracker_activity.go; this looks correct to me, with one low-severity behaviour shift worth a conscious yes/no.

Verified

  • Dropping white-space: normal from .ham-activity-track is safe: the known-state caption is rendered inside .ham-chevron-copy (static-src/js/tracker-row-strip.js:62), which keeps white-space: normal; the unknown state is icon-only, so .ham-seg { white-space: nowrap } never bites.
  • grid-auto-rows: minmax(one-line, auto) + align-self: stretch on .ham-seg (tracker.css:397-398) does what the body says β€” .ham-seg is already display:flex; align-items:center (tracker.css:320), so vertical centring of a one-line caption in a two-line row comes for free.
  • TRUSTED_SCRIPTS_TREE re-pin is the mechanical one the gate demands: old literal aa20dad… = src/scripts tree at merge-base b80e424, new literal 68aa6a3… = git rev-parse 2f832b7:src/scripts. Only fixtures/dashboard-activity-density.mjs changed under that tree.
  • Markup/ARIA/data-* unchanged as claimed β€” tracker-row-strip.js is not in the diff.

One behaviour shift (low) β€” tracker.css:360

The new .ham-seg.ham-activity-track[data-activity-state="failing"], …[data-activity-state="changes_requested"] rule is (0,3,0) and sits after .ham-seg.active (0,2,0, tracker.css:350), so it now outranks the lit .active fill, not just the .ham-current tint. At base the failing rule was (0,2,0) and earlier than .ham-seg.active, so an active-failing lane was lit amber.

That combination is real: stage_tracker_activity.go:120 ranks failing highest, and :149 sets Active = running && fresh, so "CI failing Β· X Β· others running" yields class="… active" data-activity-state="failing". After this PR that lane shows the 18% tint with amber text (the [data-motion="active"]::before pulse still runs over it). If "a finding outranks the lit fill too" is intended, fine β€” the comment at :357-359 only mentions outranking the current-phase tint, so a word there (or in dashboard-source-layout.md) would make it deliberate rather than incidental. Not a blocker.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

hivecommons-hive Bot pushed a commit that referenced this pull request Nov 3, 2026
Rows are now only as tall as their longest caption (#16464), so the
browser geometry probe's requirement that each lane keep the same height
across rows contradicted the shipped contract and failed every viewport
in the reporting-only screenshot workflow. Within-row uniformity and the
content-driven height check remain.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant