Repository navigation
π dashboard: keep activity title-line pills off the PR title - #16498
Merged
hivecommons-hive[bot] merged 1 commit intoNov 4, 2026
Merged
Conversation
The chevron-strip grid rule from hivecommons#16384, `.ham-strip:not(.ham-head-cols)`, also matched the title line: `ham-head-cols` is a class on the strip's row, not on the strip. The title line's lead / PR / cap cells landed in the first three chevron-wide grid columns, and cap pills wider than one column (`train Β· joins behind #N next pass`, `stage β`) right-aligned out of the cap cell and drew over the PR title and base pill. Spell the exclusion on the row so only the chevron strips and the column header are grids; the title line goes back to its flex sizing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1 Signed-off-by: Danathar <Danathar@users.noreply.github.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
There was a problem hiding this comment.
Read the v6 tree at bc48887 to check the selector change rather than the diff alone β it holds.
ham-head-colsis placed on the row, not the strip (src/pkg/dashboard/static-src/js/tracker-row-layout.js:11:<div class="ham-strip-row ham-head-cols"><ol class="ham-strip">), so the old.ham-strip:not(.ham-head-cols)indeed matched every strip including the title line.- Every
.ham-stripthe dashboard renders is a direct child of a.ham-strip-rowβ column header (tracker-row-strip.js:15), per-row strip (tracker-row-render.js:169-171), sub-row strip (tracker-row-layout.js:248-250), head columns (tracker-row-layout.js:11). The new.ham-strip-row:not(.ham-head-cols) > .ham-striptherefore keeps the grid on exactly the chevron strips and drops it only from the title line. No Go or JS test pins the old selector string. static/index.htmlcarries the identical hunk, so the generated copy stays in sync.
Looks correct to me as the minimal v6 fix until #16454 syncs.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Contributor
Contributor
clubanderson
added a commit
that referenced
this pull request
Nov 4, 2026
Integrates #16478, #16498 and #16505, which landed on v6 after the merge was prepared. tracker.css: kept v5's title-line grid (#16454..#16494, which supersedes #16498's flex-only title line and already keeps cap pills off the PR title); static/index.html regenerated from static-src. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
On the activity monitor, the pills on a row's title line (
train Β· joins behind #61 next pass,stage β, the base-branch pill) no longer sit on top of the PR title. The title line goes back to its intended layout: the issue spans Open..Claimed, the PR starts at PR in progress, and the pills sit at the right end.Why
#16384 added this grid rule for the chevron strips:
ham-head-colsis a class on the strip's row (<div class="ham-strip-row ham-head-cols"><ol class="ham-strip">), not on the strip. So the:not()never excluded anything, and the title line became a grid too. Its three cells (lead, PR, pills) landed in the first three chevron-wide columns. The pills are wider than one column and are right-aligned, so they spilled left over the PR title. This is the overlap seen live on the projectbluefin hive (buildbc48887, which is v6 HEAD).How it works now
The exclusion is written on the row, so only the chevron strips and the column header are grids:
Every
.ham-stripthe dashboard renders sits directly inside a.ham-strip-row: the column header, each row's strip, and each sub-row's strip. So all of them keep the grid. The title line goes back to the flex sizing its rules already describe.Measured (headless Chrome, 1470px, real generated CSS)
Before, the 243px pills started at x=515, inside the PR cell (481β618). After, nothing overlaps.
Note on v5
v5 already fixed this as part of a larger rework in #16454 ("Restore activity monitor layout and compact chevrons"), which has not synced to v6 yet. This PR is the minimal v6 fix until then. When the v5 snapshot lands, take v5's version of this rule.
Files
src/pkg/dashboard/static-src/css/tracker.css: the selector, with a comment saying why.src/pkg/dashboard/static/index.html: regenerated (go generate ./pkg/dashboard/webstatic).changelog.d/fixed-activity-title-pills-overlap.md.Tests
go test ./pkg/dashboard/... ./pkg/webassets/...passes. No existing test covers CSS geometry, so the before and after numbers above come from rendering the generated stylesheet in headless Chrome.π€ Generated with Claude Code
https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1