Skip to content

πŸ› dashboard: keep activity title-line pills off the PR title - #16498

Merged
hivecommons-hive[bot] merged 1 commit into
hivecommons:v6from
Danathar:fix/activity-pills-overlap
Nov 4, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
hivecommons:v6from
Danathar:fix/activity-pills-overlap

Conversation

@Danathar

@Danathar Danathar commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

What this changes

On the activity monitor, the pills on a row's title line (train Β· joins behind #61 next pass, stage ↓, the base-branch pill) no longer sit on top of the PR title. The title line goes back to its intended layout: the issue spans Open..Claimed, the PR starts at PR in progress, and the pills sit at the right end.

Why

#16384 added this grid rule for the chevron strips:

.ham-strip:not(.ham-head-cols) { display: grid; grid-template-columns: repeat(7, 1fr) 4em; }

ham-head-cols is a class on the strip's row (<div class="ham-strip-row ham-head-cols"><ol class="ham-strip">), not on the strip. So the :not() never excluded anything, and the title line became a grid too. Its three cells (lead, PR, pills) landed in the first three chevron-wide columns. The pills are wider than one column and are right-aligned, so they spilled left over the PR title. This is the overlap seen live on the projectbluefin hive (build bc48887, which is v6 HEAD).

How it works now

The exclusion is written on the row, so only the chevron strips and the column header are grids:

.ham-strip-row:not(.ham-head-cols) > .ham-strip { display: grid; … }

Every .ham-strip the dashboard renders sits directly inside a .ham-strip-row: the column header, each row's strip, and each sub-row's strip. So all of them keep the grid. The title line goes back to the flex sizing its rules already describe.

Measured (headless Chrome, 1470px, real generated CSS)

Title-line cell Before (v6 HEAD) After
lead (issue) x=342, w=137 (1 column) x=342, w=418 (3 columns)
PR title x=481, w=137 x=762, w=359
pills cell x=621, w=137 x=1123, w=243
pills content x=515, w=243 (overlaps) x=1123, w=243
4th chevron (ref.) x=753 x=753

Before, the 243px pills started at x=515, inside the PR cell (481–618). After, nothing overlaps.

Note on v5

v5 already fixed this as part of a larger rework in #16454 ("Restore activity monitor layout and compact chevrons"), which has not synced to v6 yet. This PR is the minimal v6 fix until then. When the v5 snapshot lands, take v5's version of this rule.

Files

  • src/pkg/dashboard/static-src/css/tracker.css: the selector, with a comment saying why.
  • src/pkg/dashboard/static/index.html: regenerated (go generate ./pkg/dashboard/webstatic).
  • changelog.d/fixed-activity-title-pills-overlap.md.

Tests

go test ./pkg/dashboard/... ./pkg/webassets/... passes. No existing test covers CSS geometry, so the before and after numbers above come from rendering the generated stylesheet in headless Chrome.

πŸ€– Generated with Claude Code

https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1

The chevron-strip grid rule from hivecommons#16384, `.ham-strip:not(.ham-head-cols)`,
also matched the title line: `ham-head-cols` is a class on the strip's
row, not on the strip. The title line's lead / PR / cap cells landed in
the first three chevron-wide grid columns, and cap pills wider than one
column (`train Β· joins behind #N next pass`, `stage ↓`) right-aligned
out of the cap cell and drew over the PR title and base pill.

Spell the exclusion on the row so only the chevron strips and the
column header are grids; the title line goes back to its flex sizing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 4, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 4, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 176b28f into hivecommons:v6 Nov 4, 2026
74 of 77 checks passed

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the v6 tree at bc48887 to check the selector change rather than the diff alone β€” it holds.

  • ham-head-cols is placed on the row, not the strip (src/pkg/dashboard/static-src/js/tracker-row-layout.js:11: <div class="ham-strip-row ham-head-cols"><ol class="ham-strip">), so the old .ham-strip:not(.ham-head-cols) indeed matched every strip including the title line.
  • Every .ham-strip the dashboard renders is a direct child of a .ham-strip-row β€” column header (tracker-row-strip.js:15), per-row strip (tracker-row-render.js:169-171), sub-row strip (tracker-row-layout.js:248-250), head columns (tracker-row-layout.js:11). The new .ham-strip-row:not(.ham-head-cols) > .ham-strip therefore keeps the grid on exactly the chevron strips and drops it only from the title line. No Go or JS test pins the old selector string.
  • static/index.html carries the identical hunk, so the generated copy stays in sync.

Looks correct to me as the minimal v6 fix until #16454 syncs.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#16498ee1635c` sha256:28f96f8790e40ca0107adf52a249e325bc74a9ae34c0e68f5e9afb8a0143e977 β€” download from the dashboard or `hivectl review evidence #16498`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @Danathar holds role owner and GitHub permission maintain on repo; CI green at ee1635c.

clubanderson added a commit that referenced this pull request Nov 4, 2026
Integrates #16478, #16498 and #16505, which landed on v6 after the merge
was prepared. tracker.css: kept v5's title-line grid (#16454..#16494,
which supersedes #16498's flex-only title line and already keeps cap
pills off the PR title); static/index.html regenerated from static-src.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant