Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
75d0a68
fix: stage tracker shows the hive is answering Let hive decide and sa…
hivecommons-hive[bot] Oct 30, 2026
f1e1119
fix: guard stageTrackerActorTip's stageTrackerHumanWhy call for lifte…
hivecommons-hive[bot] Oct 30, 2026
a1d9cf7
test: lift stageTrackerPRListedOwnRow into the row-actions preamble
hivecommons-hive[bot] Oct 30, 2026
6e5964a
fix: busy Let hive decide keeps its colour, only its own pend busies …
hivecommons-hive[bot] Oct 30, 2026
4442dac
fix: covered-issue chip only when the PR is a drawn row
hivecommons-hive[bot] Oct 30, 2026
91e79fe
Merge remote-tracking branch 'origin/v5' into scanner/fix-15773
hivecommons-hive[bot] Oct 30, 2026
788fef4
Merge branch 'v5' into scanner/fix-15773
hivecommons-hive[bot] Oct 31, 2026
c48a228
Merge branch 'v5' into scanner/fix-15773
hivecommons-hive[bot] Oct 31, 2026
ac1ec66
Merge branch 'v5' into scanner/fix-15773
hivecommons-hive[bot] Oct 31, 2026
12cdc7e
Merge branch 'v5' into scanner/fix-15773
hivecommons-hive[bot] Oct 31, 2026
0a78368
🐛 fix: one preview caption, rows-only chip rule, operator doc for #15773
hivecommons-hive[bot] Oct 31, 2026
4b7d775
Merge remote-tracking branch 'origin/v5' into scanner/fix-15773
hivecommons-hive[bot] Oct 31, 2026
16f930f
🐛 fix: 085 stage_actor.why says why; drawn-page rows ride ctx, not th…
hivecommons-hive[bot] Oct 31, 2026
8c3280e
Merge branch 'v5' into scanner/fix-15773
hivecommons-hive[bot] Oct 31, 2026
d3aece9
🐛 fix: covered issue chips to the row that draws its PR; row hover sa…
hivecommons-hive[bot] Oct 31, 2026
9ce1f12
Merge branch 'v5' into scanner/fix-15773
hivecommons-hive[bot] Oct 31, 2026
1fcbf3b
Merge branch 'v5' into scanner/fix-15773
hivecommons-hive[bot] Oct 31, 2026
4055a6c
Merge branch 'v5' into scanner/fix-15773
hivecommons-hive[bot] Oct 31, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Stage tracker: Let hive decide now shows the hive is working at once, covered issues no longer repeat their PR's button, and a person's move says why (#15773)
17 changes: 9 additions & 8 deletions src/docs/dashboard-sections/activity-monitor.md
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ Plain words throughout — working / waiting on X / set back by Y / merged — n

#### The row's lead action, inline

A row whose next move is yours does not hide its answer behind three dots. Beside the chips on the right of the header (and on a nested PR sub-row's own header), the row renders its **lead action** as a real `<button class="ham-lead-act">` — `[Accept triage]` on *Triage needed* (000-new hold or 015), `[Merge now]` (or the server's lead answer) on *Ready for human merge*, `[Let hive decide]` on *Needs human decision* and a duplicate's *Needs a pick*, `[Adopt…]` on a returned contributor PR whose adoption is due, `[Close now]` on an advisory issue. `stageTrackerLeadAction(item, ctx)` picks it from the same `stageTrackerRowActions(...)` list the ⋯ menu shows: the entry flagged `lead`, else the first *Decide…* option, else Adopt / Adopt now / *Let hive decide — all N PRs*; one button only, everything else stays in ⋯. It carries the menu entry's id, its hint as the hover and its enable/disable reason: a viewer without write access sees it greyed with *Sign in with write access to this repo*, a non-merger sees a merge action greyed with the role reason, never hidden. Clicking runs `runRowAction(action, row)` — the menu's own path, so the busy chevron, the acting caption, the toast and the history badge are the same. A row the server marks as the maintainer's move (`actor: maintainer` or `new.next_mover: maintainer`) that yields no lead is a bug: a development host logs a console warning, and `TestStageTrackerMaintainerRowsHaveLeadAction` runs the real fixtures through the picker.
A row whose next move is yours does not hide its answer behind three dots. Beside the chips on the right of the header (and on a nested PR sub-row's own header), the row renders its **lead action** as a real `<button class="ham-lead-act">` — `[Accept triage]` on *Triage needed* (000-new hold or 015), `[Merge now]` (or the server's lead answer) on *Ready for human merge*, `[Let hive decide]` on *Needs human decision* and a duplicate's *Needs a pick*, `[Adopt…]` on a returned contributor PR whose adoption is due, `[Close now]` on an advisory issue. `stageTrackerLeadAction(item, ctx)` picks it from the same `stageTrackerRowActions(...)` list the ⋯ menu shows: the entry flagged `lead`, else the first *Decide…* option, else Adopt / Adopt now / *Let hive decide — all N PRs*; one button only, everything else stays in ⋯. A covered issue whose covering PR is drawn as its own tracker row — or, when the PR closes several listed issues, under another listed issue (`drawn_under`) — renders no button at all but a passive *decision pending on #N* chip (its tooltip names the lead and the row it lives on), so the decision has one button, on the row that draws the PR. It carries the menu entry's id, its hint as the hover and its enable/disable reason: a viewer without write access sees it greyed with *Sign in with write access to this repo*, a non-merger sees a merge action greyed with the role reason, never hidden. Clicking runs `runRowAction(action, row)` — the menu's own path, so the busy chevron, the acting caption, the toast and the history badge are the same. A row the server marks as the maintainer's move (`actor: maintainer` or `new.next_mover: maintainer`) that yields no lead is a bug: a development host logs a console warning, and `TestStageTrackerMaintainerRowsHaveLeadAction` runs the real fixtures through the picker.

#### Row actions (right-click, ⋯, Shift+F10)

Expand Down Expand Up @@ -404,7 +404,7 @@ The owner's framing (2026-10-28): "Hive is doing the right things mostly; we now

**Where it is** is the lit chevron (the state pill). **Working** — the chevron's icon turns slowly and the pill pulses only while a hive agent is actually on the item right now (the status payload's `agents[].lastAction` for the current round, matched to the row or to the PR shown on its row); its tooltip then leads with *Working now: scout commented · 2m ago —* before the stage words.

A still chevron means **waiting**; its tooltip already says where it stands and whose move it is (*Needs decision — … · Next move: human*). **Acting** — from the moment you choose a row action the affected row (and the nested PR sub-row when the action targets it) draws faint stripes over its lit chevron and an *Approving… / Hive is deciding… / Holding…* caption with a small spinner; it clears when the tracker reports the target in a new state, at once on a no-op or an error, and never later than three minutes.
A still chevron means **waiting**; its tooltip already says where it stands and whose move it is (*Needs decision — … · Next move: human*). **Acting** — from the moment you choose a row action the affected row (and the nested PR sub-row when the action targets it) draws faint stripes over its lit chevron and an *Approving… / Hive deciding… / Holding…* caption with a small spinner; it clears when the tracker reports the target in a new state, at once on a no-op or an error, and never later than three minutes.

**Event line** — one short plain sentence under the strip about the latest thing that happened to the row, from the difference between two tracker payloads (the poll / SSE refetch the tracker already makes; no extra requests): *Hive: moved to CI / Review · 12s ago*, *Hive: fell back to Claimed — a reviewer requested changes* (a lower stage number reads as a fall only when the stage table's `falls_to` — the stage engine's regression rule — says so; triage accepted 015 → 010, a decision made 085 → 080 or the author resuming 072 → 070 read *moved to*), *Hive: waiting on a person*, *Hive: hold released*, *You: approved*.

Expand Down Expand Up @@ -434,7 +434,7 @@ Nothing the dialog would have said is lost: the result toast carries the same

The small icon after the lit pill's words names whose move the row is, and it comes from the payload — `stage_actor: {kind, login, since, why}`, derived server-side for every item and every nested PR — never from a guess on a login string. `kind` is one of **hive** (⬡ honeycomb: a hive lane or agent acts next; `login` is the agent when one is on it right now), **clanker** (robot head: a registered contributor agent must push), **human** (the person glyph the *Needs human decision* pill uses: the author, approver or a maintainer must act; `login` names them when known), **bot** (cog: a non-hive automation account such as `github-actions[bot]` or renovate authored the PR; the hive does not fix bot PRs, it waits for the bot's next run), or **none** (no icon: nobody is working on it — the pill's tooltip then reads *no one is working on this right now — <why>*).

`why` is a short sentence the tooltip appends after *Next move: <kind> @<login>*. A `070` Fixing pill is only shown as **Fixing** when someone can fix it; a bot-authored or unowned red PR reads its state in plain words instead — **Conflicting · bot PR**, **Red · nobody on it** — with the matching icon, so a row such as hivecommons/docs#500 (a nightly resync PR that conflicts with its base) no longer looks like active hive work.
`why` is a short sentence the tooltip appends after *Next move: <kind> @<login>*. On *Needs human decision* (035 / 045) it says what is owed, not only that it is: *a human decision is owed — workflow path* — the lane reason in plain words (the same clause the row caption carries), else the decision's own question (`decision_needed.question`), else the bare phrase — so the 👤 marker never leaves the question unanswered. The row hover says it once: when that why repeats the caption, the *Next move* line keeps only who moves; the chevron hover, which has no caption line, carries the whole why. (Older payloads without `stage_actor` on a human move fall back to the row's own reason: `human_merge_reason_text`, else `reason`.) A `070` Fixing pill is only shown as **Fixing** when someone can fix it; a bot-authored or unowned red PR reads its state in plain words instead — **Conflicting · bot PR**, **Red · nobody on it** — with the matching icon, so a row such as hivecommons/docs#500 (a nightly resync PR that conflicts with its base) no longer looks like active hive work.

Issues riding one covering PR take that PR's actor; nested PR sub-rows carry their own.

Expand Down Expand Up @@ -599,10 +599,11 @@ The item leaves 085/045 and proceeds without the owner. The action is audited as

#### How it runs

1. Read the one-time explanation and confirmation. **Don't ask again for this action** is optional; reset it in ⚙ → **Confirmations**.
2. The row reads **Hive is deciding…** while the job runs.
3. Read the persistent result toast. It says what was decided and what happens next; it stays until the target row changes state.
4. If the result has not happened, use [When the decision doesn't take effect](#when-the-decision-doesnt-take-effect), rather than treating an approval as a completed merge.
1. From the click until the preview opens, the row's *Let hive decide* button and its caption both read **Asking the hive…** with a spinner (the plan is gathered live; the button cannot be clicked twice).
2. Read the one-time explanation and confirmation. **Don't ask again for this action** is optional; reset it in ⚙ → **Confirmations**.
3. The row reads **Hive deciding…** while the job runs.
4. Read the persistent result toast. It says what was decided and what happens next; it stays until the target row changes state.
5. If the result has not happened, use [When the decision doesn't take effect](#when-the-decision-doesnt-take-effect), rather than treating an approval as a completed merge.

Permission is the same as **Hold**: owner, or a signed-in user with repository write access. The recorded decision names the requesting user as the person who delegated it.

Expand Down Expand Up @@ -671,7 +672,7 @@ At the same time the hive posts one follow-up comment on the item — *Hive deci

The toast and the decision trail lead with the outcome in one line — *Adopted — hive will rebase & merge it next pass (~4m)*; *Adopted: hive opened #15123 with the same commits and will merge it; #15029 will be closed as superseded* — details second, nothing repeated.

**Preview before acting.** *Let hive decide* no longer acts on the click. It first calls `POST …/decide-delegated/plan` , a dry run with no side effects that answers `{would, title, summary, why, consequences[], ladder, mergeable_as_is, alternatives[]}`, and shows one decision — built to be read in three seconds (operator feedback on hive's own spoke: the first version was "a wall of text" with a doubled *Hive would: Hive would:*, the PR named twice, three type sizes and a merge button on a head it had just called not mergeable):
**Preview before acting.** *Let hive decide* no longer acts on the click. The button turns busy and reads **Asking the hive…** (the row caption says the same) while it first calls `POST …/decide-delegated/plan`, a dry run with no side effects that answers `{would, title, summary, why, consequences[], ladder, mergeable_as_is, alternatives[]}`, and shows one decision — built to be read in three seconds (operator feedback on hive's own spoke: the first version was "a wall of text" with a doubled *Hive would: Hive would:*, the PR named twice, three type sizes and a merge button on a head it had just called not mergeable):

- **Title** *Let hive decide*, then one subject line — `hivecommons/hive#15332 · ci: run crux's Go file-size ratchet…` — with a compact **⚠ Sentinel** chip when the sentinel flagged the head (the full finding is in Details).
- **Eyebrow** *Hive would* → **one verb-first sentence**: *Send #15332 back to its author with one instruction: make CI green, nothing else.* → one muted **Why** line (≤ 12 words: *CI is red.*) → **Then**, at most two short items (*Hive posts that instruction on #15332. · The author pushes a fix; the row updates when it lands.*).
Expand Down
16 changes: 15 additions & 1 deletion src/pkg/dashboard/stage_tracker_actor.go
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,9 @@ func stageTrackerStageActor(it StageTrackerItem, workers map[string]stageTracker
if step, _ := stageTrackerUnauthorized(it.Reason); step != "" {
return set(StageActorHuman, "", "the hive is not permitted to "+step+"; a person must")
}
return set(StageActorHuman, "", "a human decision is owed")
// The why says what is owed, not only that it is (hivecommons/hive#15773):
// the lane's reason in plain words, else the decision's own question.
return set(StageActorHuman, "", joinClause("a human decision is owed", stageTrackerDecisionWhy(it)))
case stagelabels.ReadyForHumanMerge:
// The chevron and the popover already carry HumanMergeReasonText;
// the next-move line says only who moves (hivecommons/hive#15394).
Expand All @@ -214,6 +216,18 @@ func stageTrackerStageActor(it StageTrackerItem, workers map[string]stageTracker
return set(StageActorNone, "", "no stage recorded yet")
}

// stageTrackerDecisionWhy: the clause after "a human decision is owed" —
// the lane reason humanized ("workflow path"), else the asker's question.
func stageTrackerDecisionWhy(it StageTrackerItem) string {
if clause := humanizeStageReason(it.Reason); clause != "" {
return clause
}
if it.DecisionNeeded != nil {
return strings.TrimSpace(it.DecisionNeeded.Question)
}
return ""
}

// stageTrackerAuthorStageActor: 070 / 071 / 072 park the PR on its
// author. A hive PR is the hive's (an agent on it is named; otherwise the
// hive re-kicks it), a clanker's is re-kicked by its contributor hive, a
Expand Down
Loading
Loading