Skip to content

Contributor-lane PRs park at 085 needs-decision during CI/Review with no finding surfaced #15640

Closed

Description

@clubanderson

Symptom

hive's own hosted spoke, 2026-10-29 ~22:30 EDT: ~12 contributor-lane PRs authored by contributors' clankers (#15312, #15324, #15343, #15410, #15433, #15482, #15487, #15489, crux#53, docs#514, docs#518) sat 3–21h. Issue labels stayed stage/040-covered-by-pr; the tracker showed "PR in progress · @x's clanker" in CI/Review. Every cycle:

stage labels: reviewer verdict route … raw_verdict=requires_human decision_requested=true stage=085-needs-decision reason=contributor-lane:decision-requested
merge train: PR left out of every train why=human-merge

Nothing on the PR said what the review had found; nothing surfaced a decision anywhere a person looks.

Owner rule

there should be no decisions by a human while these are in ci/review — unless the review found something.

Root cause

  • The review swarm did run. The reviewer's decision_requested marker forces every perspective to requires_human, and aggregateReports honoured it blindly for non-hive-authored PRs (hive-authored PRs already go through the DecisionRiskClasses denylist). Nothing checked whether the question was backed by a finding, and nothing carried what was found into the verdict record.
  • The 085 comment was posted, but stage labels were withheld by the write-back gate (stage_label kind needs the hive-review opt-in at L5 for non-hive-authored items — by design), so the issue stayed at 040 and the tracker fell back to "PR in progress" (display side fixed by 🐛 adoption: offline clanker PRs don't stall at 'PR in progress' #15593, not yet rolled).

Expected

While a PR is in CI/Review the hive runs CI + the review swarm to completion. A person is asked only when the review found something concrete (duplicate, trust-surface/risk-class question, high-risk marker, finding at the human threshold, unresolvable red CI), and the record says what. A contributor PR that needs a human's merge click waits at the merge gate (090, human-merge rule), not at 085 during review.

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions