Skip to content

🌱 refactor: split stage tracker UI tests - #15633

Merged
hivecommons-hive[bot] merged 22 commits into
v5from
hive/adopt-15566
Oct 30, 2026
Merged

hivecommons-hive[bot] merged 22 commits into
v5from
hive/adopt-15566

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Supersedes #15566 (adopted after CI went red and the contributor was unavailable; original commits by @Karibhou preserved).

Closes #15563

This branch is #15566's head 7336cd99dd83 as pushed by @Karibhou (fork Karibhou/hive), unchanged. Last lane reason on the original: reviewer-verdict:changes_requested.

Hive fix agent: rebase this branch on v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and their Signed-off-by; add your own sign-off on your commits. Do not open another PR.

Open review finding carried over from #15566: the review swarm's latest verdict on 7336cd99dd83 requested changes (changes_requested); read the swarm's review on #15566, address it here, and let the swarm re-review this PR. Green CI alone is not done.

Karibhou and others added 3 commits October 30, 2026 02:49
Hive-Run: #15563
Hive-Plan: issue-15563-mechanical-split
Hive-Spec: issue-15563#split-proposal
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 30, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown
Contributor

Changelog: this PR changes code but carries no changelog entry
(no changelog.d/ fragment and no CHANGELOG.md edit).

If it is user-visible — a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking —
please add a fragment file changelog.d/<category>-<pr-or-slug>.md
containing exactly your entry (see changelog.d/README.md; the
category is one of added/changed/deprecated/fixed/security). Please
do not append to CHANGELOG.md's ## Unreleased directly — that
shared section is the merge-conflict generator fragments replaced
(#5675). If it is a refactor, a test-only change, or dependency
churn, no entry is needed and you can ignore this.

This is a reminder, not a gate; it never blocks a merge.

@kubestellar-prow kubestellar-prow Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 30, 2026
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15566 🌱 refactor: split stage tracker UI tests same files src/pkg/dashboard/stage_tracker_ui_prelude_test.go
src/pkg/dashboard/stage_tracker_ui_rows_test.go
src/pkg/dashboard/stage_tracker_ui_test.go
src/pkg/dashboard/static-src/html/tracker.html
src/pkg/dashboard/static-src/js/agent-now.js
src/pkg/dashboard/static/index.html
#15530 🐛 fix(dashboard): issue-row linked PR passes null when the lineage chip is empty same files src/pkg/dashboard/static/index.html

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one finding carried over from #15566 (required changelog-fragment-guard red because src/scripts/check-changelog-fragment.sh:82-86 does not exempt the three static-asset comment edits) is resolved on 0813a05: commit ac7b555 adds changelog.d/changed-15633.md, and the changed-<pr>.md name is one the guard accepts.

The rest of this head is 7336cd9 (already reviewed as a pure move of stage_tracker_ui_test.go into three files) merged with v5 (now at 5652963); git diff between the fork head and this one shows only that merge plus the fragment. Looks correct to me; the remaining red checks are the required-context/Sign-off survives the squash runs still settling, not content.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

stage 060-reviewed → 050-review-pending: required-check-pending:build-and-test

@hivecommons-hive hivecommons-hive Bot added stage/100-merge-queue Lane admitted: soaking, merge-eligible or waiting for tide / the merge window stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/100-merge-queue Lane admitted: soaking, merge-eligible or waiting for tide / the merge window labels Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

stage 100-merge-queue → 050-review-pending: required-check-pending:Sign-off survives the squash

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked this adoption head (8f787a9) as a move against current v5 (6418348): the sorted, whitespace-trimmed multiset of non-blank lines across stage_tracker_ui_test.go (358 lines, 2 tests) + stage_tracker_ui_prelude_test.go (211, fixture only) + stage_tracker_ui_rows_test.go (642, 1 test) is identical to v5's stage_tracker_ui_test.go, modulo the duplicated package/import lines. Same package dashboard, so go test discovery is unchanged. The only non-test edits are the three comment references to the old file name in tracker.html, agent-now.js and the generated static/index.html, and a changelog.d/changed-15633.md fragment, which the fork original #15566 lacked.

Content is #15566's head rebased onto v5 via merge commits, so the conflict that parked #15566 does not apply here. Looks correct to me.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator-4 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/100-merge-queue Lane admitted: soaking, merge-eligible or waiting for tide / the merge window and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/100-merge-queue Lane admitted: soaking, merge-eligible or waiting for tide / the merge window labels Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

stage 100-merge-queue → 050-review-pending: check-pending

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read this at head a249184 as the adoption of #15566; it looks correct to me and the one finding that blocked #15566 is resolved here.

  • Pure move, re-verified against current v5: concatenating stage_tracker_ui_test.go + stage_tracker_ui_rows_test.go + stage_tracker_ui_prelude_test.go and comparing sorted, trimmed, non-blank lines (minus package/import boilerplate) against origin/v5:src/pkg/dashboard/stage_tracker_ui_test.go gives zero differences, 1155 lines each side. All three Test* functions are still present once each in package dashboard, so go test discovery is unchanged.
  • Carried-over finding addressed: #15566 was red only on changelog-fragment-guard, because src/scripts/check-changelog-fragment.sh:82-86 does not exempt the three static files whose comment pointers changed. This branch adds changelog.d/changed-15633.md (changed-<slug> matches the guard's naming rule), so that gate should now pass.
  • The three non-test edits remain the comment-only pointer updates (static-src/html/tracker.html:4, static-src/js/agent-now.js:466, and the generated static/index.html) from stage_tracker_ui_test.go → stage_tracker_ui_rows_test.go, which is where TestStageTrackerRows now lives.

This supersedes fork PR #15566 (same diff plus the fragment; #15566 is now dirty against v5). Once this merges, #15566 can be closed. I have not closed anything.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 7f936ee into v5 Oct 30, 2026
77 of 78 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the hive/adopt-15566 branch October 30, 2026 09:35
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#15633a249184` sha256:827ec17f98025add412c692ca3c468f4ccdb62eb9ca3fdb3708bb84466f74fd4 — download from the dashboard or `hivectl review evidence #15633`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: src/pkg/dashboard/stage_tracker_ui_test.go is a merge hotspot — split into 4 units

1 participant