Repository navigation
🌱 refactor: split stage tracker UI tests - #15633
Conversation
Hive-Run: #15563 Hive-Plan: issue-15563-mechanical-split Hive-Spec: issue-15563#split-proposal Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Changelog: this PR changes code but carries no changelog entry If it is user-visible — a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
The one finding carried over from #15566 (required changelog-fragment-guard red because src/scripts/check-changelog-fragment.sh:82-86 does not exempt the three static-asset comment edits) is resolved on 0813a05: commit ac7b555 adds changelog.d/changed-15633.md, and the changed-<pr>.md name is one the guard accepts.
The rest of this head is 7336cd9 (already reviewed as a pure move of stage_tracker_ui_test.go into three files) merged with v5 (now at 5652963); git diff between the fork head and this one shows only that merge plus the fragment. Looks correct to me; the remaining red checks are the required-context/Sign-off survives the squash runs still settling, not content.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
stage 060-reviewed → 050-review-pending: required-check-pending:build-and-test |
|
stage 100-merge-queue → 050-review-pending: required-check-pending:Sign-off survives the squash |
There was a problem hiding this comment.
Checked this adoption head (8f787a9) as a move against current v5 (6418348): the sorted, whitespace-trimmed multiset of non-blank lines across stage_tracker_ui_test.go (358 lines, 2 tests) + stage_tracker_ui_prelude_test.go (211, fixture only) + stage_tracker_ui_rows_test.go (642, 1 test) is identical to v5's stage_tracker_ui_test.go, modulo the duplicated package/import lines. Same package dashboard, so go test discovery is unchanged. The only non-test edits are the three comment references to the old file name in tracker.html, agent-now.js and the generated static/index.html, and a changelog.d/changed-15633.md fragment, which the fork original #15566 lacked.
Content is #15566's head rebased onto v5 via merge commits, so the conflict that parked #15566 does not apply here. Looks correct to me.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
stage 100-merge-queue → 050-review-pending: check-pending |
There was a problem hiding this comment.
Read this at head a249184 as the adoption of #15566; it looks correct to me and the one finding that blocked #15566 is resolved here.
- Pure move, re-verified against current
v5: concatenatingstage_tracker_ui_test.go+stage_tracker_ui_rows_test.go+stage_tracker_ui_prelude_test.goand comparing sorted, trimmed, non-blank lines (minuspackage/importboilerplate) againstorigin/v5:src/pkg/dashboard/stage_tracker_ui_test.gogives zero differences, 1155 lines each side. All threeTest*functions are still present once each inpackage dashboard, sogo testdiscovery is unchanged. - Carried-over finding addressed: #15566 was red only on
changelog-fragment-guard, becausesrc/scripts/check-changelog-fragment.sh:82-86does not exempt the three static files whose comment pointers changed. This branch addschangelog.d/changed-15633.md(changed-<slug>matches the guard's naming rule), so that gate should now pass. - The three non-test edits remain the comment-only pointer updates (
static-src/html/tracker.html:4,static-src/js/agent-now.js:466, and the generatedstatic/index.html) fromstage_tracker_ui_test.go→stage_tracker_ui_rows_test.go, which is whereTestStageTrackerRowsnow lives.
This supersedes fork PR #15566 (same diff plus the fragment; #15566 is now dirty against v5). Once this merges, #15566 can be closed. I have not closed anything.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Supersedes #15566 (adopted after CI went red and the contributor was unavailable; original commits by @Karibhou preserved).
Closes #15563
This branch is #15566's head
7336cd99dd83as pushed by @Karibhou (forkKaribhou/hive), unchanged. Last lane reason on the original:reviewer-verdict:changes_requested.Hive fix agent: rebase this branch on
v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and theirSigned-off-by; add your own sign-off on your commits. Do not open another PR.Open review finding carried over from #15566: the review swarm's latest verdict on
7336cd99dd83requested changes (changes_requested); read the swarm's review on #15566, address it here, and let the swarm re-review this PR. Green CI alone is not done.