Skip to content

πŸ› dashboard: kiosk mode renders dark by default - #15623

Merged
clubanderson merged 2 commits into
v5from
fix/kiosk-dark-default
Oct 30, 2026
Merged

clubanderson merged 2 commits into
v5from
fix/kiosk-dark-default

Conversation

@clubanderson

Copy link
Copy Markdown
Member

The headless streamer (#15594) starts from an empty Chromium profile, and the layout default when hive-layout-mode is unset is light β€” so the Twitch stream came up in light mode. In kiosk mode the theme is forced to dark (&theme=light opts out) both at first paint in boot.js and in getLayout(); kiosk never writes localStorage. Docs + changelog.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 30, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 30, 2026
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 30, 2026
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15616 πŸ› tracker: PRs under repair leave the merge train same files src/pkg/dashboard/static/index.html
#15566 🌱 refactor: split stage tracker UI tests same files src/pkg/dashboard/static/index.html
#15620 ✨ dashboard: running-cost tile rotates hour / today / week / month same files src/pkg/dashboard/static/index.html
#15530 πŸ› fix(dashboard): issue-row linked PR passes null when the lineage chip is empty same files src/pkg/dashboard/static/index.html
#15619 πŸ› dashboard: PRs-by-model rank uses a confidence-weighted score and normalised model ids same files src/pkg/dashboard/static/index.html

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change reads correctly: boot.js:18-19 set window.HIVE_KIOSK / hiveKioskMode before the theme block at boot.js:26-31, and the generated index.html:6708-6721 mirrors that order, so the override is applied before first paint; getLayout() in layout.js:230 applies the same rule for later reads, and the toggle is hidden in kiosk anyway.

One suggestion, not a defect: TestKioskModeWiring (src/pkg/dashboard/kiosk_mode_test.go:14-25) pins every other piece of kiosk wiring by asserting the exact line is present in index.html, but neither the new boot override nor the getLayout override is in its wants list. Adding the two lines there would make this behaviour fail-without-test like the rest of the kiosk mode.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Verified at 4fc8a08:

  • window.HIVE_KIOSK and window.hiveKioskMode are assigned at boot.js:18-19, in the same IIFE and before the theme read at boot.js:26-32, so the first-paint override sees the flag. The getLayout() override at layout.js:230 runs after boot, so both the light-mode body class and later getLayout() callers agree.
  • The override only reads localStorage and the URL; the kiosk never-writes-localStorage invariant from the header comment at boot.js:8-14 still holds (the setLayout calls at layout.js:231-232 are reached only for legacy openclaw/classic stored values, which the override replaces before they are tested).
  • static/index.html is in sync with static-src/: go run ./pkg/dashboard/webstatic/gen -src pkg/dashboard/static-src -out pkg/dashboard/static/index.html -check exits 0 on this head.
  • Non-kiosk behaviour is unchanged: both guards are behind the kiosk flag, and the !m β†’ 'light' default is preserved for normal sessions.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@clubanderson
clubanderson merged commit e56f298 into v5 Oct 30, 2026
77 of 80 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/kiosk-dark-default branch October 30, 2026 02:35
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant