Repository navigation
π review: one backlog issue per finding; carried-over notes never refile - #15680
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
7c6d8ee to
3883dad
Compare
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
hive/ci-triage (scanner): the red checks at head
Not pushing to this branch since it is author-owned; the sweep will pick it up once green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
The reviewer swarm filed a backlog issue per perspective per head for the
same out-of-scope finding: each pass re-reported the other perspectives'
still-open notes as new findings ("Previous style note still present"),
so one finding on one PR became three issues, all blocked on the PR, and
16 of 62 open items in the activity monitor were such notes.
- Filing: each item is remembered under its PR with file, line and title;
a later report from any perspective or head naming the same finding
(same file and line, shared symbol, or same title once its carry-over
wrapper and advisory qualifiers are stripped) is tracked against the
existing item, never filed. A pure carry-over or a finding carrying
<!-- hive-refers-to: #N --> is a reference and is dropped when it names
nothing tracked. One "still present at <head>" comment per item per
head, counted against the daily cap. Title dedupe ignores a leading
[reviewer] tag.
- Prompts: perspectives, the delta section and the heads decision step
are told to report only genuinely new findings and to cite prior notes
with the refers-to marker.
- Block sweep: on merge the hive reads the finding's file on the PR's
base; file or named symbol gone closes the item as completed
(review_backlog_issue_closed audit), otherwise the block is lifted.
- Activity monitor: blocked review notes fold under their open source PR
as one muted line (or into the group's lowest-numbered note when the
PR is not drawn); the row count counts a group once and the header
breakdown names the folded notes.
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
@clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
|
stage 080-awaiting-merge-admission β 071-needs-author: required-check-failing:coverage |
- static-src carries the tracker fold (index.html is generated from it) - still-present notes are tracked per PR and item, so a cross-PR re-raise does not re-arm the note on the filing PR - CloseItem consults the write-back gate; ratchet baseline names the file - node harnesses past ARG_MAX read the script from stdin - drop the unused reviewBacklogPROutcome wrapper Signed-off-by: Andrew Anderson <andy@clubanderson.com>
3883dad to
a226234
Compare
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Port the v5 tracker-row.js changes (hivecommons#15657, hivecommons#15664, hivecommons#15668, hivecommons#15680) into the split files: stageTrackerAnchor under-repair column (tracker-row.js), acted labels (tracker-row-strip.js), queue-merge pending copy (tracker-row-acted.js), and stageTrackerLead / left_train / subRows / review notes (tracker-row-layout.js). static/index.html regenerated and matches the auto-merge byte for byte. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Fixes #15679
What
Filing (
pkg/github/review_backlog_dedupe.go,review_backlog.go). Each item filed from a PR is remembered under that PR (pr_findings: file, line, title, item). A later report from any perspective or at any head that names the same finding β same file and line, a shared code symbol, or the same title once its carry-over wrapper ("Previous style note still present (non-blocking):", "Prior finding still present:", "Previous security finding (β¦) unchanged at new head") and advisory qualifiers are stripped β is tracked against the existing item and never filed. A pure carry-over, or a finding carrying<!-- hive-refers-to: #N -->, is a reference: matched against the PR's tracked items, otherwise dropped with a log line. The hive notes persistence at most once per item per head ("Still present at ()."), counted against the daily cap. The watcher's exact-title dedupe and the backlog category regex ignore a leading[reviewer]tag.Prompts (
pkg/review/prompts.go,delta.go,prompts_decision.go). Perspectives report only findings new from their perspective at this head, never another perspective's or an earlier head's note; prior notes are cited with the refers-to marker. The heads decision step lists each underlying finding once.Block sweep (
review_backlog_selfcheck.go,review_backlog_blocks.go). When the source PR merged, the hive reads the finding's file on the PR's base: file gone, or none of the symbols the title names left in it β close as completed with a one-line note (review_backlog_issue_closedaudit); anything less certain, or a sink withoutCloseItem, lifts the block as before. Closed unmerged is unchanged (re-triage, never close).Activity monitor (
pkg/dashboard/stage_tracker.go,index.html). Ablockedreview-backlog issue whose source PR is open carriesreview_note_of; the PR carriesreview_notes.stageTrackerVisibledrops such issues when the PR is drawn (one mutedN review notes blocked on this PR Β· #a, #bline on the PR row) or collapses the group into its lowest-numbered note (+N more review notes blocked on PR #X). The pill counts rows, so a group costs one;stageTrackerRowBreakdowntakes the folded count so the header still adds up to the Overview totals (the overview sidebar pill is untouched).Tests
review_backlog_dedupe_test.go: the real titles (Review backlog (style): New test re-covers prWarnOnce semantics rather than the dispatcher wiringΒ #15627/28/29, Review backlog (style): Prior correctness note still present: head-commit fetch precedes the compareΒ #15630/31, Review backlog (docs-currency): Prior finding still present: waiver will recur per squashΒ #15659/60, Review backlog (security): Previous intent-alignment finding still present: mobile-shots retry tuning in refactor PRΒ #15602, Review backlog (correctness): Previous security finding (merge/trust policy expansion) unchanged at new headΒ #15182, Review backlog (correctness): Retained 'drum cell per digit' clause still contradicts the newer odometer fragment (still present, advisory)Β #15576, Review backlog (docs-currency): Dashboard help marks still land on index stub page (advisory, unchanged)Β #15540, Review backlog (docs-currency): Earlier unreleased changelog fragment still advertises 18 px digits and a grown pillΒ #15548) normalise to one string per finding and classify as carry-over or not;[reviewer]-insensitive title equality; three perspectives over two heads β one item, zero appends at the filing head, one still-present note at the next head, unanchored carry-over dropped, new finding still filed.review_backlog_selfcheck_test.go: on merge, file gone / symbol gone β closed (notes name why, read at the PR's base ref); symbol present / no symbol / legacy record / sink withoutCloseItemβ lifted; closed items are not revisited.stage_tracker_review_notes_test.go: Go fold (incl.[reviewer]title, foreign repo, non-backlog blocked issue, merged/closed source PR stays a row) and SPA rows/count/breakdown.prior_notes_prompt_test.go: all four prompts carry the rule and the marker.Counts before: 62 open / 24 "Review backlog" / 16
blocked.