Skip to content

πŸ› review: one backlog issue per finding; carried-over notes never refile - #15680

Merged
clubanderson merged 2 commits into
v5from
fix/review-backlog-dedupe
Oct 30, 2026
Merged

clubanderson merged 2 commits into
v5from
fix/review-backlog-dedupe

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #15679

What

Filing (pkg/github/review_backlog_dedupe.go, review_backlog.go). Each item filed from a PR is remembered under that PR (pr_findings: file, line, title, item). A later report from any perspective or at any head that names the same finding β€” same file and line, a shared code symbol, or the same title once its carry-over wrapper ("Previous style note still present (non-blocking):", "Prior finding still present:", "Previous security finding (…) unchanged at new head") and advisory qualifiers are stripped β€” is tracked against the existing item and never filed. A pure carry-over, or a finding carrying <!-- hive-refers-to: #N -->, is a reference: matched against the PR's tracked items, otherwise dropped with a log line. The hive notes persistence at most once per item per head ("Still present at ()."), counted against the daily cap. The watcher's exact-title dedupe and the backlog category regex ignore a leading [reviewer] tag.

Prompts (pkg/review/prompts.go, delta.go, prompts_decision.go). Perspectives report only findings new from their perspective at this head, never another perspective's or an earlier head's note; prior notes are cited with the refers-to marker. The heads decision step lists each underlying finding once.

Block sweep (review_backlog_selfcheck.go, review_backlog_blocks.go). When the source PR merged, the hive reads the finding's file on the PR's base: file gone, or none of the symbols the title names left in it β†’ close as completed with a one-line note (review_backlog_issue_closed audit); anything less certain, or a sink without CloseItem, lifts the block as before. Closed unmerged is unchanged (re-triage, never close).

Activity monitor (pkg/dashboard/stage_tracker.go, index.html). A blocked review-backlog issue whose source PR is open carries review_note_of; the PR carries review_notes. stageTrackerVisible drops such issues when the PR is drawn (one muted N review notes blocked on this PR Β· #a, #b line on the PR row) or collapses the group into its lowest-numbered note (+N more review notes blocked on PR #X). The pill counts rows, so a group costs one; stageTrackerRowBreakdown takes the folded count so the header still adds up to the Overview totals (the overview sidebar pill is untouched).

Tests

Counts before: 62 open / 24 "Review backlog" / 16 blocked.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 30, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15690 🌱 refactor: split src/cmd/hive/main.go into 4 files same files src/pkg/writeback/testdata/direct-writes-baseline.txt
#15617 πŸ› review: split the grounding budget across fan-out sub-agents same files src/pkg/review/prompts.go
#15521 🌱 refactor: split tracker row source same files src/pkg/dashboard/static-src/js/tracker-row.js
#15530 πŸ› fix(dashboard): issue-row linked PR passes null when the lineage chip is empty same files src/pkg/dashboard/static-src/js/tracker-row.js
src/pkg/dashboard/static/index.html
#15566 🌱 refactor: split stage tracker UI tests same files src/pkg/dashboard/stage_tracker_ui_test.go
src/pkg/dashboard/static/index.html
#15564 πŸ› review: split the grounding budget across fan-out sub-agents same files src/pkg/review/prompts.go
#15658 πŸ› fix(tracker): PRs at CI / Review ride no merge train; overlap hint instead same files src/docs/dashboard-sections.md
src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/stage_tracker_links.go
src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static-src/js/tracker-filter.js
src/pkg/dashboard/static-src/js/tracker-row.js
src/pkg/dashboard/static/index.html
#15633 🌱 refactor: split stage tracker UI tests same files src/pkg/dashboard/stage_tracker_ui_test.go
src/pkg/dashboard/static/index.html
#15673 πŸ› issues the hive files carry the filing agent in the title CONFLICT src/pkg/github/issue_request_watcher.go
src/pkg/github/review_backlog_routing.go
#15669 ✨ Stream the tracker's sounds on the Activity Monitor Twitch stream same files src/pkg/dashboard/static/index.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor

hive/ci-triage (scanner): the red checks at head 3883dad are PR-local β€” v5 is green on golangci-lint and every test shard, so this is FIX_DIFF, not a shared incident. From the check-run annotations:

  • golangci-lint: func (*Client).reviewBacklogPROutcome is unused (unused) β€” delete it or wire it into the new per-finding dedupe path.
  • test (rest 3/4): pkg/github.TestReviewBacklogStateProbeErrorAppendsAndSamePRSkipsProbe fails 3/3 β€” the probe-error/same-PR-skip expectation no longer matches the one-issue-per-finding behaviour; update the test (or the behaviour) so a probe error still appends and a same-PR carried-over note does not refile.
  • test (rest 2/4): pkg/writeback.TestDirectWriteRatchet β€” "1 direct write call(s) in a file not in the baseline β€” route them through writeback.Gate.Allowed (or a solicited relay)". A new file issues a GitHub write directly; route it through the gate.
  • test (dashboard 1/4, shuffle 2/3): pkg/dashboard.TestStageTrackerSentinelLaneText fails 3/3 deterministically (not a shuffle flake) β€” the sentinel lane text changed with the title/agent-prefix work; align the fixture.

Not pushing to this branch since it is author-owned; the sweep will pick it up once green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

The reviewer swarm filed a backlog issue per perspective per head for the
same out-of-scope finding: each pass re-reported the other perspectives'
still-open notes as new findings ("Previous style note still present"),
so one finding on one PR became three issues, all blocked on the PR, and
16 of 62 open items in the activity monitor were such notes.

- Filing: each item is remembered under its PR with file, line and title;
  a later report from any perspective or head naming the same finding
  (same file and line, shared symbol, or same title once its carry-over
  wrapper and advisory qualifiers are stripped) is tracked against the
  existing item, never filed. A pure carry-over or a finding carrying
  <!-- hive-refers-to: #N --> is a reference and is dropped when it names
  nothing tracked. One "still present at <head>" comment per item per
  head, counted against the daily cap. Title dedupe ignores a leading
  [reviewer] tag.
- Prompts: perspectives, the delta section and the heads decision step
  are told to report only genuinely new findings and to cite prior notes
  with the refers-to marker.
- Block sweep: on merge the hive reads the finding's file on the PR's
  base; file or named symbol gone closes the item as completed
  (review_backlog_issue_closed audit), otherwise the block is lifted.
- Activity monitor: blocked review notes fold under their open source PR
  as one muted line (or into the group's lowest-numbered note when the
  PR is not drawn); the row count counts a group once and the header
  breakdown names the folded notes.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • coverage

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission β†’ 071-needs-author: required-check-failing:coverage

- static-src carries the tracker fold (index.html is generated from it)
- still-present notes are tracked per PR and item, so a cross-PR re-raise
  does not re-arm the note on the filing PR
- CloseItem consults the write-back gate; ratchet baseline names the file
- node harnesses past ARG_MAX read the script from stdin
- drop the unused reviewBacklogPROutcome wrapper

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@clubanderson
clubanderson merged commit 1dddc4b into v5 Oct 30, 2026
77 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/review-backlog-dedupe branch October 30, 2026 05:11
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

hivecommons-hive Bot added a commit to Karibhou/hive that referenced this pull request Oct 30, 2026
Port the v5 tracker-row.js changes (hivecommons#15657, hivecommons#15664, hivecommons#15668, hivecommons#15680) into
the split files: stageTrackerAnchor under-repair column (tracker-row.js),
acted labels (tracker-row-strip.js), queue-merge pending copy
(tracker-row-acted.js), and stageTrackerLead / left_train / subRows /
review notes (tracker-row-layout.js). static/index.html regenerated and
matches the auto-merge byte for byte.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts-with-open-pr Open PR has a merge conflict with another open PR dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ› review backlog refiles one finding as many issues: each perspective re-reports the others' still-open notes

1 participant