Repository navigation
🌱 refactor: split tracker words source - #15632
Conversation
Hive-Run: #15562 Hive-Plan: issue-15562-mechanical-split Hive-Spec: issue-15562#split-proposal Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
…#15611 prior-head note into the split tracker-words files Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
hive/awaiting-ci: merged origin/v5 (ported the #15616 / #15611 tracker-words hunks into tracker-words-core.js and tracker-words-gate.js; dashboard-gen-check passes) — CI pending, sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
…lt into tracker-words-stage.js Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Reviewed at head 309b50a5 (the PR moved on from 551b475c; the 74-file delta was a v5 rebase, the PR's own diff vs v5 is still the 6-file split).
Docs left pointing at the pre-split file
src/docs/dashboard-source-layout.md:76-83enumerates the JS units instatic-src/manifest.txt; the PR addstracker-words-core,tracker-words-stage,tracker-words-gateto the manifest (manifest.txt:66-68) but the list still names onlytracker-words. Add the three new names next totracker-words.src/pkg/dashboard/static-src/js/tracker-row.js:123saysSTAGE_TRACKER_TRAIN_ICON_PATH in tracker-words.js; it now lives intracker-words-core.js:148.src/docs/dashboard-copy-inventory.md:105locatesSTAGE_TRACKER_TRAIN_STATE_WORDand:136locatesstageTrackerSoakWordsintracker-words.js; they moved totracker-words-core.js:161andtracker-words-gate.js:363(the:71pointer forstageTrackerHolderPresenceHtmlis still correct — it stayed intracker-words.js:180).
— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Reviewed (style, delta 1f5a879 → 551b475; also read the later v5 merge 309b50a) — split verified mechanical: the four files hold the same 198 declarations as v5's tracker-words.js with identical bodies, and manifest.txt:66-69 loads them in a safe order (the only top-level call, stageTrackerDefaultFilter() at tracker-words-stage.js:103, reads STAGE_TRACKER_DEFAULT_PAGE_SIZE from tracker-words-stage.js:49).
- low, advisory:
src/docs/dashboard-source-layout.md:78enumerates thejs/units and still lists onlytracker-words; addtracker-words-core,tracker-words-stage,tracker-words-gateso the layout doc matchesmanifest.txt:66-68.
— hive: agent=adjudicator-4 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Supersedes #15565 (adopted after CI went red and the contributor was unavailable; original commits by @Karibhou preserved).
Closes #15562
This branch is #15565's head
1f5a879f7ddeas pushed by @Karibhou (forkKaribhou/hive), unchanged. Last lane reason on the original:conflicting.Hive fix agent: rebase this branch on
v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and theirSigned-off-by; add your own sign-off on your commits. Do not open another PR.Conflicts with
v5: the contributor head could not be replayed onto the base, so this copy opened as it is and the hive's fixer is resolving the conflicts on this branch (rebase-resolve episode, two attempts). If both fail the PR parks for a person: adopt the commits into a fresh branch, or close it as superseded.