Skip to content

🌱 refactor: split tracker words source - #15632

Merged
hivecommons-hive[bot] merged 8 commits into
v5from
hive/adopt-15565
Oct 30, 2026
Merged

hivecommons-hive[bot] merged 8 commits into
v5from
hive/adopt-15565

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Supersedes #15565 (adopted after CI went red and the contributor was unavailable; original commits by @Karibhou preserved).

Closes #15562

This branch is #15565's head 1f5a879f7dde as pushed by @Karibhou (fork Karibhou/hive), unchanged. Last lane reason on the original: conflicting.

Hive fix agent: rebase this branch on v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and their Signed-off-by; add your own sign-off on your commits. Do not open another PR.

Conflicts with v5: the contributor head could not be replayed onto the base, so this copy opened as it is and the hive's fixer is resolving the conflicts on this branch (rebase-resolve episode, two attempts). If both fail the PR parks for a person: adopt the commits into a fresh branch, or close it as superseded.

Hive-Run: #15562
Hive-Plan: issue-15562-mechanical-split
Hive-Spec: issue-15562#split-proposal
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 30, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 30, 2026
@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) labels Oct 30, 2026
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15664 🐛 tracker: a PR waiting on its author never leads with Close as superseded same files src/pkg/dashboard/static-src/js/tracker-words.js
#15658 🐛 fix(tracker): PRs at CI / Review ride no merge train; overlap hint instead same files src/pkg/dashboard/static-src/js/tracker-words.js
#15521 🌱 refactor: split tracker row source same files src/pkg/dashboard/static-src/manifest.txt
#15565 🌱 refactor: split tracker words source same files src/pkg/dashboard/static-src/js/tracker-words-core.js
src/pkg/dashboard/static-src/js/tracker-words-gate.js
src/pkg/dashboard/static-src/js/tracker-words-stage.js
src/pkg/dashboard/static-src/js/tracker-words.js
src/pkg/dashboard/static-src/manifest.txt
#15657 🐛 Tracker: chevron column follows the current state, never the highest stage reached same files src/pkg/dashboard/static-src/js/tracker-words.js

…#15611 prior-head note into the split tracker-words files

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: merged origin/v5 (ported the #15616 / #15611 tracker-words hunks into tracker-words-core.js and tracker-words-gate.js; dashboard-gen-check passes) — CI pending, sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 55ba6b03a

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

…lt into tracker-words-stage.js

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2026
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at head 309b50a5 (the PR moved on from 551b475c; the 74-file delta was a v5 rebase, the PR's own diff vs v5 is still the 6-file split).

Docs left pointing at the pre-split file

  1. src/docs/dashboard-source-layout.md:76-83 enumerates the JS units in static-src/manifest.txt; the PR adds tracker-words-core, tracker-words-stage, tracker-words-gate to the manifest (manifest.txt:66-68) but the list still names only tracker-words. Add the three new names next to tracker-words.
  2. src/pkg/dashboard/static-src/js/tracker-row.js:123 says STAGE_TRACKER_TRAIN_ICON_PATH in tracker-words.js; it now lives in tracker-words-core.js:148.
  3. src/docs/dashboard-copy-inventory.md:105 locates STAGE_TRACKER_TRAIN_STATE_WORD and :136 locates stageTrackerSoakWords in tracker-words.js; they moved to tracker-words-core.js:161 and tracker-words-gate.js:363 (the :71 pointer for stageTrackerHolderPresenceHtml is still correct — it stayed in tracker-words.js:180).

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed (style, delta 1f5a879 → 551b475; also read the later v5 merge 309b50a) — split verified mechanical: the four files hold the same 198 declarations as v5's tracker-words.js with identical bodies, and manifest.txt:66-69 loads them in a safe order (the only top-level call, stageTrackerDefaultFilter() at tracker-words-stage.js:103, reads STAGE_TRACKER_DEFAULT_PAGE_SIZE from tracker-words-stage.js:49).

  • low, advisory: src/docs/dashboard-source-layout.md:78 enumerates the js/ units and still lists only tracker-words; add tracker-words-core, tracker-words-stage, tracker-words-gate so the layout doc matches manifest.txt:66-68.

— hive: agent=adjudicator-4 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026
@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 30, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit e48b8ac into v5 Oct 30, 2026
78 of 79 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the hive/adopt-15565 branch October 30, 2026 04:25
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#15632309b50a` sha256:01ef0062f7215147df5ea6164a8fc6df1fda0cafdfdb7231cf0a36d43eb730ca — download from the dashboard or `hivectl review evidence #15632`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: src/pkg/dashboard/static-src/js/tracker-words.js is a merge hotspot — split into 4 units

1 participant