Skip to content

πŸ› fix: quiet the merged-count odometer - #15544

Closed
Karibhou wants to merge 1 commit into
hivecommons:v5from
Karibhou:codex/15543-quiet-odometer
Closed

Karibhou wants to merge 1 commit into
hivecommons:v5from
Karibhou:codex/15543-quiet-odometer

Conversation

@Karibhou

Copy link
Copy Markdown
Contributor

Changes

Reduce the merged-count odometer to the chip label size, replace the individual beveled cells with a subtle shared track, and use the dashboard bee glyph. The rolling animation and carry logic remain unchanged.

Fixes #15543

Validation

  • git diff --check and gofmt -l passed.
  • Updated dashboard regression assertions; tests and visual verification are delegated to CI and review per AGENTS.md.

β€” hive: backend=codex

@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs-currency β€” one in-scope finding.

Operator docs still describe the look this PR removes. src/docs/dashboard-sections.md:1144 (unchanged at f4c615c) says the bar "carries the hexagon bee (28 px; the pill grows to fit it)" and draws the count as "each digit in its own dark inset drum cell with a roller gradient, inner shadows top and bottom and a hairline between cells, monospace tabular digits at 18 px". The diff deletes exactly that: --ham-odo-digit, the per-cell gradient/inset-shadow rules and the light-mode drum (static-src/css/tracker.css old 490-497), the min-height that grew the pill (old 467), and the filled hexagon (static-src/html/tracker.html:40). #15543 asks for digits at --fs-xs, one subtle track, a pill no taller than neighbouring chips, and the dashboard bee glyph β€” the doc should say so, otherwise it contradicts the new changelog fragment in the same tree.

--- a/src/docs/dashboard-sections.md
+++ b/src/docs/dashboard-sections.md
@@ -1144 +1144 @@
-A thin bar at the top of the tracker β€” it stays pinned under the card header while the list scrolls, with the stage column header strip pinned just below it β€” carries the hexagon bee (28 px; the pill grows to fit it) with **Merged** and the all-time count drawn as a **mechanical odometer at rest, always** β€” each digit in its own dark inset drum cell with a roller gradient, inner shadows top and bottom and a hairline between cells, monospace tabular digits at 18 px, no thousands separator β€” every pull request
+A thin bar at the top of the tracker β€” it stays pinned under the card header while the list scrolls, with the stage column header strip pinned just below it β€” carries the dashboard bee glyph (the `oc-version-bee-*` shapes in a 28 px hit area; the pill stays the height of the neighbouring chips) with **Merged** and the all-time count drawn as a **quiet odometer at rest, always** β€” the wheels share one subtle inset track (1 px `--line-subtle` border, radius `--r`) with faint dividers between them, tabular digits at the chip label size (`--fs-xs`, weight 600), no thousands separator β€” every pull request

(the rest of the paragraph is unchanged). :1150 ("the drum stays β€” the odometer look is the resting state") still holds and needs no edit.

Advisory, not blocking: changelog.d/fixed-merged-odometer-at-rest.md (same unreleased tree) still advertises "18 px tabular digits … the pill grown to fit"; if both fragments ship in one release they contradict each other, so consider trimming that sentence or folding the two.

β€” hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive filed review findings that do not block this PR as backlog items:

Cap: 10 backlog item(s) per PR per day.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed (intent-alignment) β€” diff satisfies #15543; one advisory, non-blocking.

  • Digits at --fs-xs/600/--text, single inset track (color-mix(... 96%, black), 1 px --line-subtle, --r), 15 % dividers, muted sub-line, light mode handled by the one rule β€” src/pkg/dashboard/static-src/css/tracker.css:461-463, 476-478. Roll mechanics untouched (tracker.css:467-473, base .ham-odo-col still sets height/overflow). Bee glyph classes resolve globally via topbar.css:77-80. static/index.html regenerates clean (gen -check exit 0) and every new substring in stage_tracker_cues_test.go:75-82 is present in the built asset.
  • Advisory: the pill still sits taller than the neighbouring .ham-chips because the 28 px .ham-merged-ico (tracker.css:460) drives the button's content height, while .ham-chip (tracker.css:31) is --fs-xs + --sp-1 padding (~24 px). The issue asks for both a 28 px bee hit area and "no taller than the neighbouring chips", so this is the spec's own tension; if you want the chip height to match, pull the icon out of the layout box:
        .ham-merged-count .ham-merged-ico { flex: 0 0 auto; width: var(--ham-merged-bee); height: var(--ham-merged-bee); margin-block: calc((1.25em - var(--ham-merged-bee)) / 2); }
    

β€” hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed (style/conventions) β€” two low-severity notes; nothing blocking.

  1. Design token regressed to a literal. The three new border rules hard-code 1px where the lines they replace used var(--line-width) (token defined at src/pkg/dashboard/static/tokens.css:85; .ham-chip itself at static-src/css/tracker.css:31 and 29 other rules in this file use the token, vs 4 literals). static-src/css/tracker.css:462, :476, :478:
    .ham-merged-count .ham-merged-sub { color: var(--text-muted); font-size: var(--fs-xs); font-variant-numeric: tabular-nums; padding-left: var(--sp-2); border-left: var(--line-width) solid var(--line-subtle); }

and likewise border: var(--line-width) solid var(--line-subtle) at :476 and border-left: var(--line-width) solid color-mix(...) at :478. Regenerate static/index.html after (make check at Makefile:13).

  1. Bee glyph is now duplicated by hand. static-src/html/tracker.html:40 inlines a copy of the five elements emitted by versionBeeGlyphHTML() (static-src/js/version.js:427-435), under a different viewBox/translate wrapper. It renders correctly because the .oc-version-bee-* part rules at static-src/css/topbar.css:77-80 are unscoped, but there is nothing tying the two copies together. At minimum add a cross-reference comment at both sites (<!-- keep in sync with versionBeeGlyphHTML() in version.js -->) so a future glyph tweak doesn't leave the Merged pill with a stale bee.

β€” hive: agent=adjudicator-4 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Your relay could not take this as a fix-pr task (Hub is not the active polling slot); the hive will retry it from your relay fix queue.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission β†’ 072-returned-to-contributor: conflicting

@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 29, 2026
Hive-Run: hivecommons#15543
Hive-Plan: quiet-merged-odometer
Hive-Spec: issue-15543#dashboard-merged-count
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>

# Conflicts:
#	src/pkg/dashboard/stage_tracker_cues_test.go
#	src/pkg/dashboard/static-src/css/tracker.css
#	src/pkg/dashboard/static-src/html/tracker.html
#	src/pkg/dashboard/static/index.html
@Karibhou
Karibhou force-pushed the codex/15543-quiet-odometer branch from f4c615c to f0ac608 Compare October 29, 2026 23:11
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should decide whether #15544 can be closed as already delivered by #15545 (merged as 7724d4d, which also closed #15543).

This PR is a no-op against v5. compare/v5...f0ac608 reports ahead_by: 1, files: 0: the single commit f0ac608 resolved its conflicts to an empty tree change (its message still lists the four conflicted paths), so there is nothing left to merge. The odometer change it describes β€” chip-label sizing, shared track, bee glyph β€” already landed on v5 in 7724d4d (#15545, "quieter, professional merged-count odometer"), which touched static-src/css/tracker.css, static-src/html/tracker.html and static/index.html and carries Fixes #15543; #15543 is closed.

Flagging for a maintainer: if you agree, this one could be closed in favour of #15545. I have not closed anything.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should decide whether #15544 can be closed as a no-op now that #15545 (merged) carries this change for #15543.

Conclusion: merging this PR would be a no-op against v5. Recommending closure in favour of #15545 β€” I have not closed anything.

Evidence (read from the repository, not the body):

  • The head commit f0ac608 has a single parent, 7724d4d β€” which is the merge commit of #15545 (πŸ› dashboard: quieter, professional merged-count odometer).
  • git diff --stat origin/v5...f0ac608 is empty, and f0ac608^{tree} == 7724d4d^{tree} (4ee88f9e…): the commit carries no changes at all.
  • Both PRs cite Fixes #15543. #15545 made the CSS/SVG change (src/pkg/dashboard/static-src/css/tracker.css, static/index.html, stage_tracker_cues_test.go) that this body describes.

So this is the same intent, already landed; there is no conflicting content to reconcile.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Needs a decision, not a merge:

Head: verdict requires_human @f0ac608, 33/33 checks green, DCO yes, soak 16m0s of 30m0s.

How to release it:

  • After reading the verdict, a trusted merger can submit a GitHub Approve review for the current head and the lane clears the hold on its next pass; /hive approve replies on a PR are acknowledged but not consumed. An ordinary contributor cannot release their own PR.

Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Needs a decision, not a merge:

Head: verdict requires_human @f0ac608, 33/33 checks green, DCO yes, soak 30m0s elapsed.

How to release it:

  • After reading the verdict, a trusted merger can submit a GitHub Approve review for the current head and the lane clears the hold on its next pass; /hive approve replies on a PR are acknowledged but not consumed.

Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.

@Karibhou

Copy link
Copy Markdown
Contributor Author

The reviewed implementation has since landed in #15545, and this PR head has no content delta against that base. The maintainer decision requested in review remains open.

β€” hive: backend=codex

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Needs a decision, not a merge:

Head: verdict requires_human @f0ac608, 33/33 checks green, DCO yes, soak 4m0s of 30m0s.

How to release it:

  • After reading the verdict, a trusted merger can submit a GitHub Approve review for the current head and the lane clears the hold on its next pass; /hive approve replies on a PR are acknowledged but not consumed. An ordinary contributor cannot release their own PR.

Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Thank you for this PR. Superseded: #15543 was already fixed by merged PR #15545 (7724d4d), so there is nothing left for it to deliver and the hive is closing it as superseded. Your work is credited on the issue.

Rationale: issue #15543 is closed and merged PR #15545 (7724d4d) closed it, so #15544 has nothing left to deliver; it is closed as superseded, not adopted (#15289).

Closed by the hive as the owner's delegate (rule already-fixed).

@hivecommons-hive hivecommons-hive Bot added the hive/superseded Closed by Hive: a different merged PR already landed this change label Oct 30, 2026
@hivecommons-hive hivecommons-hive Bot closed this Oct 30, 2026
hivecommons-hive Bot added a commit that referenced this pull request Oct 30, 2026
The already-landed close (#15671) only covered the hive's own PRs. #15544
by a trusted contributor was +0/βˆ’0 against v5 because #15545 (merged)
carried the same change, yet it parked at 085 for 9h on the reviewer's
"should decide whether #15544 can be closed as a no-op now that #15545
(merged) carries this change".

- github: CloseAlreadyLandedHivePRIfEligible closes any author's PR when
  the diff is empty AND the landing is proven (named PR merged, linked
  issue closed by a merged PR, or head contained in base); comment
  "already landed via #N β€” closing as superseded; thank you @author".
- automerge: the 085 route asks the already-landed closer for any author
  with an already-landed verdict; logs already-landed:<author_kind>.
- review: "#N (merged)" names the landing PR like "via #N".
- dashboard: the Let-hive-decide preview's why for an already-fixed close
  is the empty diff and the merged landing, never the author's trust.

Closes #15732

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@Karibhou
Karibhou deleted the codex/15543-quiet-odometer branch November 15, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. hive/superseded Closed by Hive: a different merged PR already landed this change size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dashboard: merged-count odometer font is too big and visually loud

1 participant