Skip to content

Activity Monitor: stalled merge-queue chevrons render with no words (#15529, #15530 behind #15425) #15546

Closed

Description

@clubanderson

Owner screenshot (22:34Z, hive's hive on v5 3ef38e6): PR rows #15530 and #15529 both show an active amber chevron in the Merge queue column that is empty — just the ⟳ glyph and the actor hex, no words.

API rows (/api/stage-tracker): stage 80, merge_gate.state=queued-behind (sweep_running true), merge_train: {state:"queued-behind", front:15425, position:2|3, size:3, head_state:"needs-human", head_reason:"waiting for a maintainer (untrusted author)", stalled:true, stalled_s:4851}.

Cause: the stalled path in tracker-words.js (stageTrackerTrainStalledWord) did return words ("Merge queue stalled · head #15425 waiting for a maintainer (untrusted author) 1h21m"), but tracker.css .ham-queue-stalled { color: var(--yellow); } (#15427) paints them ochre inside the amber .ham-seg.active fill — effectively invisible. This is the first stalled train rendered since that rule landed (a train only reads stalled after governor.merge_train_stall_warn_s = 3600s).

Fix: the stalled text inherits the chevron colour on an active segment; wording becomes Merge queue · stalled — waiting on #15425 (needs maintainer merge) · 1h21m (head row: Merge queue · stalled — needs maintainer merge · 1h21m); every head_state maps to a why; an unmapped merge_train.state falls back to its humanised name plus place, never empty. Ratchet tests (node: every state × stalled × head_state × place; Go: every emitted merge_train carries a documented state) guard it.

Train admission for the untrusted-author head #15425 is handled separately; this issue is wording/contrast only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions