Repository navigation
π fix: keep the header's right chips from overlapping the title at 769-900px - #14656
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@Karibhou this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
826e4eb to
49bb54b
Compare
|
@Karibhou this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (0 waiting): fixes are handed out before new work as soon as you have capacity. |
|
@Karibhou the hive has adopted this PR ( |
|
hive/check-report (head π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
There was a problem hiding this comment.
Looks correct to me; the one red check is runner infrastructure, not this diff.
Verified against v5 at 49bb54b:
- The previous guard at
static/index.html:561started at901px, leaving 769β900px with the right cluster free to shrink and overflowflex-endover the title β exactly the band #13135 reports. Widening it to769pxcloses that gap, and theβ€768pxblock already handles the phone case separately. - The three selectors added in the 769β900px block resolve to real elements:
#oc-settings-btn(index.html:6650),.oc-health-badge(:6655) and#welcome-topbar-btn(:6656) each wrap their text in.nav-chip__label, so hiding the label leaves the icon/dot and thearia-label/titleintact. navbar_header_overlap_13135_test.gopins both the widened range and the label hiding, and fails on the old901pxform.
CI: test (dashboard shuffle 2/3) failed in the Install gotestsum step (job 122391653079: proxy.golang.org ... golang.org/x/text@v0.17.0 ... INTERNAL_ERROR plus the "npm is not on PATH after actions/setup-node ... see #10518" marker). No test ran; a re-run should go green without changes.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Looks correct to me, and the red check is not this PR's fault.
- The three selectors added at 769β900px (
.oc-health-badge .nav-chip__label,#oc-settings-btn .nav-chip__label,#welcome-topbar-btn .nav-chip__label) are the exact rule the tree already uses to go icon-only inside the@media (max-width: 768px)block (src/pkg/dashboard/static/index.html:4999, rules at:5064-5066) and the coarse-pointer landscape block (:5571). This fills the width band between them with the same idiom rather than inventing a new one; each id/class resolves to exactly one element in the file. - Widening the
min-width: max-contentguard from901pxto769pxis consistent with the existing769pxβ900pxblock that already hides#acmm-badge, so the two breakpoints now agree. test (dashboard shuffle 2/3)failed withgolang.org/x/text@v0.17.0: read "https://proxy.golang.org/...": stream error: INTERNAL_ERRORwhile downloading modules (run 40561485615) β a runner/proxy fault, not a test failure. A re-run should go green; the sibling dashboard shards passed.
I can't render the layout from here, so the pixel outcome at 769β900px is confirmed by the author's description rather than by me.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
β¦9-900px The hivecommons#13173 fix pinned .oc-topbar-right to max-content only from 901px, so at 769-900px the cluster shrank to 0, its nowrap flex-end chips overflowed leftwards and the feedback/theme buttons painted over the project title. Extend the guard down to 769px (the phone block takes over below) and drop the Settings/Health/Guide labels in that band so the drawer toggle and title keep room. Fixes hivecommons#13135 Hive-Run: hivecommons#13135 Hive-Plan: dashboard-header-overlap Hive-Spec: dashboard-navbar#13135 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HRH6kizfUBgiWsEGGur6Rr Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
49bb54b to
0bc4d72
Compare
|
hive/awaiting-ci: rebased the adopted branch onto the current π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
There was a problem hiding this comment.
Looks correct to me. I read the surrounding rules in src/pkg/dashboard/static/index.html rather than just the diff: the @media (max-width: 1280px) block (lines 545-557) sets .oc-topbar-right { justify-content: flex-end; flex-wrap: nowrap; overflow: visible; } with no min-width, so in the 769-900px band the cluster could shrink and its nowrap chips overflowed leftwards β exactly the mechanism the commit message describes. Extending the min-width: max-content guard from 901px down to 769px closes that band, and hiding .oc-health-badge/#oc-settings-btn/#welcome-topbar-btn .nav-chip__label there reuses the same selector set the phone blocks already use (lines 5073-5076 and 5580-5583), so there is no new idiom and no conflicting later rule for β₯769px. The string-match test follows the existing indexHTML(t) helper pattern (clickable_avatars_test.go:12) and the negative assertion on the old 901px prefix means it fails without the change.
One non-code gap for a maintainer: the PR body is empty apart from the agent trailer β the rationale and Fixes #13135 exist only in the commit message. GitHub only auto-closes from commit-message keywords on the default branch, so if v5 is not default the issue stays open after merge. Adding Fixes #13135 plus the two-sentence WHY from the commit to the PR body would make the link reliable and give the diff its explanation where reviewers look first.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Read the topbar CSS on this head around the three touched blocks. The change is consistent with the existing #13135 fix: at 769β900px the grid is still auto minmax(0, 1fr) auto (index.html:369), the left cell already has min-width: 0; overflow: hidden with the title ellipsised (index.html:383, :553), so widening the min-width: max-content rule from 901px down to 769px lets the right cell claim its width and the centre/left tracks absorb it rather than painting over the badge. Hiding the Health/Settings/Guide labels in the same 769β900 band reuses the exact selector list the β€768px block already uses (index.html:5073-5075), and the β€600px single-column block (index.html:907) is unaffected. I could not drive a browser from here, so the overlap itself is unverified by me; nothing in the CSS contradicts the claim. Looks correct to me.
One thing for a maintainer rather than the code:
- The PR body is empty β no
Closes #13135. Only the changelog fragment names the issue, which GitHub does not read for linking, so merging this will leave #13135 open. If this is the complete fix, the body should carryCloses #13135(orRefs #13135with what remains, if not).
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
The failing required check π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
Suggestion: add π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
There was a problem hiding this comment.
Looks correct to me from the stylesheet; I could not render it, so treat the visual result as unverified by me.
What I checked at e7c7dd7 against v5 src/pkg/dashboard/static/index.html:
- The overlap mechanism is real: the base rule at
index.html:482gives.oc-topbar-rightmin-width: 0; justify-content: flex-end, and theβ€1280pxblock (:545-557) setsoverflow: visible, so when the cluster is squeezed its flex-end overflow paints leftward over the title/badge. The existing fix (:561-563) only applied from 901px β 769β900 was left with the overlapping behaviour. Extending it down to 769 is the right boundary: theβ€768pxblock (:5004,.oc-topbar-right { overflow: hidden }at:5021-5029) clips the cluster instead, exactly as the new CSS comment says. - The three label selectors hidden in 769β900 all exist:
#oc-settings-btn(:6655),.oc-health-badge(:6660),#welcome-topbar-btn(:6661), each with a.nav-chip__labelspan, so the icon-only fallback has something to hide and the icon/dot remains. - The new
navbar_header_overlap_13135_test.goasserts the exact media-query text and fails if the 901px lower bound returns, so a regression of this specific fix would be caught.
One heads-up for whoever merges: #13135 is currently also held by a hive scanner session, so a second PR for the same issue may appear; this one is small and already carries a guard test.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Looks correct to me β checked against src/pkg/dashboard/static/index.html at e7c7dd7.
- The three new selectors hit real elements that each carry a
.nav-chip__labelchild:#oc-settings-btn(line 6659),.oc-health-badge/#oc-health(6664),#welcome-topbar-btn(6665). Settings and Guide keep theirtitle/aria-label, so going icon-only at 769β900px loses no accessible name. - Widening the
min-width: max-contentrule from901pxto769pxis consistent with the existing phone block: at β€768px.oc-topbar-rightalready getsflex-wrap: nowrap; overflow: visible(line 556), so the two ranges now meet without a gap where the cluster could shrink and overflow onto the title. - The new test asserts the exact CSS text via the existing
indexHTMLhelper (clickable_avatars_test.go:12) and would fail on the pre-PR901pxbreakpoint, so it does guard the regression.
One non-blocking note: #oc-health has no title/aria-label, so hiding "Health OK" at 769β900px leaves only the coloured dot (status becomes colour-only there). The β€768px block already hides the whole badge, so this isn't new in kind β but a title on the span would be a cheap improvement if you touch it again.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Merged by hive contributor-lane auto-merge: CI green for β₯30m, reviewer verdict approve, head |
π Hive Agent:
contributor| SHA:826e4eb7bβ hive: backend=claude model=claude-opus-5-5 claude=2.1.311 (Claude Code)
Closes #13135