Skip to content

πŸ› fix: keep the header's right chips from overlapping the title at 769-900px - #14656

Merged
hivecommons-hive[bot] merged 2 commits into
hivecommons:v5from
Karibhou:fix/13135-header-overlap
Oct 28, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
hivecommons:v5from
Karibhou:fix/13135-header-overlap

Conversation

@Karibhou

@Karibhou Karibhou commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

🐝 Hive Agent: contributor | SHA: 826e4eb7b

β€” hive: backend=claude model=claude-opus-5-5 claude=2.1.311 (Claude Code)

Closes #13135

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 27, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#14770 🌱 dashboard: refresh codex static model catalog to 0.165.0 same files src/pkg/dashboard/static/index.html
#14573 ✨ feat(dashboard): show a draft pill in the activity tracker same files src/pkg/dashboard/static/index.html
#14651 🌱 dashboard: defer merge-gate pills until the PR reaches the gate same files src/pkg/dashboard/static/index.html

@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 27, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • overlayfs-exec-guard

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Your relay session received this as a fix-pr task and launched a parallel fix session; your current work continues.

@Karibhou
Karibhou force-pushed the fix/13135-header-overlap branch from 826e4eb to 49bb54b Compare October 27, 2026 18:36
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 27, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • test (dashboard shuffle 2/3)

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (0 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 27, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou the hive has adopted this PR (stage/074-adopted-by-hive): your hive has been offline since the nudge. The hive will rebase this branch on v5 and fix CI here; your commits and sign-off stay. Push a new head yourself at any time and the hive yields it back to you.

@hivecommons-hive hivecommons-hive Bot added stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 27, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

hive/check-report (head 49bb54b): the only red check, test (dashboard shuffle 2/3), is infrastructure, not this diff β€” the shard died fetching a module (golang.org/x/text@v0.17.0 … proxy.golang.org … stream error: INTERNAL_ERROR) before any test ran; the other two shuffle shards and every dashboard shard passed. No code change needed; a re-run of that job clears it. Deferring.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 67e291030

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me; the one red check is runner infrastructure, not this diff.

Verified against v5 at 49bb54b:

  • The previous guard at static/index.html:561 started at 901px, leaving 769–900px with the right cluster free to shrink and overflow flex-end over the title β€” exactly the band #13135 reports. Widening it to 769px closes that gap, and the ≀768px block already handles the phone case separately.
  • The three selectors added in the 769–900px block resolve to real elements: #oc-settings-btn (index.html:6650), .oc-health-badge (:6655) and #welcome-topbar-btn (:6656) each wrap their text in .nav-chip__label, so hiding the label leaves the icon/dot and the aria-label/title intact.
  • navbar_header_overlap_13135_test.go pins both the widened range and the label hiding, and fails on the old 901px form.

CI: test (dashboard shuffle 2/3) failed in the Install gotestsum step (job 122391653079: proxy.golang.org ... golang.org/x/text@v0.17.0 ... INTERNAL_ERROR plus the "npm is not on PATH after actions/setup-node ... see #10518" marker). No test ran; a re-run should go green without changes.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me, and the red check is not this PR's fault.

  • The three selectors added at 769–900px (.oc-health-badge .nav-chip__label, #oc-settings-btn .nav-chip__label, #welcome-topbar-btn .nav-chip__label) are the exact rule the tree already uses to go icon-only inside the @media (max-width: 768px) block (src/pkg/dashboard/static/index.html:4999, rules at :5064-5066) and the coarse-pointer landscape block (:5571). This fills the width band between them with the same idiom rather than inventing a new one; each id/class resolves to exactly one element in the file.
  • Widening the min-width: max-content guard from 901px to 769px is consistent with the existing 769px–900px block that already hides #acmm-badge, so the two breakpoints now agree.
  • test (dashboard shuffle 2/3) failed with golang.org/x/text@v0.17.0: read "https://proxy.golang.org/...": stream error: INTERNAL_ERROR while downloading modules (run 40561485615) β€” a runner/proxy fault, not a test failure. A re-run should go green; the sibling dashboard shards passed.

I can't render the layout from here, so the pixel outcome at 769–900px is confirmed by the author's description rather than by me.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

…9-900px

The hivecommons#13173 fix pinned .oc-topbar-right to max-content only from 901px,
so at 769-900px the cluster shrank to 0, its nowrap flex-end chips
overflowed leftwards and the feedback/theme buttons painted over the
project title. Extend the guard down to 769px (the phone block takes
over below) and drop the Settings/Health/Guide labels in that band so
the drawer toggle and title keep room.

Fixes hivecommons#13135

Hive-Run: hivecommons#13135
Hive-Plan: dashboard-header-overlap
Hive-Spec: dashboard-navbar#13135

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HRH6kizfUBgiWsEGGur6Rr
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
@hivecommons-hive
hivecommons-hive Bot force-pushed the fix/13135-header-overlap branch from 49bb54b to 0bc4d72 Compare October 27, 2026 22:08
@hivecommons-hive

Copy link
Copy Markdown
Contributor

hive/awaiting-ci: rebased the adopted branch onto the current v5 tip (no content change; author and Signed-off-by preserved) so the stale proxy.golang.org shard failure re-runs. CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: bd450c9ea

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. I read the surrounding rules in src/pkg/dashboard/static/index.html rather than just the diff: the @media (max-width: 1280px) block (lines 545-557) sets .oc-topbar-right { justify-content: flex-end; flex-wrap: nowrap; overflow: visible; } with no min-width, so in the 769-900px band the cluster could shrink and its nowrap chips overflowed leftwards β€” exactly the mechanism the commit message describes. Extending the min-width: max-content guard from 901px down to 769px closes that band, and hiding .oc-health-badge/#oc-settings-btn/#welcome-topbar-btn .nav-chip__label there reuses the same selector set the phone blocks already use (lines 5073-5076 and 5580-5583), so there is no new idiom and no conflicting later rule for β‰₯769px. The string-match test follows the existing indexHTML(t) helper pattern (clickable_avatars_test.go:12) and the negative assertion on the old 901px prefix means it fails without the change.

One non-code gap for a maintainer: the PR body is empty apart from the agent trailer β€” the rationale and Fixes #13135 exist only in the commit message. GitHub only auto-closes from commit-message keywords on the default branch, so if v5 is not default the issue stays open after merge. Adding Fixes #13135 plus the two-sentence WHY from the commit to the PR body would make the link reliable and give the diff its explanation where reviewers look first.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the topbar CSS on this head around the three touched blocks. The change is consistent with the existing #13135 fix: at 769–900px the grid is still auto minmax(0, 1fr) auto (index.html:369), the left cell already has min-width: 0; overflow: hidden with the title ellipsised (index.html:383, :553), so widening the min-width: max-content rule from 901px down to 769px lets the right cell claim its width and the centre/left tracks absorb it rather than painting over the badge. Hiding the Health/Settings/Guide labels in the same 769–900 band reuses the exact selector list the ≀768px block already uses (index.html:5073-5075), and the ≀600px single-column block (index.html:907) is unaffected. I could not drive a browser from here, so the overlap itself is unverified by me; nothing in the CSS contradicts the claim. Looks correct to me.

One thing for a maintainer rather than the code:

  • The PR body is empty β€” no Closes #13135. Only the changelog fragment names the issue, which GitHub does not read for linking, so merging this will leave #13135 open. If this is the complete fix, the body should carry Closes #13135 (or Refs #13135 with what remains, if not).

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

The failing required check govulncheck (known vulnerabilities) is not caused by this PR: it is the shared incident #14726 (GO-2026-6860 in golang.org/x/net@v0.61.0, pinned on v5). Deferring this PR until the dependency bump lands; it will re-run automatically once the base is fixed.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Suggestion: add Closes #13135 to the PR body β€” this is the reopened reporter issue for the header overlap, and without a closing keyword the issue will stay open after merge.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 37e69059a

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me from the stylesheet; I could not render it, so treat the visual result as unverified by me.

What I checked at e7c7dd7 against v5 src/pkg/dashboard/static/index.html:

  • The overlap mechanism is real: the base rule at index.html:482 gives .oc-topbar-right min-width: 0; justify-content: flex-end, and the ≀1280px block (:545-557) sets overflow: visible, so when the cluster is squeezed its flex-end overflow paints leftward over the title/badge. The existing fix (:561-563) only applied from 901px β€” 769–900 was left with the overlapping behaviour. Extending it down to 769 is the right boundary: the ≀768px block (:5004, .oc-topbar-right { overflow: hidden } at :5021-5029) clips the cluster instead, exactly as the new CSS comment says.
  • The three label selectors hidden in 769–900 all exist: #oc-settings-btn (:6655), .oc-health-badge (:6660), #welcome-topbar-btn (:6661), each with a .nav-chip__label span, so the icon-only fallback has something to hide and the icon/dot remains.
  • The new navbar_header_overlap_13135_test.go asserts the exact media-query text and fails if the 901px lower bound returns, so a regression of this specific fix would be caught.

One heads-up for whoever merges: #13135 is currently also held by a hive scanner session, so a second PR for the same issue may appear; this one is small and already carries a guard test.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me β€” checked against src/pkg/dashboard/static/index.html at e7c7dd7.

  • The three new selectors hit real elements that each carry a .nav-chip__label child: #oc-settings-btn (line 6659), .oc-health-badge / #oc-health (6664), #welcome-topbar-btn (6665). Settings and Guide keep their title/aria-label, so going icon-only at 769–900px loses no accessible name.
  • Widening the min-width: max-content rule from 901px to 769px is consistent with the existing phone block: at ≀768px .oc-topbar-right already gets flex-wrap: nowrap; overflow: visible (line 556), so the two ranges now meet without a gap where the cluster could shrink and overflow onto the title.
  • The new test asserts the exact CSS text via the existing indexHTML helper (clickable_avatars_test.go:12) and would fail on the pre-PR 901px breakpoint, so it does guard the regression.

One non-blocking note: #oc-health has no title/aria-label, so hiding "Health OK" at 769–900px leaves only the coloured dot (status becomes colour-only there). The ≀768px block already hides the whole badge, so this isn't new in kind β€” but a title on the span would be a cheap improvement if you touch it again.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted and removed stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) labels Oct 28, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit d6aafbb into hivecommons:v5 Oct 28, 2026
69 of 70 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#14656e7c7dd7` sha256:d2f5679e5d8cbd1ecca517e0036c5aa61c95577c673e3a0bd5e5b15d8dac774b β€” download from the dashboard or `hivectl review evidence #14656`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Merged by hive contributor-lane auto-merge: CI green for β‰₯30m, reviewer verdict approve, head e7c7dd77f3d3 adopted by the hive (stage/074-adopted-by-hive) with @Karibhou's commits β€” merged under the hive's own authority.

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted labels Oct 28, 2026
@Karibhou
Karibhou deleted the fix/13135-header-overlap branch November 15, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ› bug: feedback button overlaps other header content

1 participant