Repository navigation
✨ dashboard: say why a PR is waiting on a human merge - #14669
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
|
@clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
|
Heads-up from #14672 (owner approval releases the workflow-path fence, #14664): after that lands, |
|
@clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
Every stage/090 row's merge-gate word, tooltip, headline and nested sub-row now carry a compact reason code (prstage.HumanMergeReason*) derived from the lane reason already on the stage record — workflow files, tests removed, manual-merge policy, branch protection, merge method, auto-merge off, untrusted author, unauthorized, reviewer deferred, falling back to policy with the raw lane reason quoted. Fixes #14658 Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
…eason Signed-off-by: Andy Anderson <andy@clubanderson.com>
3e69436 to
9f3b886
Compare
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Why
The tracker's merge-gate cell for a
stage/090-ready-for-human-mergePR read just "Ready for human merge 👤" (or "Awaiting human merge · approved by @login") and never said why a person, not the hive, has to click Merge — e.g. rationguard#401 changes.github/workflows/mutation.yml, which the hive never merges (and its App lacks theworkflowspermission). Same on hive#14568 / #14498.Fixes #14658
What
pkg/stageengine/prstage:HumanMergeReason(reason)derives a compact code from the lane reason already persisted on the 090 stage record (no second store):workflow-files,tests-removed,manual-merge-policy,branch-protection,merge-method,auto-merge-off,untrusted-author(every trust reason),unauthorized(✨ feat: mark lanes unauthorized when the App lacks rights for the next step #14595),reviewer-deferred, fallbackpolicy.pkg/dashboard/stage_tracker.go:StageTrackerItemgainshuman_merge_reason+ one-sentencehuman_merge_reason_textat 090;StageTrackerLinkedPRnow mirrorshuman_approver,manual_mergeand the two reason fields so a PR nested under its issue (the owner's screenshot) says the same.index.html: lit word readsReady for human merge · workflow files/Awaiting human merge · workflow files · approved by @clubanderson; the chevron tooltip leads with the reason text ("Changes .github/workflows/** — the hive never merges workflow changes …; click Merge on GitHub"); the search / needs-attention headline carries the same tail.dashboard-sections.md,hive-merge.md(reason-code list); changelog fragment.No
/prschat change: that answer is label-only and has no stage record to derive a reason from.