Skip to content

🐛 dashboard: anchor tracker rows on the open PR when the issue has closed - #14657

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
fix/tracker-row-anchor-open-pr
Oct 27, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
fix/tracker-row-anchor-open-pr

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #14655

What

Owner screenshot (2026-10-27 18:15Z): the tracker row for hive#14567 drew the closed issue struck through under a closed pill as the headline, while its linked PR hive#14568 was still open at 090 awaiting the human's merge click. The row read as stale; it was actionable.

A PR whose every closing link (closingIssuesReferences / Fixes #N) names a closed issue is now anchored on the PR:

  • Backend (stage_tracker.go): stageTrackerClosedIssueAnchor sets closed_issue on a standalone PR item (not nested, no open/unknown-state closing link, soft Refs links ignored). The PR's stage, modifiers, stage_since and timestamps are untouched — the issue closing is not a regression. GitHub's stateReason is now read on closingIssuesReferences (both GraphQL passes) and carried as PRLinkedIssue.StateReason → state_reason, so a not-planned close is distinguishable.
  • Frontend (index.html): such a row leads with the PR's own icon, author icon, #N title at full width; the closed issue is a muted closes ~~#N~~ · closed chip linking to it; issue closed (not planned) adds a second chip. Sorting, age and Needs attention already keyed off the PR item (090 counts).
  • Issue closed and PR merged/closed: nothing changes — the PR is not an open item, so no row (recently-merged list untouched).
  • Docs: src/docs/dashboard-sections.md tracker section gains a Closed issue, open PR note.

Tests

  • TestStageTrackerRowAnchorsOnOpenPRWhenIssueClosed: table over completed / not_planned / PR-merged — row keyed by PR, stage 090 from the PR's record, no regressed, manual-merge gate intact, closed_issue populated with state_reason; both closed → no items.
  • TestStageTrackerClosedIssueAnchor: unit table for the anchor rule (nested, open link, unknown state, soft-only, first-closed-wins).

…osed

A PR whose every closing link names a closed issue is still live work.
Its row is now the PR's own: closed_issue on the item carries the
demoted issue (with GitHub's stateReason so a not-planned close can say
so) and the tracker draws the PR's number and title in the lead cell
with the closed issue as a muted chip. The PR's stage, modifiers and
timestamps are untouched — the issue closing is not a regression.

Fixes #14655

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 27, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 27, 2026
@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#14651 🌱 dashboard: defer merge-gate pills until the PR reaches the gate same files src/docs/dashboard-sections.md
src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/static/index.html
#14573 ✨ feat(dashboard): show a draft pill in the activity tracker same files src/docs/dashboard-sections.md
src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/static/index.html
#14695 ✨ review: reviewer lane scales concurrency with backlog same files src/pkg/dashboard/static/index.html
#14656 🐛 fix: keep the header's right chips from overlapping the title at 769-900px same files src/pkg/dashboard/static/index.html
#14630 🐛 fix(dashboard): enrich soft-linked stage-tracker issues with title and state CONFLICT src/pkg/dashboard/stage_tracker_test.go

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 27, 2026
@hivecommons-hive hivecommons-hive Bot added author/human A person pushed this PR themselves dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/071-needs-author Human-authored PR: CI red, changes requested or conflicting; diagnosis posted, the author must act labels Oct 27, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • relative links and anchors resolve

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

relative links and anchors resolve is PR-local (citation drift), not a baseline problem:

DRIFT src/docs/scale-envelope.md:37 src/pkg/github/client.go:4676-4686 -> src/pkg/github/client.go lacks anchor(s) near cited range: AgeMinutes

This PR adds three lines to PRLinkedIssue in src/pkg/github/client.go (~L1016), which shifts RankActionableIssues down to L4683 and its AgeMinutes sort to L4691. Fix: in src/docs/scale-envelope.md:37 change the citation src/pkg/github/client.go:4676-4686 → src/pkg/github/client.go:4679-4689 (verify with python3 src/scripts/check-docs-citations.py; --fix only rewrites api-reference.md). The hive does not push to your branch.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 67e291030

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 27e6551 into v5 Oct 27, 2026
86 of 91 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/tracker-row-anchor-open-pr branch October 27, 2026 20:44
@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#146579bb6073` sha256:6371f793a5247d6a7ad2964c32ba0f7a9c3396b42d24a9eac5421b70978cbac5 — download from the dashboard or `hivectl review evidence #14657`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 9bb6073.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/071-needs-author Human-authored PR: CI red, changes requested or conflicting; diagnosis posted, the author must act labels Oct 27, 2026
hivecommons-hive Bot added a commit that referenced this pull request Oct 27, 2026
….md (#14712)

RankActionableIssues gained lines in #14657, so the cited 4676-4686 range no
longer covers the AgeMinutes comparison and the docs-citations check on v5
fails with DRIFT. Widen the range to the function's current extent.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/human A person pushed this PR themselves conflicts-with-open-pr Open PR has a merge conflict with another open PR dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dashboard: tracker row anchored on closed issue while linked PR still open

1 participant