Repository navigation
🌱 dashboard: refresh codex static model catalog to 0.165.0 - #14770
Conversation
Captured live from `codex app-server` model/list against the 0.165.0 binary (same exchange cli_models_codex.go performs). Diff against the 0.159.0 snapshot: adds gpt-6.1-sol (visible, isDefault, present since at least 0.160.0) and gpt-6.1-terra (visible, new in 0.165.0). Hidden ids unchanged. index.html mirror and the #9804 parity test updated. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
/approve |
|
@clubanderson: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clubanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at c7ae82b. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
There was a problem hiding this comment.
Looks correct to me. Go list and CODEX_CLI_MODELS in index.html are updated in the same order, cli_model_lists_9804_test.go asserts both new ids, and cli_models_codex_test.go:129 compares against dedupeModels(codexStaticModels) so it is unaffected by the insertions. Two notes, neither blocking:
-
Sequence after #14769.
src/scripts/check-cli-model-lists.sh:65-69reads the first// … matches codex Xcomment incli_models.goand compares it toARG CODEX_VERSIONinsrc/Dockerfile. This PR changes the comment to0.165.0whilev5still pins0.164.0(src/Dockerfile:317), so thecli-pin-bump.ymlself-test (triggered by thecli_models.gopath,.github/workflows/cli-pin-bump.yml:69) will report drift until #14769 merges. It is warn-only (HIVE_MODEL_CHECK_STRICT: '0', line 104), so this only matters for ordering — land #14769 first and the warning never appears. -
Pricing table has no
gpt-6.1-*rows.src/pkg/tokens/pricing.go:133-134hasgpt-6-astra/gpt-6-solbut nothing forgpt-6.1-solorgpt-6.1-terra, soLookupPricemisses andFallbackPrice(pricing.go:277-281) bills them at the coarsetierMidestimate. Sincegpt-6.1-solis now the codex default, cost rows for codex agents will be flagged approximate until someone adds list prices — a follow-up, not something this catalog refresh needs to carry.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Looks correct to me: codexStaticModels (src/pkg/dashboard/cli_models.go:417-425) and CODEX_CLI_MODELS (static/index.html:24061-24069) carry the same nine visible ids in the same order, and the 9804 test's mustHave covers both new ids. I can't reproduce the live model/list capture from here, so I'm taking the catalog itself from the body.
One low-severity gap, a suggestion rather than a defect: src/pkg/tokens/pricing.go has no rows for gpt-6.1-sol or gpt-6.1-terra. The GPT-6 block at pricing.go:129-135 was added alongside the 0.159.0 catalog refresh (#9804) precisely so the picker's ids had list prices; with gpt-6.1-sol now the CLI default, every codex session on it will be costed by FallbackPrice (pricing.go:290-307, tierMid, flagged as fallback) until rows exist. If the list prices are known, adding them here keeps the two tables moving together as they did last time.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Part of this week's "stay integrated" check against Codex CLI rust-v0.165.0 (released 2026-10-27).
Captured live from
codex app-servermodel/list against the 0.165.0 binary (same exchangecli_models_codex.goperforms). Diff against the 0.159.0 snapshot:gpt-6.1-sol- visible,isDefault, present since at least 0.160.0 (the static list was missing the CLI's own default)gpt-6.1-terra- visible, new in 0.165.0 (openai/codex #57337)Changes:
cli_models.gocodexStaticModels + comment ("matches codex 0.165.0")static/index.htmlCODEX_CLI_MODELS mirrorcli_model_lists_9804_test.gocase name/mustHaveVerified:
go test ./pkg/dashboard -run 'TestCLIModelLists|9804|Codex'passes;check-cli-model-lists.shreports "static list comment says 0.165.0 but Dockerfile pins 0.164.0" until the companion cli-pin-bump PR for codex 0.165.0 lands (warning-only, HIVE_MODEL_CHECK_STRICT=0 in CI).Launcher verification for 0.165.0 (no crux changes needed):
codex --help/codex exec --helpidentical to 0.164.0; crux launch commandcodex --dangerously-bypass-approvals-and-sandbox -c features.daemon_auto_start=false --model ...accepted; pane markers crux parses (›prompt, "Waiting for startup · esc cancel" footer, update menu) unchanged.