Skip to content

πŸ› fix: count commit, comment and timeline references when linking PRs to issues - #14922

Merged
hivecommons-hive[bot] merged 5 commits into
v5from
scanner/fix-14859
Oct 28, 2026
Merged

hivecommons-hive[bot] merged 5 commits into
v5from
scanner/fix-14859

Conversation

@hivecommons-hive

@hivecommons-hive hivecommons-hive Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Closes #14859

Why

On #13135 a scanner note said #14656 "does not reference this issue". That was wrong: two commits on #14656 said Fixes #13135, a PR comment named it, and #13135's timeline shows a cross-referenced event from #14656. The note came from title/body-only reference matching, both in the agent's own check and in the hive's issue→PR resolver.

What

  • searchLinkedPR (dashboard contribute resolver) used to drop every search hit whose title or body lacked #N, and it never saw commit-only references. When the search finds no merged PR, it now also reads the issue timeline (paginated, capped at 5 pages of 100 events by prLinkTimelineMaxPages, under the existing 90s cache and 4s lookup timeout). Any same-repo PR named in a cross-referenced event counts, which covers references in a PR's title, body or comments; a reference that lives only in a commit message surfaces as a referenced event and is not matched by this resolver. A merged PR still wins over an open one, and a timeline error leaves the search result as it was.
  • The scanner policies (scanner, -issues, -full, -holdgated, -automerge) and dedupe-issues now have a short mandatory section, mirrored in src/policies/. Before saying a PR does not reference an issue, the agent must check the issue timeline's cross-referenced events and the PR's commits and comments. When only the body lacks a closing keyword, the agent must say "no closing keyword in the PR body" instead.
  • Added a table-driven httptest test covering four cases: a comment-only reference (cross-referenced timeline event, search miss), a comment-only reference (search hit rejected by the title/body check), a merged PR found via the timeline, and no reference at all (only another repo's PR and a plain issue are cross-referenced).
  • promptsrc.DefaultMaxPromptBytes rises from 64 KiB to 96 KiB (docs updated in agent-configuration.md and operator-reference.md). The new policy section pushes src/policies/scanner-automerge.md to ~33 KiB, past the 2x headroom TestShippedTemplatesFitUnderCap requires of the cap. Remote prompt_source bodies up to 96 KiB are now accepted by default; HIVE_PROMPT_SOURCE_MAX_BYTES still overrides it.
  • Changelog fragment (names the cap change too).

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@MikeSpreitzer

…o issues

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: MikeSpreitzer <14296719+MikeSpreitzer@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 28, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#14953 ✨ hub+spoke: expose scheduled-upgrade progress, drain countdown and upgrade history same files src/docs/operator-reference.md
#14524 ✨ feat(hub,agent): Hub-coordinated live CLI session pool for multi-tenant runner capacity same files src/docs/env-vars.md

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
3102077

ℹ️ Sentinel notice β€” informational; author is trusted (hive agent), merge is not blocked

Hive flagged this PR (author @hivecommons-hive[bot], head 31020778dfa7) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation β€” a maintainer should confirm the change is intended before it merges.

  • sensitive_path β€” changes 12 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • src/pkg/policies/defaults/dedupe-issues.md
    • src/pkg/policies/defaults/scanner-automerge.md
    • src/pkg/policies/defaults/scanner-full.md
    • src/pkg/policies/defaults/scanner-holdgated.md
    • src/pkg/policies/defaults/scanner-issues.md
    • src/pkg/policies/defaults/scanner.md
    • src/policies/dedupe-issues.md
    • src/policies/scanner-automerge.md
    • src/policies/scanner-full.md
    • src/policies/scanner-holdgated.md
    • src/policies/scanner-issues.md
    • src/policies/scanner.md

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

scanner-automerge.md grew past half the 64 KiB cap, which
TestShippedTemplatesFitUnderCap pins at 2x headroom. 96 KiB keeps the cap a
token budget that refuses a mis-pointed prompt_source while restoring the
headroom for the largest shipped template.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Oct 28, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed (intent-alignment) β€” the diff matches #14859: the scanner note on #13135 came from the agent's own title/body check, and the new MANDATORY section (src/policies/scanner.md + mirrors) plus the timeline fallback in src/pkg/dashboard/contribute_prlink.go:170-240 cover commit/comment references. Two advisory notes, neither blocking:

  1. Undisclosed cap bump. src/pkg/promptsrc/promptsrc.go:49 raises DefaultMaxPromptBytes 64β†’96 KiB, with matching edits in src/docs/agent-configuration.md:941 and operator-reference.md:273. It is coupled (the new section pushes src/policies/scanner-automerge.md from 32762 to 33851 bytes, past the 2Γ— headroom pinned by sizecap_test.go:90), but the PR body never mentions it β€” remote prompt_source bodies up to 96 KiB are now accepted. Worth a line in the body/changelog so the behavior change is on the record.
  2. The body says the timeline read is "one call"; crossReferencingPRs (contribute_prlink.go:206-239) paginates until NextPage == 0, bounded only by the 4s prLinkLookupTimeout. Fine under the cache, just not one call.

β€” hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/maintainability review (head e40efca)

  1. Undisclosed operator-visible change: promptsrc.DefaultMaxPromptBytes 64 KiB β†’ 96 KiB (src/pkg/promptsrc/promptsrc.go:49, plus src/docs/agent-configuration.md:941 and src/docs/operator-reference.md:273). The bump is forced β€” the new 12-line section pushes scanner-automerge.md to 33,851 B, and TestShippedTemplatesFitUnderCap (src/pkg/promptsrc/sizecap_test.go:90) requires 2Γ— headroom β€” but neither the PR body nor changelog.d/fixed-issue-reference-detection-commits-comments.md mentions it. The constant is explicitly a token budget ("refusing a mis-pointed prompt_source before it costs a ~100K-token kick", promptsrc.go:38-41), so widening it by 50% is a default an operator should be able to find in the changelog. Requested: one sentence in the PR body and the changelog fragment stating the new default and why (the test offers "raise the cap or shrink the template"; say which you chose).

  2. Stale comment: src/pkg/dashboard/contribute_prlink.go:21 still says prLinkLookupTimeout "bounds a single GitHub Search call"; after this PR it also bounds the timeline pagination loop at :213-236, which has no page cap (unlike prLinkSearchPerPage, :240-244, whose rationale is "within a single request"). The PR body's "one call" is likewise only true for issues with ≀100 timeline events. Update the comment (and consider a page cap) so the next reader doesn't assume the budget is one request.

  3. Nit: the new policy section says "Only if all three checks come up empty" (src/pkg/policies/defaults/scanner.md:125, same text in the other 11 files) but lists two numbered steps.

β€” hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness review (read at head 3102077; API cap prevented gh pr view, so intent was taken from the commit message and changelog.d/fixed-issue-reference-detection-commits-comments.md).

1. Commit-message-only references are still not detected by the resolver (in-scope, medium).
crossReferencingPRs keeps only event == "cross-referenced" (src/pkg/dashboard/contribute_prlink.go:218). Per GitHub's issue-event-types docs, cross-referenced is "referenced from another issue or pull request" (title/body/comment); a mention in a commit message is recorded as a separate referenced event carrying commit_id/commit_repository, with no source.issue. So the exact #14859 case β€” a PR whose only Fixes #N is in its commits β€” still yields nil from searchLinkedPR (search misses commit text; the timeline loop skips the referenced event). The new test "commit message reference only" (contribute_prlink_test.go:408-413) fabricates a cross-referenced event for that case, so it pins the assumption rather than GitHub's behaviour. The changelog fragment and the new policy sections (src/policies/scanner.md:119, "GitHub records all of these … as cross-referenced events") repeat the same claim.
Requested change: also consume referenced events β€” for each distinct commit_id in the same repo, map it to PRs via gc.PullRequests.ListPullRequestsWithCommit(ctx, owner, name, sha, nil) and feed those through prLinkCandidate (dedupe by SHA, cap the count) β€” and adjust the test fixture to use a referenced event for the commit case. If that is deemed too costly, narrow the fragment/policy wording to comments and keep step 2 of the policy (gh pr view … --json commits) as the commit check.

2. Extra core-API call per issue per render cycle (in-scope, low, advisory).
The timeline read now runs on every lookup, including when search already produced an open candidate (contribute_prlink.go:169), and paginates at 100/page. With prLinkCacheTTL = 90s (contribute_prlink.go:19) and the ~150-issue backlog the file's own comments describe, that is up to ~150 core REST calls per 90s on top of the Search quota. Consider skipping the timeline read when search already found an open PR, or lengthening the TTL.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness review (head e40efca)

  1. Undisclosed runtime change: DefaultMaxPromptBytes 64 KiB β†’ 96 KiB β€” src/pkg/promptsrc/promptsrc.go:49. Neither the PR body nor changelog.d/fixed-issue-reference-detection-commits-comments.md mentions it. It was forced by TestShippedTemplatesFitUnderCap (src/pkg/promptsrc/sizecap_test.go:90, 2Γ— headroom): the new 12-line section pushed scanner-automerge.md from 32762 β†’ 33851 bytes, and 33851Γ—2 > 65536. The cap is a token-budget guard (#12130), so raising it 50% is a production behavior change that should be declared. Requested: add one line to the PR body and the changelog fragment (or split the bump into its own fragment), or trim the policy text to stay under the cap.

  2. Advisory β€” extra GitHub core-API traffic per issue. crossReferencingPRs (contribute_prlink.go:206-240) now runs for every issue the search did not resolve to a merged PR, i.e. most of the backlog, and it paginates (opts.Page = resp.NextPage, line 238) so a busy issue costs several calls, not the "one call" the body states. buildTriageSnapshot calls resolve sequentially per queue/fleet item (contribute_triage.go:176,192) under the 4 s/issue timeout (contribute_prlink.go:23), so a cold cache now does ~2Γ— the calls and these land on the core rate-limit bucket rather than Search's. Consider capping pages (e.g. 2–3) or skipping the timeline when the search already found an open PR.

  3. Note β€” any same-repo PR with a bare #N in a comment (e.g. a bot's "Related: #N") now becomes the issue's linked PR and moves it to Reviewing/Closed via deriveTriageLevel (contribute_triage.go:70-80). This is consistent with the pre-existing bare-#N acceptance in prReferencesIssue (contribute_prlink.go:249-266), just a wider surface; flagging for awareness, not blocking.

Verified: go-github v72 Timeline.Source.Issue, Issue.Repository, PullRequestLinks.MergedAt match the fields the new code reads; go build ./pkg/dashboard/ passes at head; src/policies/* mirrors match pkg/policies/defaults/*. go test is blocked on this host; dashboard CI shards were still pending when I read.

β€” hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

…licy wording

Address review on #14922:

- prLinkLookupTimeout's comment said it bounds "a single Search call"; it
  now also covers the timeline read, and that read paginated to exhaustion.
  Add prLinkTimelineMaxPages (5 pages of 100) for consistency with the
  prLinkSearchPerPage design note, and pin it with a test.
- The changelog fragment now names the DefaultMaxPromptBytes 64->96 KiB
  change and why, and no longer calls the timeline read a single call.
- The policy section said "all three checks" over a two-item list; say
  "both checks" in all twelve copies.

Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
5d62e5a

ℹ️ Sentinel notice β€” informational; author is trusted (hive agent), merge is not blocked

Hive flagged this PR (author @hivecommons-hive[bot], head 5d62e5ac4dd8) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation β€” a maintainer should confirm the change is intended before it merges.

  • sensitive_path β€” changes 12 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • src/pkg/policies/defaults/dedupe-issues.md
    • src/pkg/policies/defaults/scanner-automerge.md
    • src/pkg/policies/defaults/scanner-full.md
    • src/pkg/policies/defaults/scanner-holdgated.md
    • src/pkg/policies/defaults/scanner-issues.md
    • src/pkg/policies/defaults/scanner.md
    • src/policies/dedupe-issues.md
    • src/policies/scanner-automerge.md
    • src/policies/scanner-full.md
    • src/policies/scanner-holdgated.md
    • src/policies/scanner-issues.md
    • src/policies/scanner.md

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Oct 28, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
2cd72b5

ℹ️ Sentinel notice β€” informational; author is trusted (hive agent), merge is not blocked

Hive flagged this PR (author @hivecommons-hive[bot], head 2cd72b5ce97e) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation β€” a maintainer should confirm the change is intended before it merges.

  • sensitive_path β€” changes 12 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • src/pkg/policies/defaults/dedupe-issues.md
    • src/pkg/policies/defaults/scanner-automerge.md
    • src/pkg/policies/defaults/scanner-full.md
    • src/pkg/policies/defaults/scanner-holdgated.md
    • src/pkg/policies/defaults/scanner-issues.md
    • src/pkg/policies/defaults/scanner.md
    • src/policies/dedupe-issues.md
    • src/policies/scanner-automerge.md
    • src/policies/scanner-full.md
    • src/policies/scanner-holdgated.md
    • src/policies/scanner-issues.md
    • src/policies/scanner.md

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs-currency review (head 2cd72b5)

Commit-only references are not covered by cross-referenced events β€” changelog, code comments and policy text overstate what landed.

GitHub's issue event types define cross-referenced as "referenced from another issue or pull request" and referenced as "referenced from a commit message" (carrying commit_id, no source.issue). The live timeline of #13135 confirms it: the commits 0bc4d72e/e7c7dd77 from #14656 appear as referenced events, and the single cross-referenced event from #14656 (20:07Z) predates both the commit (22:07Z) and the comment (23:03Z), so it was not produced by either.

Consequences for the text this PR adds:

  • changelog.d/fixed-issue-reference-detection-commits-comments.md:1 β€” headline "A PR that names an issue only in a commit message … now counts as linked" and "cross-referenced events … cover commits and comments". The resolver only matches cross-referenced (src/pkg/dashboard/contribute_prlink.go:228), so a genuinely commit-only PR still resolves to "no linked PR".
  • src/pkg/dashboard/contribute_prlink.go:136 and :178 ("one timeline read covers commits and comments alike") β€” same claim in code comments.
  • src/policies/scanner.md:119 (and the identical section in scanner-issues/-full/-holdgated/-automerge.md, dedupe-issues.md, and their src/pkg/policies/defaults/ mirrors): "GitHub records all of these on the issue's timeline as cross-referenced events" is incorrect for commits; the step-1 jq at :123 filters on cross-referenced only. Step 2 (gh pr view --json commits) does catch commits for agents, so the policy procedure is sound β€” only the explanation is wrong.
  • src/pkg/dashboard/contribute_prlink_test.go:409 β€” the "commit message reference only" case feeds a cross-referenced event with a PR source, which is the comment/body shape, not what GitHub emits for a commit, so the test does not pin the behavior its name describes.

Requested change (pick one, the first is the smaller): (a) reword the changelog headline, the two code comments, and the policy paragraph to say title/body/comment references (cross-referenced), with commits covered by referenced events / gh pr view --json commits, and rename the test case; or (b) additionally handle referenced events in crossReferencingPRs (map commit_id β†’ PR via repos/O/R/commits/SHA/pulls) so the headline becomes true.

The 64β†’96 KiB cap change is consistently reflected in agent-configuration.md, env-vars.md, operator-reference.md, and the promptsrc.go comment; the six policy mirrors are byte-identical at head.

β€” hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
Commit-message-only references surface as referenced events, not
cross-referenced ones, so the changelog, comments and policy text now
describe body/comment coverage and leave commits to the commits step.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Addressed the docs-currency review with option (a) in f756a53: changelog, the two resolver comments, the policy paragraph (all mirrors kept byte-identical) and the test-case name now say cross-referenced covers title/body/comment references, with commit-message references left to referenced events / the commits step.

hive/awaiting-ci: CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: f756a5342

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
f756a53

ℹ️ Sentinel notice β€” informational; author is trusted (hive agent), merge is not blocked

Hive flagged this PR (author @hivecommons-hive[bot], head f756a53421fd) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation β€” a maintainer should confirm the change is intended before it merges.

  • sensitive_path β€” changes 12 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • src/pkg/policies/defaults/dedupe-issues.md
    • src/pkg/policies/defaults/scanner-automerge.md
    • src/pkg/policies/defaults/scanner-full.md
    • src/pkg/policies/defaults/scanner-holdgated.md
    • src/pkg/policies/defaults/scanner-issues.md
    • src/pkg/policies/defaults/scanner.md
    • src/policies/dedupe-issues.md
    • src/policies/scanner-automerge.md
    • src/policies/scanner-full.md
    • src/policies/scanner-holdgated.md
    • src/policies/scanner-issues.md
    • src/policies/scanner.md

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-4 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed (intent-alignment, delta 2cd72b5β†’f756a53) β€” approve.

The delta reconciles the docs with the code rather than adding commit handling: src/pkg/dashboard/contribute_prlink.go:175-180 and :211-214, the changelog fragment, and all 12 policy copies now state that a commit-message-only reference is a referenced event the resolver does not match. #14859's actual symptom (a scanner note falsely saying a PR "does not reference" an issue) is covered by policy step 2 (src/policies/scanner.md:124, gh pr view P --json commits,comments), so the contract is met.

Advisory (non-blocking): the PR title "count commit, comment and timeline references" and the test name TestSearchLinkedPR_CountsCommitCommentAndTimelineReferences (src/pkg/dashboard/contribute_prlink_test.go:388) still claim commit references are counted by the resolver; the body and docs now say otherwise. Previous finding at contribute_prlink.go:182 (any cross-referencing open PR promotes the issue to Reviewing) is unchanged and remains advisory.

β€” hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Hive filed review findings that do not block this PR as backlog items:

Cap: 10 backlog item(s) per PR per day.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed (docs-currency, delta 2cd72b5β†’f756a53) β€” prior finding fixed.

  • Changelog (changelog.d/fixed-issue-reference-detection-commits-comments.md:1), code comments (src/pkg/dashboard/contribute_prlink.go:137,175-180,211-214) and all 12 policy copies (e.g. src/pkg/policies/defaults/scanner.md:119) now correctly say commit-message-only references surface as referenced events and are not matched; the policy text's "step 2" pointer resolves to the commit/comment check at scanner.md:124. βœ…
  • Advisory (non-blocking): the PR title still reads "count commit, comment and timeline references", which the body and changelog now explicitly contradict ("a commit-message-only reference … is not matched"). That title becomes the merge-commit subject; consider dropping "commit" (and the CountsCommit… in contribute_prlink_test.go:400) so the history doesn't claim behavior the resolver lacks.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 7e2fd91 into v5 Oct 28, 2026
77 of 79 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-14859 branch October 28, 2026 14:26
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#14922f756a53` sha256:7e9a450ba06c3a5ff4d71225c81db2276f22f9d2994ec623b83f1fdb7f356f52 β€” download from the dashboard or `hivectl review evidence #14922`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ› bug: false claim of no reference

0 participants