Skip to content

✨ feat(sandbox): scheduler_name for the Job runtime pod template - #14662

Merged
clubanderson merged 2 commits into
v5from
feat/sandbox-job-scheduler-name
Oct 27, 2026
Merged

clubanderson merged 2 commits into
v5from
feat/sandbox-job-scheduler-name

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Why

Accelerator clusters often require device-requesting pods to use a custom scheduler, enforced by a validating webhook. On the IBM Spyre dev cluster (a1-vllm-spyre) every runtime: job kick that requests ibm.com/spyre_pf is denied at Job create:

admission webhook "spyre-job-validator.k8s.io" denied the request: A pod must use "schedulerName: spyre-scheduler".

SandboxJobConfig had no way to set schedulerName, so the sandbox kick fails before a pod exists (visible only in audit.jsonl as sandbox_failed).

What

  • agents.<name>.sandbox.job.scheduler_name (optional) → kubejob.Options.SchedulerName → pod schedulerName. Empty leaves the cluster default.
  • Round-trip covered in kubejob_test.go (manifest) and sandbox_job_runtime_test.go (config→options).
  • One line in docs/sandbox-isolation.md, changelog.d entry.

Additive; no behaviour change when unset.

Test

cd src/crux && go test ./kubejob/ ./config/ ./agent/ — ok.

Accelerator clusters commonly gate device-requesting pods behind a custom
scheduler via a validating admission webhook. On the Spyre dev cluster the
Job create is denied outright:

  admission webhook "spyre-job-validator.k8s.io" denied the request:
  A pod must use "schedulerName: spyre-scheduler".

SandboxJobConfig had no way to set it, so every runtime: job kick that
requests ibm.com/spyre_pf failed before a pod existed. Add
agents.<name>.sandbox.job.scheduler_name, passed through verbatim as the
pod's schedulerName (empty = cluster default), with launcher and config
round-trip tests and a doc line.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 27, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 27, 2026
@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#14669 ✨ dashboard: say why a PR is waiting on a human merge same files src/pkg/dashboard/static/index.html
#14671 🐛 fix(convergence): scope the mutation writer slot per target instead of per repo same files src/pkg/dashboard/settings_parity_allowlist.txt
#14656 🐛 fix: keep the header's right chips from overlapping the title at 769-900px same files src/pkg/dashboard/static/index.html
#14651 🌱 dashboard: defer merge-gate pills until the PR reaches the gate same files src/pkg/dashboard/static/index.html
#14573 ✨ feat(dashboard): show a draft pill in the activity tracker same files src/pkg/dashboard/static/index.html
#14657 🐛 dashboard: anchor tracker rows on the open PR when the issue has closed same files src/pkg/dashboard/static/index.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@hivecommons-hive hivecommons-hive Bot added author/human A person pushed this PR themselves dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/071-needs-author Human-authored PR: CI red, changes requested or conflicting; diagnosis posted, the author must act labels Oct 27, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • test (dashboard 3/4)
  • test (dashboard shuffle 3/3)

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Settings parity requires every hive.yaml leaf to be reachable from the
Settings dialog; add the Job scheduler name field next to the other
sandbox Job fields and allowlist the per-agent override like its siblings.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/071-needs-author Human-authored PR: CI red, changes requested or conflicting; diagnosis posted, the author must act labels Oct 27, 2026
@clubanderson
clubanderson merged commit 96ef2e5 into v5 Oct 27, 2026
80 of 82 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the feat/sandbox-job-scheduler-name branch October 27, 2026 19:02
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/human A person pushed this PR themselves dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/S Denotes a PR that changes 10-29 lines, ignoring generated files. stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant