Skip to content

✨ dashboard: order tracker rows attention-first within each column - #14689

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
feat/tracker-attention-first
Oct 27, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
feat/tracker-attention-first

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #14686

What

Within each column / stage band the Hive activity monitor now tiers rows before the existing keys (longest on the step → repo → number):

Tier Rows Rule
0 attention a person must act now stageTrackerNeedsAttention(row) — any shown pill (stalled, unauthorized, needs rebase, needs human, …) or a human-gated stage (045, 071, 072, 085, 090), minus handled regressions
1 normal everything else —
2 sunk nobody should act hold (incl. do-not-merge/*), draft, or a PR anchored to a closed issue (closed_issue, #14657)

Sunk beats attention (a hold on an 085 row sinks). Deferred pills (deferred_modifiers, #14651) are not in modifiers, so they never promote a row.

  • Applies to the Furthest along and Longest waiting sorts; Newest and Number are untouched.
  • Same tiering for the PR sub-rows under an issue (stageTrackerLinkedSorted).
  • The direction arrow now negates only the column / age / repo / number comparators — not the tier — so attention stays on top in both directions (previously a whole-array .reverse()). Tooltip: "Attention-first within each column; arrow flips age order".
  • Group=Repo still groups after sorting.
  • Server pre-sort in stage_tracker.go factored into stageTrackerLess (stage desc → stageTrackerAttentionTier → wait → repo → number) so chat /prs and the hub see the same order. Go and JS share the tier definition.

Tests

  • TestStageTrackerAttentionTier — Go tier table + mixed-row sort fixture.
  • TestStageTrackerAttentionOrderJS — node fixture (existing stage_tracker_ui_test.go pattern) asserting furthest/waiting desc+asc keep tiers, newest/number unchanged, sub-row tiering.
  • Existing node fixtures updated to load the new helper; one waiting expectation updated for tiering.

Follow-up

Go has no ClosedIssue field until #14657 merges; the Go tier sinks hold/draft only. JS already checks row.closed_issue so it picks up #14657 automatically; the Go side can add the one-line check once that lands.

Docs

src/docs/dashboard-sections.md ordering paragraph; changelog.d/changed-tracker-attention-first-order.md.

Within a column the Hive activity monitor now tiers rows before the
existing keys: rows a person must act on now (a shown pill or a
human-gated stage) first, plain rows next, hold / draft /
closed-issue-anchored rows last; within a tier the longest on the step
still comes first, then repo and number. Applies to the Furthest along
and Longest waiting sorts and to the PR sub-rows under an issue; the
direction arrow flips the age keys but never the tier. The server
pre-sort mirrors the tier (stageTrackerAttentionTier in Go and JS) so
chat /prs and the hub read the same order.

Fixes #14686

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 27, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 27, 2026
@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#14656 🐛 fix: keep the header's right chips from overlapping the title at 769-900px same files src/pkg/dashboard/static/index.html
#14573 ✨ feat(dashboard): show a draft pill in the activity tracker same files src/docs/dashboard-sections.md
src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/stage_tracker_motion_test.go
src/pkg/dashboard/stage_tracker_repo_grouping_test.go
src/pkg/dashboard/stage_tracker_ui_test.go
src/pkg/dashboard/static/index.html
#14651 🌱 dashboard: defer merge-gate pills until the PR reaches the gate same files src/docs/dashboard-sections.md
src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/static/index.html
#14695 ✨ review: reviewer lane scales concurrency with backlog same files src/pkg/dashboard/static/index.html
#14630 🐛 fix(dashboard): enrich soft-linked stage-tracker issues with title and state same files src/pkg/dashboard/stage_tracker.go
#14657 🐛 dashboard: anchor tracker rows on the open PR when the issue has closed same files src/docs/dashboard-sections.md
src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/static/index.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@hivecommons-hive hivecommons-hive Bot added author/human A person pushed this PR themselves dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 27, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit deee564 into v5 Oct 27, 2026
86 of 90 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the feat/tracker-attention-first branch October 27, 2026 20:09
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#14689143d64e` sha256:4926c0557a273c663458859983132d99f8d20bb31c402d96b0ba640d43570c42 — download from the dashboard or `hivectl review evidence #14689`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 143d64e.

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/human A person pushed this PR themselves dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dashboard: tracker rows should order attention-first within each column

1 participant