Skip to content

Drop dangling shape reexport - #336

Merged
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:codex/fix-shape-reexport-docs
Sep 12, 2026
Merged

ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:codex/fix-shape-reexport-docs

Conversation

@ChrisRackauckas-Claude

@ChrisRackauckas-Claude ChrisRackauckas-Claude commented Sep 8, 2026 •

Copy link
Copy Markdown
Member

Change

shape is exported by both Distributions and Plots, so the bare usings in src/EasyModelAnalysis.jl leave the binding ambiguous and EasyModelAnalysis.shape is undefined. That trips two QA checks on master: Aqua's undefined_exports (Symbol("EasyModelAnalysis.shape")) and the reexport-surface reachability test (isempty([:shape])).

Since the name is unreachable for users today (any EasyModelAnalysis.shape access throws), dropping it from the export list — and from the REEXPORTS allow-list and the documented parameter list — is not breaking. Users can still reach Distributions.shape via using Distributions.

Verification

On master, names(EasyModelAnalysis) contains shape while isdefined(EasyModelAnalysis, :shape) is false (ambiguous Distributions/Plots binding) — reproducing the Aqua failure. After this change shape is no longer in names(EasyModelAnalysis) or REEXPORTS, so both checks pass. Native QA on CI pending (previous revision passed QA 23/23 locally).

🤖 Generated with Devin CLI (model: SWE-2 Max) — local session, no shareable URL

@ChrisRackauckas-Claude

ChrisRackauckas-Claude commented Sep 8, 2026 •

Copy link
Copy Markdown
Member Author

The 32-bit Core job fails during dependency precompilation, before the EMA assertions. I read the completed job log; there are two distinct roots:

LatticeRules 0.0.1, reached from QuasiMonteCarlo 0.3.11:
ArgumentError: maximum number of points n must be less than or equal to 2^32
LatticeRule32.jl:56

Symbolics 7.39.0 with SymbolicUtils 4.46.3:
MethodError: no method matching hash(::SymbolicUtils.BasicSymbolicImpl.var"typeof(BasicSymbolicImpl)"{SymbolicUtils.SymReal}, ::UInt64)
hash(D::Symbolics.Differential, u::UInt32), src/diff.jl:141

These exact roots were also independently audited in NeuralPDE's master x86 lane. This is not a local x86 pass claim or a bisect of the shape change.

Existing fixes already cover both sources: Symbolics' seed-width correction and LatticeRules' 32-bit correction are merged. QuasiMonteCarlo's alternative workaround release remains open. The September 8 registry/resolution audit found the merged source fixes not yet available in the selected registered graph; MonteCarloIntegration 0.2 also restricts QuasiMonteCarlo to 0.3, so releasing only the newer QMC workaround does not establish downstream resolution. MonteCarloIntegration's compatibility and version changes are already merged too. Release and downstream runtime validation remain necessary; no duplicate patch or CI-lane suppression is included here.

Links

Audit by Codex CLI 0.153.4 (model: gpt-6-astra); local transcript /home/crackauc/.codex/sessions/2026/09/05/rollout-2026-09-05T05-08-31-01a070d3-9e50-71c2-98f5-129385e50fb7.jsonl.

`shape` is exported by both Distributions and Plots, so the bare
`using`s leave it ambiguous and `EasyModelAnalysis.shape` is undefined;
Aqua's undefined_exports check fails on it. The name is unreachable for
users today, so dropping it from the reexport surface is not breaking.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Agent-Harness: Devin CLI
Agent-Model: SWE-2 Max
Agent-Session: /home/crackauc/.local/share/devin/cli/summaries/history_381cdc5dd0594daf.md
@ChrisRackauckas-Claude
ChrisRackauckas-Claude force-pushed the codex/fix-shape-reexport-docs branch from bb23018 to 46a80c4 Compare September 12, 2026 04:06
@ChrisRackauckas-Claude ChrisRackauckas-Claude changed the title Fix Distributions shape reexport Drop dangling shape reexport Sep 12, 2026
@ChrisRackauckas
ChrisRackauckas marked this pull request as ready for review September 12, 2026 06:12
@ChrisRackauckas
ChrisRackauckas merged commit 31169a0 into SciML:main Sep 12, 2026
8 of 10 checks passed
ChrisRackauckas added a commit that referenced this pull request Sep 13, 2026
- Drop dangling shape reexport (#336)
- Read forecast trajectories through EnsembleSolution.u (#337)



Agent-Harness: Claude Code
Agent-Model: claude-opus-5[1m]
Claude-Session: https://claude.ai/code/session_014FEzNTLFutCmTEAZ3zBg5R

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants