Drop dangling shape reexport - #336
ChrisRackauckas merged 1 commit into
Conversation
|
The 32-bit Core job fails during dependency precompilation, before the EMA assertions. I read the completed job log; there are two distinct roots: These exact roots were also independently audited in NeuralPDE's master x86 lane. This is not a local x86 pass claim or a bisect of the shape change. Existing fixes already cover both sources: Symbolics' seed-width correction and LatticeRules' 32-bit correction are merged. QuasiMonteCarlo's alternative workaround release remains open. The September 8 registry/resolution audit found the merged source fixes not yet available in the selected registered graph; MonteCarloIntegration 0.2 also restricts QuasiMonteCarlo to 0.3, so releasing only the newer QMC workaround does not establish downstream resolution. MonteCarloIntegration's compatibility and version changes are already merged too. Release and downstream runtime validation remain necessary; no duplicate patch or CI-lane suppression is included here. Links
Audit by Codex CLI 0.153.4 (model: gpt-6-astra); local transcript |
`shape` is exported by both Distributions and Plots, so the bare `using`s leave it ambiguous and `EasyModelAnalysis.shape` is undefined; Aqua's undefined_exports check fails on it. The name is unreachable for users today, so dropping it from the reexport surface is not breaking. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> Agent-Harness: Devin CLI Agent-Model: SWE-2 Max Agent-Session: /home/crackauc/.local/share/devin/cli/summaries/history_381cdc5dd0594daf.md
bb23018 to
46a80c4
Compare
- Drop dangling shape reexport (#336) - Read forecast trajectories through EnsembleSolution.u (#337) Agent-Harness: Claude Code Agent-Model: claude-opus-5[1m] Claude-Session: https://claude.ai/code/session_014FEzNTLFutCmTEAZ3zBg5R Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Change
shapeis exported by both Distributions and Plots, so the bareusings insrc/EasyModelAnalysis.jlleave the binding ambiguous andEasyModelAnalysis.shapeis undefined. That trips two QA checks on master: Aqua'sundefined_exports(Symbol("EasyModelAnalysis.shape")) and the reexport-surface reachability test (isempty([:shape])).Since the name is unreachable for users today (any
EasyModelAnalysis.shapeaccess throws), dropping it from theexportlist — and from theREEXPORTSallow-list and the documented parameter list — is not breaking. Users can still reachDistributions.shapeviausing Distributions.Verification
On master,
names(EasyModelAnalysis)containsshapewhileisdefined(EasyModelAnalysis, :shape)isfalse(ambiguous Distributions/Plots binding) — reproducing the Aqua failure. After this changeshapeis no longer innames(EasyModelAnalysis)orREEXPORTS, so both checks pass. Native QA on CI pending (previous revision passed QA 23/23 locally).🤖 Generated with Devin CLI (model: SWE-2 Max) — local session, no shareable URL