Skip to content

Remove contradictory scenario2 observable defaults - #342

Merged
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:codex/fix-scenario2-observed-defaults
Sep 12, 2026
Merged

ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:codex/fix-scenario2-observed-defaults

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member

Change

Remove inconsistent initial defaults T=10000 and η=0 from scenario2's algebraic observables. Preserve all compartment values and cumulative_I(0)=0, and assert that the initial solve succeeds before using it as generated data. Event syntax, thresholds, optimizer, and budget are unchanged.

Failing before / passing after

The same initial-state test checks successful return code, exact initial [S,E,I,R,H,D,T], and completion at day 60:

$ julia --startup-file=no --project=docs ../EasyModelAnalysis-intervention-audit/.validation/test-initial-state.jl <unfixed-page>
Initial-state before: 0 passed, 3 failed; exit 1
$ julia --startup-file=no --project=docs ../EasyModelAnalysis-intervention-audit/.validation/test-initial-state.jl docs/src/scenarios/scenario2.md
Initial-state after: 3/3 passed; exit 0

Before: InitialFailure, t=0, initial [10000.06,.02,-.08,0,0,0,10000].
After: Success, t=60, initial [.97,.02,.01,0,0,0,1].

Local native QA: 23/23 (10m32s); Core: 31/31, exit 0. Scoped formatting, spelling, and diff checks passed.

Full strict docs did not pass: exit 124 at six hours, with 50 failed example blocks. Scenario2's subsequent intervention API failure is deliberately separate; this draft fixes initialization only.

Validation scope

Historical results below were run locally with Julia 1.11.9 before rebasing onto current main (which now includes #336 and #337). The changed page is preserved by the rebase. These are not claims that the full documentation or all downstream packages pass. The user requested draft publication with these outstanding gates disclosed.

Native test/build commands, with a workspace-local TMPDIR and headless plotting:

GROUP=QA julia --startup-file=no --project=. -e 'using Pkg; Pkg.test()'
GROUP=Core julia --startup-file=no --project=. -e 'using Pkg; Pkg.test()'
GKSwstype=100 timeout 21600 julia --startup-file=no --project=docs docs/make.jl

GPU paths, downstream packages, and deployment were not verified. No tests or documentation errors were disabled.

Please ignore this draft until reviewed by @ChrisRackauckas.

The post-rebase page is byte-identical to its locally validated pre-rebase version. Fresh post-rebase QA and focused page checks were launched on September 12 and remain pending at publication; they are not counted as passes. Post-rebase spelling and diff checks passed.

🤖 Generated with Codex CLI 0.153.4 (model: gpt-6-astra; session: local session ID 01a0598f-11b9-72d1-91d9-b2fbb186557d).

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Agent-Harness: Codex CLI 0.153.4
Agent-Model: gpt-6-astra
Agent-Session: local session ID 01a0598f-11b9-72d1-91d9-b2fbb186557d
@ChrisRackauckas
ChrisRackauckas marked this pull request as ready for review September 12, 2026 11:59
@ChrisRackauckas
ChrisRackauckas merged commit 7696e9b into SciML:main Sep 12, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants