Repository navigation
Source Integrals/MonteCarloIntegration from master in test env - #338
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
The registered MonteCarloIntegration v0.2.0 caps QuasiMonteCarlo at 0.3.x, which pins LatticeRules 0.0.1 — whose `typemax(UInt32) + 1` wraps to zero on 32-bit Julia, failing precompile in the x86 CI lane. MCI master (v0.3.0, unregistered) allows QuasiMonteCarlo 0.4 which lifts LatticeRules to 0.0.2 with the widened arithmetic. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Devin <noreply@cognition.ai> Agent-Harness: Devin CLI 3000.10.21 Agent-Model: SWE-2 Max Agent-Session: /home/crackauc/.local/share/devin/cli/summaries/history_66ef0886b194479c.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MonteCarloIntegrationv0.2.0 capsQuasiMonteCarloat 0.3.x, which pinsLatticeRules0.0.1. On 32-bit Julia,typemax(UInt32) + 1in LatticeRules 0.0.1 wraps to zero (ArgumentError: maximum number of points n must be less than or equal to 2^32).MonteCarloIntegrationmaster (v0.3.0, unregistered) allowsQuasiMonteCarlo0.4, which liftsLatticeRulesto 0.0.2 where the arithmetic is widened.MonteCarloIntegrationto extras/test target and[sources]overrides forIntegralsandMonteCarloIntegration(same approach as NeuralPDE.jl#1162 and BoundaryValueDiffEq.jl#634). Can be reverted once MCI 0.3.0 and a compatible Integrals are registered.:shapeundefined export) are separately covered by Drop dangling shape reexport #336.Test plan
QuasiMonteCarlo0.4.4,LatticeRules0.0.2,MonteCarloIntegration0.3.0,Integralsmaster — all precompile cleanly (previouslyLatticeRules/QuasiMonteCarlo/MonteCarloIntegration/Integralsall failed)🤖 Generated with Devin CLI 3000.10.21 (model: SWE-2 Max)
Session: /home/crackauc/.local/share/devin/cli/summaries/history_66ef0886b194479c.md