Skip to content

Remove contradictory SEIRHD observable defaults - #341

Merged
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:codex/fix-seirhd-observed-defaults
Sep 12, 2026
Merged

ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:codex/fix-seirhd-observed-defaults

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member

Change

Remove contradictory initial defaults for the derived SEIRHD observables T and η. Preserve all compartment values (their sum is 1.27), cumulative infections, equations, and solver settings. Add executable return-code, initial-value, and finite-value assertions.

Failing before / passing after

The same six-check initial-state regression failed 0/6 before and passed 6/6 after. The unfixed model produced a NaN initial timestep and remained at time zero; the corrected model returned Success and reached day 110 with T=1.27 and η≈0.02907874.

The actual five named documentation blocks were also evaluated, with the same added assertions in the before control:

$ julia --startup-file=no --project=docs ../EMA-carcione-clean-env/run_seirhd_official_blocks.jl <unfixed-page-with-assertions>
AssertionError
[exit 1]
$ julia --startup-file=no --project=docs ../EMA-carcione-clean-env/run_seirhd_official_blocks.jl docs/src/examples/SEIRHD.md
SEIRHD_OFFICIAL_BLOCKS_OK 5
[exit 0]

Local native QA: 23/23 (7m52.3s); Core: 40/40, exit 0. New Julia fragments passed scoped formatting; spelling and diff checks passed.

Full strict docs did not pass: exit 124 at six hours, with 48 failed example blocks elsewhere. No SEIRHD block failure was logged, but the build did not complete. This change does not normalize the original compartment values or establish numerical validity of other examples.

Validation scope

Historical results below were run locally with Julia 1.11.9 before rebasing onto current main (which now includes #336 and #337). The changed page is preserved by the rebase. These are not claims that the full documentation or all downstream packages pass. The user requested draft publication with these outstanding gates disclosed.

Native test/build commands, with a workspace-local TMPDIR and headless plotting:

GROUP=QA julia --startup-file=no --project=. -e 'using Pkg; Pkg.test()'
GROUP=Core julia --startup-file=no --project=. -e 'using Pkg; Pkg.test()'
GKSwstype=100 timeout 21600 julia --startup-file=no --project=docs docs/make.jl

GPU paths, downstream packages, and deployment were not verified. No tests or documentation errors were disabled.

Please ignore this draft until reviewed by @ChrisRackauckas.

The post-rebase page is byte-identical to its locally validated pre-rebase version. Fresh post-rebase QA and focused page checks were launched on September 12 and remain pending at publication; they are not counted as passes. Post-rebase spelling and diff checks passed.

🤖 Generated with Codex CLI 0.153.4 (model: gpt-6-astra; session: local session ID 01a0598f-11b9-72d1-91d9-b2fbb186557d).

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Agent-Harness: Codex CLI 0.153.4
Agent-Model: gpt-6-astra
Agent-Session: local session ID 01a0598f-11b9-72d1-91d9-b2fbb186557d
@ChrisRackauckas
ChrisRackauckas marked this pull request as ready for review September 12, 2026 11:59
@ChrisRackauckas
ChrisRackauckas merged commit a7704c6 into SciML:main Sep 12, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants