Remove contradictory SEIRHD observable defaults - #341
Merged
ChrisRackauckas merged 1 commit intoSep 12, 2026
Merged
ChrisRackauckas merged 1 commit into
ChrisRackauckas merged 1 commit into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: OpenAI Codex <noreply@openai.com> Agent-Harness: Codex CLI 0.153.4 Agent-Model: gpt-6-astra Agent-Session: local session ID 01a0598f-11b9-72d1-91d9-b2fbb186557d
ChrisRackauckas
marked this pull request as ready for review
September 12, 2026 11:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Remove contradictory initial defaults for the derived SEIRHD observables
Tandη. Preserve all compartment values (their sum is 1.27), cumulative infections, equations, and solver settings. Add executable return-code, initial-value, and finite-value assertions.Failing before / passing after
The same six-check initial-state regression failed 0/6 before and passed 6/6 after. The unfixed model produced a NaN initial timestep and remained at time zero; the corrected model returned Success and reached day 110 with T=1.27 and η≈0.02907874.
The actual five named documentation blocks were also evaluated, with the same added assertions in the before control:
Local native QA: 23/23 (7m52.3s); Core: 40/40, exit 0. New Julia fragments passed scoped formatting; spelling and diff checks passed.
Full strict docs did not pass: exit 124 at six hours, with 48 failed example blocks elsewhere. No SEIRHD block failure was logged, but the build did not complete. This change does not normalize the original compartment values or establish numerical validity of other examples.
Validation scope
Historical results below were run locally with Julia 1.11.9 before rebasing onto current main (which now includes #336 and #337). The changed page is preserved by the rebase. These are not claims that the full documentation or all downstream packages pass. The user requested draft publication with these outstanding gates disclosed.
Native test/build commands, with a workspace-local TMPDIR and headless plotting:
GPU paths, downstream packages, and deployment were not verified. No tests or documentation errors were disabled.
Please ignore this draft until reviewed by @ChrisRackauckas.
The post-rebase page is byte-identical to its locally validated pre-rebase version. Fresh post-rebase QA and focused page checks were launched on September 12 and remain pending at publication; they are not counted as passes. Post-rebase spelling and diff checks passed.
🤖 Generated with Codex CLI 0.153.4 (model: gpt-6-astra; session: local session ID 01a0598f-11b9-72d1-91d9-b2fbb186557d).