Migrate scenario2 intervention events to discrete variables - #343
Merged
ChrisRackauckas merged 1 commit intoSep 12, 2026
Merged
ChrisRackauckas merged 1 commit into
ChrisRackauckas merged 1 commit into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: OpenAI Codex <noreply@openai.com> Agent-Harness: Codex CLI 0.153.4 Agent-Model: gpt-6-astra Agent-Session: local session ID 01a0598f-11b9-72d1-91d9-b2fbb186557d
ChrisRackauckas
marked this pull request as ready for review
September 12, 2026 12:02
ChrisRackauckas
force-pushed
the
codex/fix-scenario2-event-api
branch
from
September 12, 2026 12:02
8e5847c to
6f2ddcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Migrate scenario2's three event-updated β values to
@discretesand replace equation-form event affects with Pair updates. Event times, update values, original unknowns, thresholds, and optimizer budgets are unchanged. Add concise docs guidance to check numerical validity as well as execution.This branch includes the separate scenario2 observable-defaults prerequisite commit; only the final commit is the event migration.
Failing before / passing after
The runner evaluates the actual nine named scenario2 documentation blocks:
Separate analytical checks: old discrete API failed; migrated discrete API 4/4, continuous control 3/3 passed. Local QA 23/23; Core 31/31, exit 0. Scoped formatting, spelling, and diff checks passed.
Execution is not numerical success: the unchanged timed optimizer returned MaxTime, objective Inf, u=[45,45], and maximum hospitalization 0.0527007069 > 0.05. The separate parameterized-times follow-up addresses that failure. This PR alone must not be described as fixing the optimization.
Full strict docs did not pass: exit 124 at six hours, with 46 failed blocks elsewhere and no final completion summary.
Validation scope
Historical results below were run locally with Julia 1.11.9 before rebasing onto current main (which now includes #336 and #337). The changed page is preserved by the rebase. These are not claims that the full documentation or all downstream packages pass. The user requested draft publication with these outstanding gates disclosed.
Native test/build commands, with a workspace-local TMPDIR and headless plotting:
GPU paths, downstream packages, and deployment were not verified. No tests or documentation errors were disabled.
Please ignore this draft until reviewed by @ChrisRackauckas.
The post-rebase page is byte-identical to its locally validated pre-rebase version. Fresh post-rebase QA and focused page checks were launched on September 12 and remain pending at publication; they are not counted as passes. Post-rebase spelling and diff checks passed.
Prerequisite draft: #342
🤖 Generated with Codex CLI 0.153.4 (model: gpt-6-astra; session: local session ID 01a0598f-11b9-72d1-91d9-b2fbb186557d).