Repository navigation
Refresh Carcione SBML system construction and solver - #345
Merged
ChrisRackauckas merged 1 commit intoSep 12, 2026
Merged
ChrisRackauckas merged 1 commit into
ChrisRackauckas merged 1 commit into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: OpenAI Codex <noreply@openai.com> Agent-Harness: Codex CLI 0.153.4 Agent-Model: gpt-6-astra Agent-Session: local session ID 01a0598f-11b9-72d1-91d9-b2fbb186557d
ChrisRackauckas
marked this pull request as ready for review
September 12, 2026 12:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Use SBMLToolkit's direct
ODESystem(mdl)construction and the currentRodas5P()solver in the Carcione tutorial. Keep structural_simplify, model input, parameters, time span, and the full 2,000-sample sensitivity example unchanged. No dependency is added.Failing before / passing after — partial migration only
The original conversion-based page fails during the initial construction blocks in the strict docs build. The registered-dependency control evaluates the first three actual corrected documentation blocks, then checks successful return code, completion time, and finite values:
Before, from the unmodified example in the strict build:
After:
The complete regression still fails (exit 1). The next parameter-override sensitivity check fails before solve because
Total_population#0(t)is present but is not an unknown. This draft does not claim a fully repaired tutorial or a passing 2,000-sample registered-dependency sensitivity run. Related ownership investigation: SciML/ModelingToolkit.jl#5073.The passing initial solve used registered SBMLToolkit 0.1.42, ModelingToolkit 11.42, ModelingToolkitBase 1.69, and SymbolicUtils 4.46.1, with only EasyModelAnalysis developed locally. An older composed run with local dependency patches is not used as evidence of registered-dependency success.
Full strict documentation is not green (six-hour timeout and example failures). No dedicated Carcione native QA/Core success is claimed; these two lines change only the documentation example. Formatting/spelling/diff checks and the executable initial-solve checks cover this limited migration. The residual failing sensitivity regression is retained, not suppressed.
Validation scope
Historical results below were run locally with Julia 1.11.9 before rebasing onto current main (which now includes #336 and #337). The changed page is preserved by the rebase. These are not claims that the full documentation or all downstream packages pass. The user requested draft publication with these outstanding gates disclosed.
Native test/build commands, with a workspace-local TMPDIR and headless plotting:
GPU paths, downstream packages, and deployment were not verified. No tests or documentation errors were disabled.
Please ignore this draft until reviewed by @ChrisRackauckas.
The post-rebase page is byte-identical to its locally validated pre-rebase version. Fresh post-rebase QA and focused page checks were launched on September 12 and remain pending at publication; they are not counted as passes. Post-rebase spelling and diff checks passed.
🤖 Generated with Codex CLI 0.153.4 (model: gpt-6-astra; session: local session ID 01a0598f-11b9-72d1-91d9-b2fbb186557d).