Skip to content

Parameterize scenario2 intervention times - #344

Merged
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:codex/fix-scenario2-parameterized-times
Sep 12, 2026
Merged

ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:codex/fix-scenario2-parameterized-times

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member

Change

Make the intervention start/stop symbolic parameters, construct the intervention system and problem once, and remake only parameter values for each objective evaluation. Preserve the original unknown order, event updates, explicit tstops, 60-second optimization budget, GN_ORIG_DIRECT, start point, daily 92 constraints, and thresholds. Add executable assertions for finite objective/constraints and the stated bounds.

This branch includes the separate scenario2 observable-defaults and event-API prerequisite commits; only the final commit parameterizes time. No warmup, reduced sample count, relaxed bound, or increased budget is used.

Failing before / passing after

The same official finite-objective assertion was added to the before control:

$ julia --startup-file=no --project=docs ../EasyModelAnalysis-intervention-audit/.validation/run-scenario2.jl <unparameterized-page-with-assertions>
ERROR: LoadError: AssertionError: isfinite(min_intervention_timespan.objective)
[block 6; exit 1]

$ julia --startup-file=no --project=docs ../EasyModelAnalysis-intervention-audit/.validation/run-scenario2.jl docs/src/scenarios/scenario2.md
CONSTRAINTS block=7 finite=true maximum=28.434119058685095
CONSTRAINTS block=9 finite=true maximum=0.049495697070600975
PASS scenario2 block 9
[all nine blocks; exit 0]

Fresh-process timed result: Success, u=[1.625577125839622,30.059696184524718], objective 28.434119058685095, maximum hospitalization 0.04999999963203557; bound residual -3.6796442975939314e-10. The unchanged continuous section returned MaxTime with finite feasible sampled constraints, not an optimality certificate.

Equivalence regression: 25/25 checks passed across eight predefined time pairs; all 92 sampled constraint values were bitwise equal to the old implementation. Re-evaluation at the optimized point also passed 5/5 checks. These checks establish sampled feasibility, not continuous-time feasibility or global optimality.

Local native QA 23/23 (10m13.7s); Core 31/31, exit 0. Scoped Runic checks of three new fragments, spelling, and diff checks passed. Full strict docs did not pass: exit 124 at six hours, with other documentation failures.

Validation scope

Historical results below were run locally with Julia 1.11.9 before rebasing onto current main (which now includes #336 and #337). The changed page is preserved by the rebase. These are not claims that the full documentation or all downstream packages pass. The user requested draft publication with these outstanding gates disclosed.

Native test/build commands, with a workspace-local TMPDIR and headless plotting:

GROUP=QA julia --startup-file=no --project=. -e 'using Pkg; Pkg.test()'
GROUP=Core julia --startup-file=no --project=. -e 'using Pkg; Pkg.test()'
GKSwstype=100 timeout 21600 julia --startup-file=no --project=docs docs/make.jl

GPU paths, downstream packages, and deployment were not verified. No tests or documentation errors were disabled.

Please ignore this draft until reviewed by @ChrisRackauckas.

The post-rebase page is byte-identical to its locally validated pre-rebase version. Fresh post-rebase QA and focused page checks were launched on September 12 and remain pending at publication; they are not counted as passes. Post-rebase spelling and diff checks passed.

Prerequisite drafts, in order: #342, #343

🤖 Generated with Codex CLI 0.153.4 (model: gpt-6-astra; session: local session ID 01a0598f-11b9-72d1-91d9-b2fbb186557d).

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Agent-Harness: Codex CLI 0.153.4
Agent-Model: gpt-6-astra
Agent-Session: local session ID 01a0598f-11b9-72d1-91d9-b2fbb186557d
@ChrisRackauckas
ChrisRackauckas marked this pull request as ready for review September 12, 2026 13:17
@ChrisRackauckas
ChrisRackauckas force-pushed the codex/fix-scenario2-parameterized-times branch from 7703227 to a732cc7 Compare September 12, 2026 13:17
@ChrisRackauckas
ChrisRackauckas merged commit 14dcbe8 into SciML:main Sep 12, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants