Repository navigation
Conversation
This was referenced Oct 6, 2026
thebhef
force-pushed
the
task163-frontend
branch
from
October 7, 2026 14:30
d194853 to
589b35d
Compare
This was referenced Oct 8, 2026
thebhef
marked this pull request as ready for review
October 14, 2026 21:09
thebhef
force-pushed
the
task163-frontend
branch
from
October 15, 2026 00:09
589b35d to
e04d937
Compare
This was referenced Oct 15, 2026
Owner
Author
Merge activity
|
Phase 6 flagged this as a side effect: the bus-health section's "reset without user action" paragraph described only the 2 s silent-queue reopen, left over from ADR 0039, and never mentioned the 1 s transmit-queue flush phase 4 added under ADR 0060 rule 7. It now names the flush, what it does per vendor, and that only a channel gone fully silent (no send, echo, or error frame) for two seconds is reopened rather than flushed. Swept every other doc surface ADR 0060 touches against the ADR itself and found nothing else stale: the sidecar's own README (Bus faults section, stats-line fields), SMOKE.md's PEAK/Vector steps, docs/CONTEXT.md's terms, and the cannet-wire/cannet-client crate docs were already current from phases 2b-5. Workspace rustdoc (-D warnings) is clean, so no new public item is missing docs either. This is task 163's final agent phase. The full CI check matrix (Rust test/clippy/fmt/rustdoc, wire breaking + gencode drift, the MDF oracle, frontend test+build, python-wire/sidecar/client ruff+mypy+pytest, the sidecar's slow fault-load harness, and a --no-smoke sidecar freeze) all pass at this tip, and a release binary builds clean (cargo build --release -p cannet-gui --features custom-protocol, embedding the already-built frontend without touching the sidecar's beforeBuildCommand smoke step). Detail, the release-notes entry, and the bench script for the owner's next pass are in the task file and release notes, left uncommitted for the orchestrator to carry. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 6 flagged this as a side effect: the bus-health section's
"reset without user action" paragraph described only the 2 s
silent-queue reopen, left over from ADR 0039, and never mentioned
the 1 s transmit-queue flush phase 4 added under ADR 0060 rule 7.
It now names the flush, what it does per vendor, and that only a
channel gone fully silent (no send, echo, or error frame) for two
seconds is reopened rather than flushed.
Swept every other doc surface ADR 0060 touches against the ADR
itself and found nothing else stale: the sidecar's own README
(Bus faults section, stats-line fields), SMOKE.md's PEAK/Vector
steps, docs/CONTEXT.md's terms, and the cannet-wire/cannet-client
crate docs were already current from phases 2b-5. Workspace
rustdoc (-D warnings) is clean, so no new public item is
missing docs either.
This is task 163's final agent phase. The full CI check matrix
(Rust test/clippy/fmt/rustdoc, wire breaking + gencode drift, the
MDF oracle, frontend test+build, python-wire/sidecar/client
ruff+mypy+pytest, the sidecar's slow fault-load harness, and a
--no-smoke sidecar freeze) all pass at this tip, and a release
binary builds clean (cargo build --release -p cannet-gui
--features custom-protocol, embedding the already-built frontend
without touching the sidecar's beforeBuildCommand smoke step).
Detail, the release-notes entry, and the bench script for the
owner's next pass are in the task file and release notes, left
uncommitted for the orchestrator to carry.
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com